From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 9/9] drm/i915: fix FBC for cases where crtc->base.y is non-zero Date: Wed, 23 Sep 2015 11:09:18 +0200 Message-ID: <20150923090918.GA3383@phenom.ffwll.local> References: <1442254803-20043-1-git-send-email-paulo.r.zanoni@intel.com> <1442254803-20043-9-git-send-email-paulo.r.zanoni@intel.com> <20150921140449.GI26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33CD36ECE1 for ; Wed, 23 Sep 2015 02:06:28 -0700 (PDT) Received: by wicgb1 with SMTP id gb1so195729645wic.1 for ; Wed, 23 Sep 2015 02:06:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150921140449.GI26517@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UHVsbGVkIGluIHRoZSBlbnRpcmUgc2VyaWVzIHRvIGRpbnEsIHRoYW5rcy4KLURhbmllbAoKT24g TW9uLCBTZXAgMjEsIDIwMTUgYXQgMDU6MDQ6NDlQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOkIHdy b3RlOgo+IE9uIE1vbiwgU2VwIDE0LCAyMDE1IGF0IDAzOjIwOjAzUE0gLTAzMDAsIFBhdWxvIFph bm9uaSB3cm90ZToKPiA+IEkgb25seSB0ZXN0ZWQgdGhpcyBvbiBCRFcgYW5kIFNLTCwgYnV0IHNp bmNlIHRoZSByZWdpc3RlciBkZXNjcmlwdGlvbgo+ID4gaXMgdGhlIHNhbWUgZXZlciBzaW5jZSBn ZW40LCBsZXQncyBhc3N1bWUgdGhhdCBhbGwgZ2VucyB0YWtlIHRoZSBzYW1lCj4gPiByZWdpc3Rl ciBmb3JtYXQuIElmIHRoYXQncyBub3QgdHJ1ZSwgdGhlbiBob3BlZnVsbHkgc29tZW9uZSB3aWxs Cj4gPiBiaXNlY3QgYSBidWcgdG8gdGhpcyBwYXRjaCBhbmQgd2UnbGwgZml4IGl0Lgo+ID4gCj4g PiBOb3RpY2UgdGhhdCB0aGUgd3JvbmcgZmVuY2Ugb2Zmc2V0IHJlZ2lzdGVyIGp1c3QgbWVhbnMg dGhhdCB0aGUKPiA+IGhhcmR3YXJlIHRyYWNraW5nIHdpbGwgYmUgd3JvbmcuCj4gPiAKPiA+IFRl c3RjYXNlczoKPiA+ICAtIGlndC9rbXNfZnJvbnRidWZmZXJfdHJhY2tpbmcvZmJjLTFwLXByaW1z Y3JuLXByaS1zaHJmYi1kcmF3LW1tYXAtZ3R0Cj4gPiAgLSBpZ3Qva21zX2Zyb250YnVmZmVyX3Ry YWNraW5nL2ZiYy0ycC1wcmltc2Nybi1wcmktc2hyZmItZHJhdy1tbWFwLWd0dAo+ID4gCj4gPiB2 MjoKPiA+ICAgLSBBZGQgaW50ZWxfY3J0Yy0+YWRqdXN0ZWRfe3gseX0gc28gdGhpcyBjb2RlIGNh biB3b3JrIGluZGVwZW5kZW50bHkKPiA+ICAgICBvZiBpbnRlbF9nZW40X2NvbXB1dGVfcGFnZV9v ZmZzZXQoKS4gKFZpbGxlKS4KPiA+ICAgLSBUaGlzIHZlcnNpb24gYWxzbyB3b3JrcyBvbiBTS0wu Cj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50 ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IHwgIDkgKysrKysrKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAg IHwgIDIgKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYyAgICAgfCAyNSAr KysrKysrKysrKysrKysrKysrKy0tLS0tCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAzMSBpbnNlcnRp b25zKCspLCA1IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gPiBpbmRleCBmYzAwODY3Li5jMjdhNjM2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBAIC0yNzMwLDYgKzI3MzAsOSBAQCBzdGF0aWMgdm9p ZCBpOXh4X3VwZGF0ZV9wcmltYXJ5X3BsYW5lKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+ICAJ CQkoaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY193IC0gMSkgKiBwaXhlbF9zaXplOwo+ID4g IAl9Cj4gPiAgCj4gPiArCWludGVsX2NydGMtPmFkanVzdGVkX3ggPSB4Owo+ID4gKwlpbnRlbF9j cnRjLT5hZGp1c3RlZF95ID0geTsKPiA+ICsKPiA+ICAJSTkxNV9XUklURShyZWcsIGRzcGNudHIp Owo+ID4gIAo+ID4gIAlJOTE1X1dSSVRFKERTUFNUUklERShwbGFuZSksIGZiLT5waXRjaGVzWzBd KTsKPiA+IEBAIC0yODMwLDYgKzI4MzMsOSBAQCBzdGF0aWMgdm9pZCBpcm9ubGFrZV91cGRhdGVf cHJpbWFyeV9wbGFuZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gPiAgCQl9Cj4gPiAgCX0KPiA+ ICAKPiA+ICsJaW50ZWxfY3J0Yy0+YWRqdXN0ZWRfeCA9IHg7Cj4gPiArCWludGVsX2NydGMtPmFk anVzdGVkX3kgPSB5Owo+ID4gKwo+ID4gIAlJOTE1X1dSSVRFKHJlZywgZHNwY250cik7Cj4gPiAg Cj4gPiAgCUk5MTVfV1JJVEUoRFNQU1RSSURFKHBsYW5lKSwgZmItPnBpdGNoZXNbMF0pOwo+ID4g QEAgLTMwODIsNiArMzA4OCw5IEBAIHN0YXRpYyB2b2lkIHNreWxha2VfdXBkYXRlX3ByaW1hcnlf cGxhbmUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gIAl9Cj4gPiAgCXBsYW5lX29mZnNldCA9 IHlfb2Zmc2V0IDw8IDE2IHwgeF9vZmZzZXQ7Cj4gPiAgCj4gPiArCWludGVsX2NydGMtPmFkanVz dGVkX3ggPSB4X29mZnNldDsKPiA+ICsJaW50ZWxfY3J0Yy0+YWRqdXN0ZWRfeSA9IHlfb2Zmc2V0 Owo+ID4gKwo+ID4gIAlJOTE1X1dSSVRFKFBMQU5FX0NUTChwaXBlLCAwKSwgcGxhbmVfY3RsKTsK PiA+ICAJSTkxNV9XUklURShQTEFORV9PRkZTRVQocGlwZSwgMCksIHBsYW5lX29mZnNldCk7Cj4g PiAgCUk5MTVfV1JJVEUoUExBTkVfU0laRShwaXBlLCAwKSwgcGxhbmVfc2l6ZSk7Cj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gaW5kZXggMDJhNzU1YS4uNjA1NGJjYiAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gQEAgLTUzNyw2ICs1MzcsOCBAQCBzdHJ1Y3Qg aW50ZWxfY3J0YyB7Cj4gPiAgCSAqIGdlbjQrIHRoaXMgb25seSBhZGp1c3RzIHVwIHRvIGEgdGls ZSwgb2Zmc2V0cyB3aXRoaW4gYSB0aWxlIGFyZQo+ID4gIAkgKiBoYW5kbGVkIGluIHRoZSBodyBp dHNlbGYgKHdpdGggdGhlIFRJTEVPRkYgcmVnaXN0ZXIpLiAqLwo+ID4gIAl1bnNpZ25lZCBsb25n IGRzcGFkZHJfb2Zmc2V0Owo+ID4gKwlpbnQgYWRqdXN0ZWRfeDsKPiA+ICsJaW50IGFkanVzdGVk X3k7Cj4gPiAgCj4gPiAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpjdXJzb3JfYm87Cj4g PiAgCXVpbnQzMl90IGN1cnNvcl9hZGRyOwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2ZiYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMKPiA+ IGluZGV4IGEzYTk3ZjIuLjIzMTlkYzUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9mYmMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJj LmMKPiA+IEBAIC00MSw2ICs0MSwxOSBAQAo+ID4gICNpbmNsdWRlICJpbnRlbF9kcnYuaCIKPiA+ ICAjaW5jbHVkZSAiaTkxNV9kcnYuaCIKPiA+ICAKPiA+ICsvKgo+ID4gKyAqIEluIHNvbWUgcGxh dGZvcm1zIHdoZXJlIHRoZSBDUlRDJ3MgeDowL3k6MCBjb29yZGluYXRlcyBkb2Vzbid0IG1hdGNo IHRoZQo+ID4gKyAqIGZyb250YnVmZmVyJ3MgeDowL3k6MCBjb29yZGluYXRlcyB3ZSBsaWUgdG8g dGhlIGhhcmR3YXJlIGFib3V0IHRoZSBwbGFuZSdzCj4gPiArICogb3JpZ2luIHNvIHRoZSB4IGFu ZCB5IG9mZnNldHMgY2FuIGFjdHVhbGx5IGZpdCB0aGUgcmVnaXN0ZXJzLiBBcyBhCj4gPiArICog Y29uc2VxdWVuY2UsIHRoZSBmZW5jZSBkb2Vzbid0IHJlYWxseSBzdGFydCBleGFjdGx5IGF0IHRo ZSBkaXNwbGF5IHBsYW5lCj4gPiArICogYWRkcmVzcyB3ZSBwcm9ncmFtIGJlY2F1c2UgaXQgc3Rh cnRzIGF0IHRoZSByZWFsIHN0YXJ0IG9mIHRoZSBidWZmZXIsIHNvIHdlCj4gPiArICogaGF2ZSB0 byB0YWtlIHRoaXMgaW50byBjb25zaWRlcmF0aW9uIGhlcmUuCj4gPiArICovCj4gPiArc3RhdGlj IHVuc2lnbmVkIGludCBnZXRfY3J0Y19mZW5jZV95X29mZnNldChzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YykKPiA+ICt7Cj4gPiArCXJldHVybiBjcnRjLT5iYXNlLnkgLSBjcnRjLT5hZGp1c3RlZF95 Owo+ID4gK30KPiAKPiBXZSBtYXkgd2FudCB0byBtb3ZlIG92ZXIgdG8gdXNpbmcgdGhlIHBsYW5l IHN0YXRlIGhlcmUgaW4gdGhlIGZ1dHVyZS4KPiBCdXQgZm9yIG5vdyBpdCBsb29rcyBPSywgc286 Cj4gCj4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gCj4gCj4gPiArCj4gPiAgc3RhdGljIHZvaWQgaTh4eF9mYmNfZGlzYWJsZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgewo+ID4gIAl1MzIgZmJjX2N0 bDsKPiA+IEBAIC05Nyw3ICsxMTAsNyBAQCBzdGF0aWMgdm9pZCBpOHh4X2ZiY19lbmFibGUoc3Ry dWN0IGludGVsX2NydGMgKmNydGMpCj4gPiAgCQlmYmNfY3RsMiA9IEZCQ19DVExfRkVOQ0VfREJM IHwgRkJDX0NUTF9JRExFX0lNTSB8IEZCQ19DVExfQ1BVX0ZFTkNFOwo+ID4gIAkJZmJjX2N0bDIg fD0gRkJDX0NUTF9QTEFORShjcnRjLT5wbGFuZSk7Cj4gPiAgCQlJOTE1X1dSSVRFKEZCQ19DT05U Uk9MMiwgZmJjX2N0bDIpOwo+ID4gLQkJSTkxNV9XUklURShGQkNfRkVOQ0VfT0ZGLCBjcnRjLT5i YXNlLnkpOwo+ID4gKwkJSTkxNV9XUklURShGQkNfRkVOQ0VfT0ZGLCBnZXRfY3J0Y19mZW5jZV95 X29mZnNldChjcnRjKSk7Cj4gPiAgCX0KPiA+ICAKPiA+ICAJLyogZW5hYmxlIGl0Li4uICovCj4g PiBAQCAtMTM1LDcgKzE0OCw3IEBAIHN0YXRpYyB2b2lkIGc0eF9mYmNfZW5hYmxlKHN0cnVjdCBp bnRlbF9jcnRjICpjcnRjKQo+ID4gIAkJZHBmY19jdGwgfD0gRFBGQ19DVExfTElNSVRfMVg7Cj4g PiAgCWRwZmNfY3RsIHw9IERQRkNfQ1RMX0ZFTkNFX0VOIHwgb2JqLT5mZW5jZV9yZWc7Cj4gPiAg Cj4gPiAtCUk5MTVfV1JJVEUoRFBGQ19GRU5DRV9ZT0ZGLCBjcnRjLT5iYXNlLnkpOwo+ID4gKwlJ OTE1X1dSSVRFKERQRkNfRkVOQ0VfWU9GRiwgZ2V0X2NydGNfZmVuY2VfeV9vZmZzZXQoY3J0Yykp Owo+ID4gIAo+ID4gIAkvKiBlbmFibGUgaXQuLi4gKi8KPiA+ICAJSTkxNV9XUklURShEUEZDX0NP TlRST0wsIGRwZmNfY3RsIHwgRFBGQ19DVExfRU4pOwo+ID4gQEAgLTE3Nyw2ICsxOTAsNyBAQCBz dGF0aWMgdm9pZCBpbGtfZmJjX2VuYWJsZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiA+ICAJ c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiA9IGludGVsX2ZiX29iaihmYik7Cj4gPiAg CXUzMiBkcGZjX2N0bDsKPiA+ICAJaW50IHRocmVzaG9sZCA9IGRldl9wcml2LT5mYmMudGhyZXNo b2xkOwo+ID4gKwl1bnNpZ25lZCBpbnQgeV9vZmZzZXQ7Cj4gPiAgCj4gPiAgCWRldl9wcml2LT5m YmMuZW5hYmxlZCA9IHRydWU7Cj4gPiAgCj4gPiBAQCAtMjAwLDcgKzIxNCw4IEBAIHN0YXRpYyB2 b2lkIGlsa19mYmNfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ID4gIAlpZiAoSVNf R0VONShkZXZfcHJpdikpCj4gPiAgCQlkcGZjX2N0bCB8PSBvYmotPmZlbmNlX3JlZzsKPiA+ICAK PiA+IC0JSTkxNV9XUklURShJTEtfRFBGQ19GRU5DRV9ZT0ZGLCBjcnRjLT5iYXNlLnkpOwo+ID4g Kwl5X29mZnNldCA9IGdldF9jcnRjX2ZlbmNlX3lfb2Zmc2V0KGNydGMpOwo+ID4gKwlJOTE1X1dS SVRFKElMS19EUEZDX0ZFTkNFX1lPRkYsIHlfb2Zmc2V0KTsKPiA+ICAJSTkxNV9XUklURShJTEtf RkJDX1JUX0JBU0UsIGk5MTVfZ2VtX29ial9nZ3R0X29mZnNldChvYmopIHwgSUxLX0ZCQ19SVF9W QUxJRCk7Cj4gPiAgCS8qIGVuYWJsZSBpdC4uLiAqLwo+ID4gIAlJOTE1X1dSSVRFKElMS19EUEZD X0NPTlRST0wsIGRwZmNfY3RsIHwgRFBGQ19DVExfRU4pOwo+ID4gQEAgLTIwOCw3ICsyMjMsNyBA QCBzdGF0aWMgdm9pZCBpbGtfZmJjX2VuYWJsZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiA+ ICAJaWYgKElTX0dFTjYoZGV2X3ByaXYpKSB7Cj4gPiAgCQlJOTE1X1dSSVRFKFNOQl9EUEZDX0NU TF9TQSwKPiA+ICAJCQkgICBTTkJfQ1BVX0ZFTkNFX0VOQUJMRSB8IG9iai0+ZmVuY2VfcmVnKTsK PiA+IC0JCUk5MTVfV1JJVEUoRFBGQ19DUFVfRkVOQ0VfT0ZGU0VULCBjcnRjLT5iYXNlLnkpOwo+ ID4gKwkJSTkxNV9XUklURShEUEZDX0NQVV9GRU5DRV9PRkZTRVQsIHlfb2Zmc2V0KTsKPiA+ICAJ fQo+ID4gIAo+ID4gIAlpbnRlbF9mYmNfbnVrZShkZXZfcHJpdik7Cj4gPiBAQCAtMjg4LDcgKzMw Myw3IEBAIHN0YXRpYyB2b2lkIGdlbjdfZmJjX2VuYWJsZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 YykKPiA+ICAKPiA+ICAJSTkxNV9XUklURShTTkJfRFBGQ19DVExfU0EsCj4gPiAgCQkgICBTTkJf Q1BVX0ZFTkNFX0VOQUJMRSB8IG9iai0+ZmVuY2VfcmVnKTsKPiA+IC0JSTkxNV9XUklURShEUEZD X0NQVV9GRU5DRV9PRkZTRVQsIGNydGMtPmJhc2UueSk7Cj4gPiArCUk5MTVfV1JJVEUoRFBGQ19D UFVfRkVOQ0VfT0ZGU0VULCBnZXRfY3J0Y19mZW5jZV95X29mZnNldChjcnRjKSk7Cj4gPiAgCj4g PiAgCWludGVsX2ZiY19udWtlKGRldl9wcml2KTsKPiA+ICAKPiA+IC0tIAo+ID4gMi41LjEKPiA+ IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngKPiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5n IGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0 ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xs LmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==