From: Daniel Vetter <daniel@ffwll.ch>
To: Arun Siluvery <arun.siluvery@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Dongwon Kim <dongwon.kim@intel.com>
Subject: Re: [PATCH] drm/i915: Do not hardcode s_max, ss_max and eu_mask for BXT
Date: Wed, 23 Sep 2015 15:37:27 +0200 [thread overview]
Message-ID: <20150923133727.GA3383@phenom.ffwll.local> (raw)
In-Reply-To: <55FC3DDC.9000807@linux.intel.com>
On Fri, Sep 18, 2015 at 05:37:48PM +0100, Arun Siluvery wrote:
> On 17/09/2015 19:26, Dongwon Kim wrote:
> >We can calculate BXT values correctly from GFX fuse values without
> >hardcoding special limits.
> >
> >Cc: Imre Deak <imre.deak@intel.com>
> >Cc: Matthew D Roper <matthew.d.roper@intel.com>
> >signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
> >---
> > drivers/gpu/drm/i915/i915_dma.c | 11 -----------
> > 1 file changed, 11 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> >index 066a0ef..4fe82d7 100644
> >--- a/drivers/gpu/drm/i915/i915_dma.c
> >+++ b/drivers/gpu/drm/i915/i915_dma.c
> >@@ -631,17 +631,6 @@ static void gen9_sseu_info_init(struct drm_device *dev)
> > u32 fuse2, s_enable, ss_disable, eu_disable;
> > u8 eu_mask = 0xff;
> >
> >- /*
> >- * BXT has a single slice. BXT also has at most 6 EU per subslice,
> >- * and therefore only the lowest 6 bits of the 8-bit EU disable
> >- * fields are valid.
> >- */
> >- if (IS_BROXTON(dev)) {
> >- s_max = 1;
> >- eu_max = 6;
> >- eu_mask = 0x3f;
> >- }
> >-
> > info = (struct intel_device_info *)&dev_priv->info;
> > fuse2 = I915_READ(GEN8_FUSE2);
> > s_enable = (fuse2 & GEN8_F2_S_ENA_MASK) >>
> >
>
> Without this change we are actually getting incorrect values in 'SSEU Device
> Info',
>
> # cat i915_sseu_status
> SSEU Device Info
> Available Slice Total: 1
> Available Subslice Total: 3
> Available Subslice Per Slice: 3
> Available EU Total: 15
> Available EU Per Subslice: 5
> Has Slice Power Gating: no
> Has Subslice Power Gating: yes
> Has EU Power Gating: yes
> SSEU Device Status
> Enabled Slice Total: 1
> Enabled Subslice Total: 3
> Enabled Subslice Per Slice: 3
> Enabled EU Total: 18
> Enabled EU Per Subslice: 6
>
> Looks good to me,
> Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-23 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 18:26 [PATCH] drm/i915: Do not hardcode s_max, ss_max and eu_mask for BXT Dongwon Kim
2015-09-18 16:37 ` Arun Siluvery
2015-09-23 13:37 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923133727.GA3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arun.siluvery@linux.intel.com \
--cc=dongwon.kim@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox