From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Do not update pipe state when crtc is inactive.
Date: Wed, 23 Sep 2015 17:56:32 +0200 [thread overview]
Message-ID: <20150923155632.GM3383@phenom.ffwll.local> (raw)
In-Reply-To: <874milpgqu.fsf@intel.com>
On Wed, Sep 23, 2015 at 01:33:29PM +0300, Jani Nikula wrote:
> On Wed, 23 Sep 2015, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
> > Op 23-09-15 om 11:01 schreef Jani Nikula:
> >> On Tue, 22 Sep 2015, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
> >>> Nothing good can come from detaching scalers or updating pipe config
> >>> when the crtc is already disabled. Touching registers while the crtc
> >>> and power wells are disabled causes unclaimed register access warnings.
> >> -fixes maintainer grumble. How am I supposed to decipher from this
> >> Subject: line and commit message whether this is a real fix to a real
> >> problem out there, and therefore to be queued for current -rc
> >> development kernels and possibly cc: stable, or not?
> >>
> >> When in doubt, I usually shrug it off, and decide it's for
> >> drm-intel-next-queued, and therefore SEP.
> >>
> > It's for v4.3, so -fixes. Should I explicitly mention it in the commit
> > message next time?
>
> If you have that information, please do. If not in the commit message,
> then either as a comment after the --- line or in the subject as [PATCH
> for v4.3] or something. Otherwise you'll be relying on my competence too
> much. ;)
What you really should do is mention which commit broke stuff and if
applicable, add a Bugzilla: link. That's required information anyway for
regression fixes, and we have maintainer scripts to tell us where to place
the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-23 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 14:26 [PATCH] drm/i915: Do not update pipe state when crtc is inactive Maarten Lankhorst
2015-09-23 9:01 ` Jani Nikula
2015-09-23 9:00 ` Maarten Lankhorst
2015-09-23 10:33 ` Jani Nikula
2015-09-23 15:56 ` Daniel Vetter [this message]
2015-10-13 12:36 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923155632.GM3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox