From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Arun Siluvery <arun.siluvery@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH 10/12] drm/i915/skl: Remove WaDisableVFUnitClockGating
Date: Fri, 25 Sep 2015 20:45:25 +0300 [thread overview]
Message-ID: <20150925174525.GF26517@intel.com> (raw)
In-Reply-To: <1443188026-1222-11-git-send-email-arun.siluvery@linux.intel.com>
On Fri, Sep 25, 2015 at 02:33:44PM +0100, Arun Siluvery wrote:
> Dropping it because it is for pre-production stepping, also removed
> bit definition in i915_reg.h as it is not used anywhere else.
>
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 1 -
> drivers/gpu/drm/i915/intel_pm.c | 6 ------
> 2 files changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index ef3d71f..b510fdc 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -6688,7 +6688,6 @@ enum skl_disp_power_wells {
> # define GEN6_CSUNIT_CLOCK_GATE_DISABLE (1 << 7)
>
> #define GEN6_UCGCTL2 0x9404
> -# define GEN6_VFUNIT_CLOCK_GATE_DISABLE (1 << 31)
Again, I would keep the define.
> # define GEN7_VDSUNIT_CLOCK_GATE_DISABLE (1 << 30)
> # define GEN7_TDLUNIT_CLOCK_GATE_DISABLE (1 << 22)
> # define GEN6_RCZUNIT_CLOCK_GATE_DISABLE (1 << 13)
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 65c60bc..88acb3e 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -75,12 +75,6 @@ static void skl_init_clock_gating(struct drm_device *dev)
>
> gen9_init_clock_gating(dev);
>
> - if (INTEL_REVID(dev) <= SKL_REVID_B0) {
> - /* WaDisableVFUnitClockGating:skl */
> - I915_WRITE(GEN6_UCGCTL2, I915_READ(GEN6_UCGCTL2) |
> - GEN6_VFUNIT_CLOCK_GATE_DISABLE);
> - }
> -
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> if (INTEL_REVID(dev) <= SKL_REVID_D0) {
> /* WaDisableHDCInvalidation:skl */
> I915_WRITE(GAM_ECOCHK, I915_READ(GAM_ECOCHK) |
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-25 17:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 13:33 [PATCH 00/12] Gen9: Changes to add/merge/update/remove WA Arun Siluvery
2015-09-25 13:33 ` [PATCH 01/12] drm/i915/gen9: Handle error returned by gen9_init_workarounds Arun Siluvery
2015-09-25 17:47 ` Ville Syrjälä
2015-09-28 13:55 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 02/12] drm/i915/gen9: Add WaOCLCoherentLineFlush Arun Siluvery
2015-09-25 17:09 ` Ville Syrjälä
2015-09-28 15:51 ` Arun Siluvery
2015-09-28 16:02 ` Ville Syrjälä
2015-09-28 16:35 ` Arun Siluvery
2015-09-25 13:33 ` [PATCH 03/12] drm/i915/gen9: Merge two WA as they part of same register Arun Siluvery
2015-09-25 17:47 ` Ville Syrjälä
2015-09-28 13:56 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 04/12] drm/i915/gen9: Merge HALF_SLICE_CHICKEN3 WA Arun Siluvery
2015-09-25 17:12 ` Ville Syrjälä
2015-09-28 8:47 ` Jani Nikula
2015-09-28 13:56 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 05/12] drm/i915/bxt: update WaSetHDCunitClckGatingDisable Arun Siluvery
2015-09-25 17:32 ` Ville Syrjälä
2015-09-25 13:33 ` [PATCH 06/12] drm/i915/bxt: Add WaStoreMultiplePTEenable name Arun Siluvery
2015-09-25 17:34 ` Ville Syrjälä
2015-09-28 13:57 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 07/12] drm/i915/bxt: Update stepping check for WaDisableSDEUnitClockGating Arun Siluvery
2015-09-25 17:17 ` Ville Syrjälä
2015-09-28 11:06 ` Imre Deak
2015-09-28 11:09 ` Arun Siluvery
2015-09-25 13:33 ` [PATCH 08/12] drm/i915/skl: Remove WaDisableSDEUnitClockGating Arun Siluvery
2015-09-25 17:39 ` Ville Syrjälä
2015-09-28 13:58 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 09/12] drm/i915/skl: Remove WaSetGAPSunitClckGateDisable Arun Siluvery
2015-09-25 17:43 ` Ville Syrjälä
2015-09-25 13:33 ` [PATCH 10/12] drm/i915/skl: Remove WaDisableVFUnitClockGating Arun Siluvery
2015-09-25 17:45 ` Ville Syrjälä [this message]
2015-09-28 14:01 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 11/12] drm/i915/skl: Remove WaSetDisablePixMaskCammingAndRhwoInCommonSliceChicken Arun Siluvery
2015-09-25 18:34 ` Ville Syrjälä
2015-09-25 18:43 ` Ville Syrjälä
2015-09-25 21:39 ` Arun Siluvery
2015-09-25 13:33 ` [PATCH 12/12] drm/i915:skl: Remove WaDisablePowerCompilerClockGating Arun Siluvery
2015-09-25 17:24 ` Ville Syrjälä
2015-09-28 11:21 ` [PATCH 00/12] Gen9: Changes to add/merge/update/remove WA Arun Siluvery
2015-09-28 14:03 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925174525.GF26517@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox