From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [DMC_BUGFIX_SKL_V2 3/5] drm/i915/skl: Making DC6 entry is the last call in suspend flow. Date: Mon, 28 Sep 2015 09:21:51 +0200 Message-ID: <20150928072151.GJ3383@phenom.ffwll.local> References: <1440533169-32265-1-git-send-email-animesh.manna@intel.com> <1440533169-32265-4-git-send-email-animesh.manna@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26C986E99C for ; Mon, 28 Sep 2015 00:18:58 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so91220948wic.0 for ; Mon, 28 Sep 2015 00:18:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1440533169-32265-4-git-send-email-animesh.manna@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Animesh Manna Cc: Rajneesh Bhardwaj , intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMjYsIDIwMTUgYXQgMDE6MzY6MDdBTSArMDUzMCwgQW5pbWVzaCBNYW5uYSB3 cm90ZToKPiBNbWlvIHJlZ2lzdGVyIGFjY2VzcyBhZnRlciBkYzYvZGM1IGVudHJ5IGlzIG5vdCBh bGxvd2VkIHdoZW4KPiBEQzYgcG93ZXIgc3RhdGVzIGFyZSBlbmFibGVkIGFjY29yZGluZyB0byBi c3BlYyAoYnNwZWMtaWQgMDUyNyksCj4gc28gZW5hYmxpbmcgZGM2IGFzIHRoZSBsYXN0IGNhbGwg aW4gc3VzcGVuZCBmbG93LgoKV2UgdW5jb25kaXRpb25hbHkgZ3JhYiBhIHBvd2VyIHdlbGwgcmVm ZXJlbmNlIGZvciBldmVyeXRoaW5nIGluIG91cgpzdXNwZW5kL3Jlc3VtZSBmdW5jdGlvbnMsIHdo aWNoIG1lYW5zIGRjNi81IHNob3VsZCBiZSBwcmV2ZW50ZWQgZm9yIGxvbmcKZW5vdWdoLgoKQWxz byBzaW5jZSBkYzYvNSBhcmUgcGFydCBvZiB0aGUgcG93ZXIgd2VsbCBmcmFtZXdvcmsgeW91IGNh bid0IGp1c3QKZW5hYmxlL2Rpc2FibGUgdGhlbSBkaXJlY3RseSwgaW5zdGVhZCB5b3UgbmVlZCB0 byBnZXQvcHV0IHRoZQpjb3JyZXNwb25kaW5nIHBvd2VyIHdlbGxzLgoKRmluYWxseSB0aGlzIHBh dGNoIGRvZXNuJ3QganVzdCBkbyB0aGF0LCBidXQgYWxzbyBmcm9icyBhcm91bmQgYSBsb3QgaW4K c2V0IHBvd2VyIHdlbGwgY29kZSBpdHNlbGYsIGFuZCBJIGhhdmUgbm8gaWRlYSB3aGF0IGl0IGRv ZXMgdGhlcmUgYW5kIHdoeS4KSXQgZG9lcyBzbWVsbCBhIGJpdCBsaWtlIHlvdSdyZSBqdXN0IGJy ZWFraW5nIGRjNiBmb3IgcnVudGltZSBwbSB0aG91Z2gsCndoaWNoIHdvdWxkbid0IGJlIGdvb2Qu CgpBbnl3YXkgSSBkZWNpZGVkIHRvIGp1c3QgbWVyZ2UgdGhpcyBzaW5jZSB0aGlzIHBhdGNoIHNl cmllcyBoYXMgYmVlbgpmbG9hdGluZyBhcm91bmQgc2luY2UgZm9yZXZlciwgYnV0IHRoZW4gdGhl IHBhdGNoIGRpZG4ndCBhcHBseSBjbGVhbmx5IGFuZApzbyBkcm9wcGVkIGl0LgotRGFuaWVsCgo+ IAo+IHYxOiBJbml0aWFsIHZlcnNpb24uCj4gCj4gdjI6IEJhc2VkIG9uIHJldmlldyBjb21tZW50 IGZyb20gRGFuaWVsLAo+IC0gY3JlYXRlZCBhIHNlcGVyYXRlIHBhdGNoIGZvciBjc3IgdW5pbml0 aWFsaXphdGlvbiBzZXQgY2FsbC4KPiAKPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBpbnRlbC5jb20+Cj4gQ2M6IERhbWllbiBMZXNwaWF1IDxkYW1pZW4ubGVzcGlhdUBpbnRlbC5j b20+Cj4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiBDYzogU3VuaWwgS2Ft YXRoIDxzdW5pbC5rYW1hdGhAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEFuaW1lc2ggTWFu bmEgPGFuaW1lc2gubWFubmFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFZhdGhzYWxhIE5h Z2FyYWp1IDx2YXRoc2FsYS5uYWdhcmFqdUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUmFq bmVlc2ggQmhhcmR3YWogPHJham5lZXNoLmJoYXJkd2FqQGludGVsLmNvbT4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyAgICAgICAgIHwgMTMgKysrKysrKysrKysrKwo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgICAgfCAgMiArKwo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgfCAxOSArKysrKysrLS0tLS0tLS0t LS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5kZXggNDc4MTAxYy4uZmE2NjE2MiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IEBAIC0xMDEzLDEwICsxMDEzLDIwIEBAIHN0YXRp YyBpbnQgaTkxNV9wbV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2KQo+ICAKPiAgc3RhdGljIGlu dCBza2xfc3VzcGVuZF9jb21wbGV0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gIHsKPiArCWVudW0gY3NyX3N0YXRlIHN0YXRlOwo+ICAJLyogRW5hYmxpbmcgREM2IGlzIG5v dCBhIGhhcmQgcmVxdWlyZW1lbnQgdG8gZW50ZXIgcnVudGltZSBEMyAqLwo+ICAKPiAgCXNrbF91 bmluaXRfY2RjbGsoZGV2X3ByaXYpOwo+ICAKPiArCS8qIFRPRE86IHdhaXQgZm9yIGEgY29tcGxl dGlvbiBldmVudCBvcgo+ICsJICogc2ltaWxhciBoZXJlIGluc3RlYWQgb2YgYnVzeQo+ICsJICog d2FpdGluZyB1c2luZyB3YWl0X2ZvciBmdW5jdGlvbi4KPiArCSAqLwo+ICsJd2FpdF9mb3IoKHN0 YXRlID0gaW50ZWxfY3NyX2xvYWRfc3RhdHVzX2dldChkZXZfcHJpdikpICE9Cj4gKwkJCUZXX1VO SU5JVElBTElaRUQsIDEwMDApOwo+ICsJaWYgKHN0YXRlID09IEZXX0xPQURFRCkKPiArCQlza2xf ZW5hYmxlX2RjNihkZXZfcHJpdik7Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gQEAgLTEw NjMsNiArMTA3Myw5IEBAIHN0YXRpYyBpbnQgc2tsX3Jlc3VtZV9wcmVwYXJlKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IGRldl9wcml2LT5kZXY7Cj4gIAo+ICsJaWYgKGludGVsX2Nzcl9sb2FkX3N0YXR1c19nZXQoZGV2 X3ByaXYpID09IEZXX0xPQURFRCkKPiArCQlza2xfZGlzYWJsZV9kYzYoZGV2X3ByaXYpOwo+ICsK PiAgCXNrbF9pbml0X2NkY2xrKGRldl9wcml2KTsKPiAgCWludGVsX2Nzcl9sb2FkX3Byb2dyYW0o ZGV2KTsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCA4MWI3ZDc3Li45Y2I3 ZDRlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTExOCw2ICsxMTE4LDgg QEAgdm9pZCBieHRfZW5hYmxlX2RjOShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Owo+ICB2b2lkIGJ4dF9kaXNhYmxlX2RjOShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpOwo+ICB2b2lkIHNrbF9pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdik7Cj4gIHZvaWQgc2tsX3VuaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYpOwo+ICt2b2lkIHNrbF9lbmFibGVfZGM2KHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdik7Cj4gK3ZvaWQgc2tsX2Rpc2FibGVfZGM2KHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdik7Cj4gIHZvaWQgaW50ZWxfZHBfZ2V0X21fbihzdHJ1Y3QgaW50ZWxfY3J0 YyAqY3J0YywKPiAgCQkgICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcp Owo+ICB2b2lkIGludGVsX2RwX3NldF9tX24oc3RydWN0IGludGVsX2NydGMgKmNydGMsIGVudW0g bGlua19tX25fc2V0IG1fbik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3J1bnRpbWVfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0u Ywo+IGluZGV4IDgyMTY0NGQuLjIzYTNhYTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcnVudGltZV9wbS5jCj4gQEAgLTU0OCw3ICs1NDgsNyBAQCBzdGF0aWMgdm9pZCBhc3NlcnRf Y2FuX2Rpc2FibGVfZGM2KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQki REM2IGFscmVhZHkgcHJvZ3JhbW1lZCB0byBiZSBkaXNhYmxlZC5cbiIpOwo+ICB9Cj4gIAo+IC1z dGF0aWMgdm9pZCBza2xfZW5hYmxlX2RjNihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gK3ZvaWQgc2tsX2VuYWJsZV9kYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICB7Cj4gIAl1aW50MzJfdCB2YWw7Cj4gIAo+IEBAIC01NjUsNyArNTY1LDcgQEAgc3Rh dGljIHZvaWQgc2tsX2VuYWJsZV9kYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAJUE9TVElOR19SRUFEKERDX1NUQVRFX0VOKTsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQg c2tsX2Rpc2FibGVfZGM2KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArdm9p ZCBza2xfZGlzYWJsZV9kYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7 Cj4gIAl1aW50MzJfdCB2YWw7Cj4gIAo+IEBAIC02MjYsMTAgKzYyNiwxMCBAQCBzdGF0aWMgdm9p ZCBza2xfc2V0X3Bvd2VyX3dlbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ ICAJCQkJIUk5MTVfUkVBRChIU1dfUFdSX1dFTExfQklPUyksCj4gIAkJCQkiSW52YWxpZCBmb3Ig cG93ZXIgd2VsbCBzdGF0dXMgdG8gYmUgZW5hYmxlZCwgdW5sZXNzIGRvbmUgYnkgdGhlIEJJT1Ms IFwKPiAgCQkJCXdoZW4gcmVxdWVzdCBpcyB0byBkaXNhYmxlIVxuIik7Cj4gLQkJCWlmICgoR0VO OV9FTkFCTEVfREM1KGRldikgfHwgU0tMX0VOQUJMRV9EQzYoZGV2KSkgJiYKPiAtCQkJCXBvd2Vy X3dlbGwtPmRhdGEgPT0gU0tMX0RJU1BfUFdfMikgewo+ICsJCQlpZiAocG93ZXJfd2VsbC0+ZGF0 YSA9PSBTS0xfRElTUF9QV18yKSB7Cj4gKwkJCQlpZiAoR0VOOV9FTkFCTEVfREM1KGRldikpCj4g KwkJCQkJZ2VuOV9kaXNhYmxlX2RjNShkZXZfcHJpdik7Cj4gIAkJCQlpZiAoU0tMX0VOQUJMRV9E QzYoZGV2KSkgewo+IC0JCQkJCXNrbF9kaXNhYmxlX2RjNihkZXZfcHJpdik7Cj4gIAkJCQkJLyoK PiAgCQkJCQkgKiBEREkgYnVmZmVyIHByb2dyYW1taW5nIHVubmVjZXNzYXJ5IGR1cmluZyBkcml2 ZXItbG9hZC9yZXN1bWUKPiAgCQkJCQkgKiBhcyBpdCdzIGFscmVhZHkgZG9uZSBkdXJpbmcgbW9k ZXNldCBpbml0aWFsaXphdGlvbiB0aGVuLgo+IEBAIC02MzcsOCArNjM3LDYgQEAgc3RhdGljIHZv aWQgc2tsX3NldF9wb3dlcl93ZWxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK PiAgCQkJCQkgKi8KPiAgCQkJCQlpZiAoIWRldl9wcml2LT5wb3dlcl9kb21haW5zLmluaXRpYWxp emluZykKPiAgCQkJCQkJaW50ZWxfcHJlcGFyZV9kZGkoZGV2KTsKPiAtCQkJCX0gZWxzZSB7Cj4g LQkJCQkJZ2VuOV9kaXNhYmxlX2RjNShkZXZfcHJpdik7Cj4gIAkJCQl9Cj4gIAkJCX0KPiAgCQkJ STkxNV9XUklURShIU1dfUFdSX1dFTExfRFJJVkVSLCB0bXAgfCByZXFfbWFzayk7Cj4gQEAgLTY1 OCw3ICs2NTYsNyBAQCBzdGF0aWMgdm9pZCBza2xfc2V0X3Bvd2VyX3dlbGwoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQlQT1NUSU5HX1JFQUQoSFNXX1BXUl9XRUxMX0RS SVZFUik7Cj4gIAkJCURSTV9ERUJVR19LTVMoIkRpc2FibGluZyAlc1xuIiwgcG93ZXJfd2VsbC0+ bmFtZSk7Cj4gIAo+IC0JCQlpZiAoKEdFTjlfRU5BQkxFX0RDNShkZXYpIHx8IFNLTF9FTkFCTEVf REM2KGRldikpICYmCj4gKwkJCWlmIChHRU45X0VOQUJMRV9EQzUoZGV2KSAmJgo+ICAJCQkJcG93 ZXJfd2VsbC0+ZGF0YSA9PSBTS0xfRElTUF9QV18yKSB7Cj4gIAkJCQllbnVtIGNzcl9zdGF0ZSBz dGF0ZTsKPiAgCQkJCS8qIFRPRE86IHdhaXQgZm9yIGEgY29tcGxldGlvbiBldmVudCBvcgo+IEBA IC02NzEsMTAgKzY2OSw3IEBAIHN0YXRpYyB2b2lkIHNrbF9zZXRfcG93ZXJfd2VsbChzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCQkJRFJNX0VSUk9SKCJDU1IgZmlybXdh cmUgbm90IHJlYWR5ICglZClcbiIsCj4gIAkJCQkJCQlzdGF0ZSk7Cj4gIAkJCQllbHNlCj4gLQkJ CQkJaWYgKFNLTF9FTkFCTEVfREM2KGRldikpCj4gLQkJCQkJCXNrbF9lbmFibGVfZGM2KGRldl9w cml2KTsKPiAtCQkJCQllbHNlCj4gLQkJCQkJCWdlbjlfZW5hYmxlX2RjNShkZXZfcHJpdik7Cj4g KwkJCQkJZ2VuOV9lbmFibGVfZGM1KGRldl9wcml2KTsKPiAgCQkJfQo+ICAJCX0KPiAgCX0KPiAt LSAKPiAyLjAuMgo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK