From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/15] drm/i915/guc: Add GuC css header parser
Date: Mon, 28 Sep 2015 09:38:04 +0200 [thread overview]
Message-ID: <20150928073804.GM3383@phenom.ffwll.local> (raw)
In-Reply-To: <87d1x6muq2.fsf@intel.com>
On Fri, Sep 25, 2015 at 05:36:37PM +0300, Jani Nikula wrote:
> On Wed, 16 Sep 2015, yu.dai@intel.com wrote:
> > From: Alex Dai <yu.dai@intel.com>
> >
> > By using information from GuC css header, we can eliminate some
> > hard code w.r.t size of some components of firmware.
>
> There's a catch here. You can't trust any of the firmware blob
> contents. None at all. It's all malicious user input as far as the
> kernel is concerned, and we don't have the means to check the signature.
>
> I like the use of the __packed struct here, and I like making this more
> dynamic. But you have to check the bounds for everything you use from
> the css header.
I'm on the fence about that one really - on real systems firmware is
tightly locked down and there's patches to auth firmware signatures too
afaik. It's blobs we upload to the hw, it could do anything after all ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-28 7:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 22:52 [PATCH] drm/i915: Add GuC css header parser yu.dai
2015-09-03 7:36 ` Jani Nikula
2015-09-03 16:52 ` Yu Dai
2015-09-04 8:13 ` Daniel Vetter
2015-09-04 20:45 ` [PATCH v1] " yu.dai
2015-09-15 23:28 ` [PATCH 02/15] drm/i915/guc: " yu.dai
2015-09-25 14:36 ` Jani Nikula
2015-09-28 7:38 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928073804.GM3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox