From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bxt: Set oscaledcompmethod to enable scale value
Date: Mon, 28 Sep 2015 10:27:26 +0200 [thread overview]
Message-ID: <20150928082726.GT3383@phenom.ffwll.local> (raw)
In-Reply-To: <1443093122.26315.0.camel@intel.com>
On Thu, Sep 24, 2015 at 02:12:02PM +0300, Imre Deak wrote:
> On to, 2015-09-24 at 10:22 +0530, Sonika Jindal wrote:
> > Bspec update tells that we have to enable oscaledcompmethod instead of
> > ouniqetrangenmethod for enabling scale value during swing programming.
> >
> > v2: Adding back 'don't care' values to bxt_ddi_translations_dp and add
> > error message if ouniquetrangemethod was set (Imre)
> >
> > Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> > Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>(v1)
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 3 ++-
> > drivers/gpu/drm/i915/intel_ddi.c | 8 ++++++--
> > 2 files changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 812b7b2..3f2135d 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -1395,7 +1395,8 @@ enum skl_disp_power_wells {
> > #define BXT_PORT_TX_DW3_LN0(port) _PORT3(port, _PORT_TX_DW3_LN0_A, \
> > _PORT_TX_DW3_LN0_B, \
> > _PORT_TX_DW3_LN0_C)
> > -#define UNIQE_TRANGE_EN_METHOD (1 << 27)
> > +#define SCALE_DCOMP_METHOD (1 << 26)
> > +#define UNIQUE_TRANGE_EN_METHOD (1 << 27)
> >
> > #define _PORT_TX_DW4_LN0_A 0x162510
> > #define _PORT_TX_DW4_LN0_B 0x6C510
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index fec51df..7705bc9 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -2151,9 +2151,13 @@ static void bxt_ddi_vswing_sequence(struct drm_device *dev, u32 level,
> > I915_WRITE(BXT_PORT_TX_DW2_GRP(port), val);
> >
> > val = I915_READ(BXT_PORT_TX_DW3_LN0(port));
> > - val &= ~UNIQE_TRANGE_EN_METHOD;
> > + val &= ~SCALE_DCOMP_METHOD;
> > if (ddi_translations[level].enable)
> > - val |= UNIQE_TRANGE_EN_METHOD;
> > + val |= SCALE_DCOMP_METHOD;
> > +
> > + if ((val & UNIQUE_TRANGE_EN_METHOD) && !(val & SCALE_DCOMP_METHOD))
> > + DRM_ERROR("Disabled scaling while ouniqetrangenmethod was set");
> > +
> > I915_WRITE(BXT_PORT_TX_DW3_GRP(port), val);
> >
> > val = I915_READ(BXT_PORT_TX_DW4_LN0(port));
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-28 8:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 8:41 [PATCH 1/2] drm/i915/bxt: Set oscaledcompmethod to enable scale value Sonika Jindal
2015-09-18 8:41 ` [PATCH 2/2] drm/i915/bxt: eDP low vswing support Sonika Jindal
2015-09-21 17:32 ` Sivakumar Thulasimani
2015-09-24 4:54 ` [PATCH] " Sonika Jindal
2015-09-28 8:22 ` Daniel Vetter
2015-09-21 17:30 ` [PATCH 1/2] drm/i915/bxt: Set oscaledcompmethod to enable scale value Sivakumar Thulasimani
2015-09-22 13:02 ` Imre Deak
2015-09-22 18:31 ` Sivakumar Thulasimani
2015-09-22 19:32 ` Imre Deak
2015-09-23 4:07 ` Jindal, Sonika
2015-09-23 11:45 ` Imre Deak
2015-09-24 4:52 ` [PATCH] " Sonika Jindal
2015-09-24 11:12 ` Imre Deak
2015-09-28 8:27 ` Daniel Vetter [this message]
2015-09-24 5:03 ` [PATCH 1/2] " Jindal, Sonika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928082726.GT3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox