From: Daniel Vetter <daniel@ffwll.ch>
To: Takashi Iwai <tiwai@suse.de>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] drm/i915: Add missing const to audio_rate_need_prog()
Date: Wed, 30 Sep 2015 14:31:31 +0200 [thread overview]
Message-ID: <20150930123131.GI3383@phenom.ffwll.local> (raw)
In-Reply-To: <1443599103-26317-1-git-send-email-tiwai@suse.de>
On Wed, Sep 30, 2015 at 09:45:03AM +0200, Takashi Iwai wrote:
> The lack of const leads to a compile warning after merging i915
> upstream tree:
> drivers/gpu/drm/i915/intel_audio.c:147:13: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Yup, I have that in my merge resolution in drm-intel-nightly when pull in
your sound tree.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Atm I don't see a need for another merge on my side, I'll ping you when
that happens. So probably simplest to apply this to the sound tree.
Cheers, Daniel
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 30f6859dcb36..dffd0b4c5f17 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -144,7 +144,7 @@ static uint32_t audio_config_setup_n_reg(int n, uint32_t val)
>
> /* check whether N/CTS/M need be set manually */
> static bool audio_rate_need_prog(struct intel_crtc *crtc,
> - struct drm_display_mode *mode)
> + const struct drm_display_mode *mode)
> {
> if (((mode->clock == TMDS_297M) ||
> (mode->clock == TMDS_296M)) &&
> --
> 2.5.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-30 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 7:45 [PATCH] drm/i915: Add missing const to audio_rate_need_prog() Takashi Iwai
2015-09-30 12:31 ` Daniel Vetter [this message]
2015-09-30 12:38 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930123131.GI3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox