From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 20/43] drm/i915: Use paramtrized WRPLL_CTL()
Date: Wed, 30 Sep 2015 17:00:31 +0300
Message-ID: <20150930140031.GO26517@intel.com>
References: <1442595836-23981-1-git-send-email-ville.syrjala@linux.intel.com>
 <1442595836-23981-21-git-send-email-ville.syrjala@linux.intel.com>
 <87d1x0c8l1.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTP id 3D7696EBBC
 for <intel-gfx@lists.freedesktop.org>; Wed, 30 Sep 2015 07:00:34 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <87d1x0c8l1.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBTZXAgMzAsIDIwMTUgYXQgMDQ6NTg6MzRQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gT24gRnJpLCAxOCBTZXAgMjAxNSwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20g
d3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50
ZWwuY29tPgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly
amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X3JlZy5oICAgICAgfCAyICstCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRp
LmMgICAgIHwgOCArKysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs
YXkuYyB8IDQgKystLQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA3IGRl
bGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gaW5kZXggMjU4NjRh
ZS4uYThmYjVmNyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVn
LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+IEBAIC03MjUz
LDcgKzcyNTMsNyBAQCBlbnVtIHNrbF9kaXNwX3Bvd2VyX3dlbGxzIHsKPiA+ICAvKiBXUlBMTCAq
Lwo+ID4gICNkZWZpbmUgV1JQTExfQ1RMMQkJCTB4NDYwNDAKPiA+ICAjZGVmaW5lIFdSUExMX0NU
TDIJCQkweDQ2MDYwCj4gPiAtI2RlZmluZSBXUlBMTF9DVEwocGxsKQkJCShwbGwgPT0gMCA/IFdS
UExMX0NUTDEgOiBXUlBMTF9DVEwyKQo+ID4gKyNkZWZpbmUgV1JQTExfQ1RMKHBsbCkJCQlfUElQ
RShwbGwsIFdSUExMX0NUTDEsIFdSUExMX0NUTDIpCj4gCj4gSSBob3BlIHdlIG5ldmVyIGFjY2lk
ZW50YWxseSBwYXNzIHBsbCA+PSAyIGhlcmUuLi4gSSBndWVzcyB3ZSdsbCBmaW5kCj4gb3V0LiA7
KQo+IAo+IEkga25vdyB3ZSBkbyByZXVzZSBfUElQRSBsaWtlIHRoaXMsIGJ1dCBtYXliZSB3ZSBz
aG91bGQgaGF2ZSBhIGRpZmZlcmVudAo+IG1hY3JvIHRoYXQgZW1waGFzaXplcyB0aGUgcGFyYW1l
dGVyIGlzIHJlYWxseSBub3QgcGlwZSBiYXNlZCwgYnV0IHJhdGhlcgo+IGFuIElEIG9yIGVudW1l
cmF0aW9uLiBUaGVyZSdzIHZhbHVlIGluIHNlbGYtZG9jdW1lbnRhdGluZyBjb2RlLCBhbmQKPiAq
Z2FzcCogbWF5YmUgd2UnbGwgZXZlbnR1YWxseSBtYWtlIHRoaXMgc3R1ZmYgdHlwZSBzYWZlIHRv
byEgQmFzaWNhbGx5Cj4gaXQgd291bGQgYmUgYW4gYWxpYXMgZm9yIF9QSVBFKCk7IHNlZSBfUExB
TkUoKS4gT3IgbWF5YmUgX1BJUEUgYW5kCj4gX1BMQU5FIGNvdWxkIGJlIGJhc2VkIG9uIHRoZSBu
ZXcgb25lLgoKWWVhaCwgSSBzdXBwb3NlIHNvbWUga2luZCBvZiBiYXNlIG1hY3JvIHdvdWxkIGJl
IGdvb2QsIGFuZCB0aGVuIGp1c3QgZ2l2ZSBpdAphbGlhc2VzLiBJIHdhcyBhbHNvIHRoaW5raW5n
IG9mIGhhdmluZyBhIG1hY3JvIGZvciB0aGUgdHlwaWNhbAonKChiYXNlKSArIChuKSAqIDQnIHR5
cGUgb2Ygc3R1ZmYuCgo+IEFueXdheSwganVzdCBhIHRob3VnaHQsIHRoaXMgaXMKPiAKPiBSZXZp
ZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiAKPiAKPiA+ICAj
ZGVmaW5lICBXUlBMTF9QTExfRU5BQkxFCQkoMTw8MzEpCj4gPiAgI2RlZmluZSAgV1JQTExfUExM
X1NTQwkJCSgxPDwyOCkKPiA+ICAjZGVmaW5lICBXUlBMTF9QTExfTk9OX1NTQwkJKDI8PDI4KQo+
ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IGluZGV4IDM5OWU3MGUuLmZiNDU2YTQgMTAw
NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IEBAIC0xMDk0LDEwICsxMDk0LDEw
IEBAIHN0YXRpYyB2b2lkIGhzd19kZGlfY2xvY2tfZ2V0KHN0cnVjdCBpbnRlbF9lbmNvZGVyICpl
bmNvZGVyLAo+ID4gIAkJbGlua19jbG9jayA9IDI3MDAwMDsKPiA+ICAJCWJyZWFrOwo+ID4gIAlj
YXNlIFBPUlRfQ0xLX1NFTF9XUlBMTDE6Cj4gPiAtCQlsaW5rX2Nsb2NrID0gaHN3X2RkaV9jYWxj
X3dycGxsX2xpbmsoZGV2X3ByaXYsIFdSUExMX0NUTDEpOwo+ID4gKwkJbGlua19jbG9jayA9IGhz
d19kZGlfY2FsY193cnBsbF9saW5rKGRldl9wcml2LCBXUlBMTF9DVEwoMCkpOwo+ID4gIAkJYnJl
YWs7Cj4gPiAgCWNhc2UgUE9SVF9DTEtfU0VMX1dSUExMMjoKPiA+IC0JCWxpbmtfY2xvY2sgPSBo
c3dfZGRpX2NhbGNfd3JwbGxfbGluayhkZXZfcHJpdiwgV1JQTExfQ1RMMik7Cj4gPiArCQlsaW5r
X2Nsb2NrID0gaHN3X2RkaV9jYWxjX3dycGxsX2xpbmsoZGV2X3ByaXYsIFdSUExMX0NUTCgxKSk7
Cj4gPiAgCQlicmVhazsKPiA+ICAJY2FzZSBQT1JUX0NMS19TRUxfU1BMTDoKPiA+ICAJCXBsbCA9
IEk5MTVfUkVBRChTUExMX0NUTCkgJiBTUExMX1BMTF9GUkVRX01BU0s7Cj4gPiBAQCAtMjQ4NSwx
MyArMjQ4NSwxMyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHNrbF9kcGxsX3JlZ3Mgc2tsX2RwbGxf
cmVnc1szXSA9IHsKPiA+ICAJfSwKPiA+ICAJewo+ID4gIAkJLyogRFBMTCAyICovCj4gPiAtCQku
Y3RsID0gV1JQTExfQ1RMMSwKPiA+ICsJCS5jdGwgPSBXUlBMTF9DVEwoMCksCj4gPiAgCQkuY2Zn
Y3IxID0gRFBMTF9DRkdDUjEoMiksCj4gPiAgCQkuY2ZnY3IyID0gRFBMTF9DRkdDUjIoMiksCj4g
PiAgCX0sCj4gPiAgCXsKPiA+ICAJCS8qIERQTEwgMyAqLwo+ID4gLQkJLmN0bCA9IFdSUExMX0NU
TDIsCj4gPiArCQkuY3RsID0gV1JQTExfQ1RMKDEpLAo+ID4gIAkJLmNmZ2NyMSA9IERQTExfQ0ZH
Q1IxKDMpLAo+ID4gIAkJLmNmZ2NyMiA9IERQTExfQ0ZHQ1IyKDMpLAo+ID4gIAl9LAo+ID4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggNjNjZjVlYi4uZmE3YzEwZmEg
MTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+
ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAgLTkyMzcs
OCArOTIzNyw4IEBAIHN0YXRpYyB2b2lkIGFzc2VydF9jYW5fZGlzYWJsZV9sY3BsbChzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCj4gPiAgCUk5MTVfU1RBVEVfV0FSTihJ
OTE1X1JFQUQoSFNXX1BXUl9XRUxMX0RSSVZFUiksICJQb3dlciB3ZWxsIG9uXG4iKTsKPiA+ICAJ
STkxNV9TVEFURV9XQVJOKEk5MTVfUkVBRChTUExMX0NUTCkgJiBTUExMX1BMTF9FTkFCTEUsICJT
UExMIGVuYWJsZWRcbiIpOwo+ID4gLQlJOTE1X1NUQVRFX1dBUk4oSTkxNV9SRUFEKFdSUExMX0NU
TDEpICYgV1JQTExfUExMX0VOQUJMRSwgIldSUExMMSBlbmFibGVkXG4iKTsKPiA+IC0JSTkxNV9T
VEFURV9XQVJOKEk5MTVfUkVBRChXUlBMTF9DVEwyKSAmIFdSUExMX1BMTF9FTkFCTEUsICJXUlBM
TDIgZW5hYmxlZFxuIik7Cj4gPiArCUk5MTVfU1RBVEVfV0FSTihJOTE1X1JFQUQoV1JQTExfQ1RM
KDApKSAmIFdSUExMX1BMTF9FTkFCTEUsICJXUlBMTDEgZW5hYmxlZFxuIik7Cj4gPiArCUk5MTVf
U1RBVEVfV0FSTihJOTE1X1JFQUQoV1JQTExfQ1RMKDEpKSAmIFdSUExMX1BMTF9FTkFCTEUsICJX
UlBMTDIgZW5hYmxlZFxuIik7Cj4gPiAgCUk5MTVfU1RBVEVfV0FSTihJOTE1X1JFQUQoUENIX1BQ
X1NUQVRVUykgJiBQUF9PTiwgIlBhbmVsIHBvd2VyIG9uXG4iKTsKPiA+ICAJSTkxNV9TVEFURV9X
QVJOKEk5MTVfUkVBRChCTENfUFdNX0NQVV9DVEwyKSAmIEJMTV9QV01fRU5BQkxFLAo+ID4gIAkg
ICAgICJDUFUgUFdNMSBlbmFibGVkXG4iKTsKPiA+IC0tIAo+ID4gMi40LjYKPiA+Cj4gPiBfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0
cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+
IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgoK
LS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZngK