From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: fix CFB size calculation Date: Thu, 1 Oct 2015 15:14:13 +0300 Message-ID: <20151001121413.GE26517@intel.com> References: <1443023547-19896-1-git-send-email-paulo.r.zanoni@intel.com> <1443643545-3603-1-git-send-email-paulo.r.zanoni@intel.com> <1443643545-3603-2-git-send-email-paulo.r.zanoni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 255EF6E174 for ; Thu, 1 Oct 2015 05:14:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1443643545-3603-2-git-send-email-paulo.r.zanoni@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMzAsIDIwMTUgYXQgMDU6MDU6NDRQTSAtMDMwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IFdlIHdlcmUgY29uc2lkZXJpbmcgdGhlIHdob2xlIGZyYW1lYnVmZmVyIGhlaWdodCwg YnV0IHRoZSBzcGVjIHNheXMgd2UKPiBzaG91bGQgb25seSBjb25zaWRlciB0aGUgYWN0aXZlIGRp c3BsYXkgaGVpZ2h0IHNpemUuIFRoZXJlIHdlcmUgc3RpbGwKPiBzb21lIHVuY2xlYXIgcXVlc3Rp b25zIGJhc2VkIG9uIHRoZSBzcGVjLCBidXQgdGhlIGhhcmR3YXJlIGd1eXMKPiBjbGFyaWZpZWQg dGhlbSBmb3IgdXMuIEFjY29yZGluZyB0byB0aGVtOgo+IAo+IC0gQ0ZCIHNpemUgPSBDRkIgc3Ry aWRlICogTnVtYmVyIG9mIGxpbmVzIEZCQyB3cml0ZXMgdG8gQ0ZCCj4gLSBDRkIgc3RyaWRlID0g cGxhbmUgc3RyaWRlIC8gY29tcHJlc3Npb24gbGltaXQKPiAtIE51bWJlciBvZiBsaW5lcyBGQkMg d3JpdGVzIHRvIENGQiA9IE1JTihwbGFuZSBzb3VyY2UgaGVpZ2h0LCBtYXhpbXVtCj4gICBudW1i ZXIgb2YgbGluZXMgRkJDIHdyaXRlcyB0byBDRkIpCj4gLSBQbGFuZSBzb3VyY2UgaGVpZ2h0ID0K PiAgIC0gcGlwZSBzb3VyY2UgaGVpZ2h0IChQSVBFX1NSQ1NaIHJlZ2lzdGVyKSAoYmVmb3JlIFNL TCkKPiAgIC0gcGxhbmUgc2l6ZSByZWdpc3RlciBoZWlnaHQgKFBMQU5FX1NJWkUgcmVnaXN0ZXIp IChTS0wrKQo+IC0gTWF4aW11bSBudW1iZXIgb2YgbGluZXMgRkJDIHdyaXRlcyB0byBDRkIgPQo+ ICAgLSBwbGFuZSBzb3VyY2UgaGVpZ2h0IChiZWZvcmUgSFNXKQo+ICAgLSAyMDQ4IChIU1crKQo+ IAo+IEZvciB0aGUgcGxhbmUgc291cmNlIGhlaWdodCwgSSBjb3VsZCBqdXN0IGhhdmUgbWFkZSBv dXIgY29kZSBkbwo+IEk5MTVfUkVBRCgpIGluIG9yZGVyIHRvIGJlIG1vcmUgZnV0dXJlIHByb29m LCBidXQgc2luY2UgaXQncyBub3QgY29vbAo+IHRvIGRvIHJlZ2lzdGVyIHJlYWRzIEkgZGVjaWRl ZCB0byBqdXN0IHJlY2FsY3VsYXRlIHRoZSB2YWx1ZXMgd2UgdXNlCj4gd2hlbiB3ZSBhY3R1YWxs eSB3cml0ZSB0byB0aG9zZSByZWdpc3RlcnMuCj4gCj4gV2l0aCB0aGlzIHBhdGNoLCBkZXBlbmRp bmcgb24geW91ciBtYWNoaW5lIGNvbmZpZ3VyYXRpb24sIGEgbG90IG9mIHRoZQo+IGttc19mcm9u dGJ1ZmZlcl90cmFja2luZyBzdWJ0ZXN0cyB0aGF0IHVzZWQgdG8gcmVzdWx0IGluIGEgU0tJUCBk dWUgdG8KPiBub3QgZW5vdWdoIHN0b2xlbiBtZW1vcnkgc3RpbGwgc3RhcnQgcmVzdWx0aW5nIGlu IGEgUEFTUy4KPiAKPiB2MjogVXNlIHRoZSBjbGlwcGVkIHNyYyBzaXplIGluc3RlYWQgb2YgcGlw ZV9zcmNfaCAoVmlsbGUpLgo+IHYzOiBVc2UgdGhlIGFwcHJvcHJpYXRlIGluZm9ybWF0aW9uIHBy b3ZpZGVkIGJ5IHRoZSBoYXJkd2FyZSBndXlzLgo+IAo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFBhdWxvIFphbm9u aSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9mYmMuYyB8IDU4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDU0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMKPiBpbmRleCAxYjJlYmIyLi5kNTNmNzNmIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMKPiBAQCAtNjk4LDkgKzY5OCw2MCBAQCB2b2lkIGlu dGVsX2ZiY19jbGVhbnVwX2NmYihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g IAltdXRleF91bmxvY2soJmRldl9wcml2LT5mYmMubG9jayk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBp bnQgaW50ZWxfZmJjX3NldHVwX2NmYihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs IGludCBzaXplLAo+IC0JCQkgICAgICAgaW50IGZiX2NwcCkKPiArLyoKPiArICogRm9yIFNLTCss IHRoZSBwbGFuZSBzb3VyY2Ugc2l6ZSB1c2VkIGJ5IHRoZSBoYXJkd2FyZSBpcyBiYXNlZCBvbiB0 aGUgdmFsdWUgd2UKPiArICogd3JpdGUgdG8gdGhlIFBJUEVfU0laRSByZWdpc3Rlci4gRm9yIEJE Vy0sIHRoZSBoYXJkd2FyZSBsb29rcyBhdCB0aGUgdmFsdWUgd2UKPiArICogd3JvdGUgdG8gUElQ RVNSQy4KPiArICovCj4gK3N0YXRpYyB2b2lkIGludGVsX2ZiY19nZXRfcGxhbmVfc291cmNlX3Np emVzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICsJCQkJCSAgICAgaW50ICp3aWR0aCwgaW50 ICpoZWlnaHQpCgpzaXplIGluIG15IG1pbmQgYWxyZWFkeSBpbmNsdWRlcyB3aWR0aCBhbmQgaGVp Z2h0LCBzbyBwbHVyYWwgX3NpemVzCmRvZXNuJ3QgbWFrZSBtdWNoIHNlbnNlIHRvIG1lLgoKPiAg ewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gY3J0Yy0+YmFzZS5kZXYt PmRldl9wcml2YXRlOwo+ICsJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSA9 Cj4gKwkJCXRvX2ludGVsX3BsYW5lX3N0YXRlKGNydGMtPmJhc2UucHJpbWFyeS0+c3RhdGUpOwo+ ICsJaW50IHcsIGg7Cj4gKwo+ICsJaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5nZW4gPj0gOSkg ewo+ICsJCWlmIChpbnRlbF9yb3RhdGlvbl85MF9vcl8yNzAocGxhbmVfc3RhdGUtPmJhc2Uucm90 YXRpb24pKSB7Cj4gKwkJCXcgPSBkcm1fcmVjdF9oZWlnaHQoJnBsYW5lX3N0YXRlLT5zcmMpID4+ IDE2Owo+ICsJCQloID0gZHJtX3JlY3Rfd2lkdGgoJnBsYW5lX3N0YXRlLT5zcmMpID4+IDE2Owo+ ICsJCX0gZWxzZSB7Cj4gKwkJCXcgPSBkcm1fcmVjdF93aWR0aCgmcGxhbmVfc3RhdGUtPnNyYykg Pj4gMTY7Cj4gKwkJCWggPSBkcm1fcmVjdF9oZWlnaHQoJnBsYW5lX3N0YXRlLT5zcmMpID4+IDE2 Owo+ICsJCX0KCllvdSBjYW4ganVzdCB1c2UgdGhpcyBzYW1lIGNvZGUgZm9yIGFsbCBwbGF0Zm9y bXMuCgpBY3R1YWxseSBJJ20gbm90IHN1cmUgd2hhdCB3ZSBzaG91bGQgZG8gd3J0LiByb3RhdGlv bi4gRG8gd2Ugc3VwcG9ydApGQkMgd2l0aCA5MC8yNzAgZGVncmVlIHJvdGF0aW9uPyBUaGUgc2Nh bm91dCBoYXBwZW5zIGluIGEgcm90YXRlZApmYXNoaW9uLCBzbyBzd2FwcGluZyB0aGUgZGltZW5z aW9ucyBsaWtlIHlvdSBkbyB3b3VsZCBzZWVtIGxpa2UgdGhlCnJpZ2h0IHRoaW5nLiBCdXQgbm90 IHN1cmUuCgo+ICsJfSBlbHNlIHsKPiArCQl3ID0gY3J0Yy0+Y29uZmlnLT5waXBlX3NyY193Owo+ ICsJCWggPSBjcnRjLT5jb25maWctPnBpcGVfc3JjX2g7Cj4gKwl9Cj4gKwo+ICsJaWYgKHdpZHRo KQo+ICsJCSp3aWR0aCA9IHc7Cj4gKwlpZiAoaGVpZ2h0KQo+ICsJCSpoZWlnaHQgPSBoOwo+ICt9 Cj4gKwo+ICtzdGF0aWMgaW50IGludGVsX2ZiY19jYWxjdWxhdGVfY2ZiX3NpemUoc3RydWN0IGlu dGVsX2NydGMgKmNydGMpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IGNydGMtPmJhc2UuZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVjdCBkcm1fZnJhbWVidWZm ZXIgKmZiID0gY3J0Yy0+YmFzZS5wcmltYXJ5LT5mYjsKPiArCWludCBsaW5lczsKPiArCj4gKwlp bnRlbF9mYmNfZ2V0X3BsYW5lX3NvdXJjZV9zaXplcyhjcnRjLCBOVUxMLCAmbGluZXMpOwo+ICsJ aWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5nZW4gPj0gNykKPiArCQlsaW5lcyA9IG1pbihsaW5l cywgMjA0OCk7Cj4gKwo+ICsJcmV0dXJuIGxpbmVzICogZmItPnBpdGNoZXNbMF07Cj4gK30KPiAr Cj4gK3N0YXRpYyBpbnQgaW50ZWxfZmJjX3NldHVwX2NmYihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 YykKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gY3J0Yy0+YmFz ZS5kZXYtPmRldl9wcml2YXRlOwo+ICsJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBjcnRj LT5iYXNlLnByaW1hcnktPmZiOwo+ICsJaW50IHNpemUsIGZiX2NwcDsKPiArCj4gKwlzaXplID0g aW50ZWxfZmJjX2NhbGN1bGF0ZV9jZmJfc2l6ZShjcnRjKTsKPiArCWZiX2NwcCA9IGRybV9mb3Jt YXRfcGxhbmVfY3BwKGZiLT5waXhlbF9mb3JtYXQsIDApOwoKQ2FuIHdlIGp1c3QgYWxsIGl0ICdj cHAnIHBsZWFzZS4gV2UgYWxyZWFkeSBoYXZlIHRvbyBtYW55IG5hbWVzIGZvciB0aGUKc2FtZSB0 aGluZy4gU29tZW9uZSBjb3VsZCBhbHNvIGRvIGEgc21hbGwgc2VhcmNoJnJlcGxhY2UgdG8gdW5p ZnkgdGhlCndoYXRldmVyIHdlIGhhdmUgY3VycmVudGx5LgoKPiArCj4gIAlpZiAoc2l6ZSA8PSBk ZXZfcHJpdi0+ZmJjLnVuY29tcHJlc3NlZF9zaXplKQo+ICAJCXJldHVybiAwOwo+ICAKPiBAQCAt ODk3LDggKzk0OCw3IEBAIHN0YXRpYyB2b2lkIF9faW50ZWxfZmJjX3VwZGF0ZShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJZ290byBvdXRfZGlzYWJsZTsKPiAgCX0KPiAg Cj4gLQlpZiAoaW50ZWxfZmJjX3NldHVwX2NmYihkZXZfcHJpdiwgb2JqLT5iYXNlLnNpemUsCj4g LQkJCQlkcm1fZm9ybWF0X3BsYW5lX2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAwKSkpIHsKPiArCWlm IChpbnRlbF9mYmNfc2V0dXBfY2ZiKGludGVsX2NydGMpKSB7Cj4gIAkJc2V0X25vX2ZiY19yZWFz b24oZGV2X3ByaXYsIEZCQ19TVE9MRU5fVE9PX1NNQUxMKTsKPiAgCQlnb3RvIG91dF9kaXNhYmxl Owo+ICAJfQo+IC0tIAo+IDIuNS4zCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=