From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm/i915: fix FBC buffer size checks Date: Thu, 1 Oct 2015 15:22:10 +0300 Message-ID: <20151001122210.GF26517@intel.com> References: <1443023547-19896-1-git-send-email-paulo.r.zanoni@intel.com> <1443643545-3603-1-git-send-email-paulo.r.zanoni@intel.com> <1443643545-3603-3-git-send-email-paulo.r.zanoni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F4FA6E16C for ; Thu, 1 Oct 2015 05:22:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1443643545-3603-3-git-send-email-paulo.r.zanoni@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMzAsIDIwMTUgYXQgMDU6MDU6NDVQTSAtMDMwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IEFjY29yZGluZyB0byBteSBleHBlcmltZW50cyAoYW5kIGxhdGVyIGNvbmZpcm1hdGlv biBmcm9tIHRoZSBoYXJkd2FyZQo+IGRldmVsb3BlcnMpLCB0aGUgbWF4aW11bSBzaXplcyBtZW50 aW9uZWQgaW4gdGhlIHNwZWNpZmljYXRpb24gZGVsaW1pdAo+IGhvdyBmYXIgaW4gdGhlIGJ1ZmZl ciB0aGUgaGFyZHdhcmUgdHJhY2tpbmcgY2FuIGdvLiBBbmQgdGhlIGhhcmR3YXJlCj4gY2FsY3Vs YXRlcyB0aGUgc2l6ZSBiYXNlZCBvbiB0aGUgcGxhbmUgYWRkcmVzcyB3ZSBwcm92aWRlIC0gYW5k IHRoZQo+IHByb3ZpZGVkIHBsYW5lIGFkZHJlc3MgbWlnaHQgbm90IGJlIHRoZSByZWFsIHg6MCx5 OjAgcG9pbnQgZHVlIHRvIHRoZQo+IGNvbXB1dGVfcGFnZV9vZmZzZXQoKSBmdW5jdGlvbi4KPiAK PiBPbiBwbGF0Zm9ybXMgdGhhdCBkbyB0aGUgeC95IG9mZnNldCBhZGp1c3RtZW50IHRyaWNrIGl0 IHdpbGwgYmUgcmVhbGx5Cj4gaGFyZCB0byByZXByb2R1Y2UgYSBidWcsIGJ1dCBvbiB0aGUgY3Vy cmVudCBTS0wgd2UgY2FuIHJlcHJvZHVjZSB0aGUKPiBidWcgd2l0aCBpZ3Qva21zX2Zyb250YnVm ZmVyX3RyYWNraW5nL2ZiYy1mYXJmcm9tZmVuY2UuIFdpdGggdGhpcwo+IHBhdGNoLCB3ZSdsbCBn byBmcm9tICJDUkMgYXNzZXJ0aW9uIGZhaWx1cmUiIHRvICJGQkMgdW5leHBlY3RlZGx5Cj4gZGlz YWJsZWQiLCB3aGljaCBpcyBzdGlsbCBhIGZhaWx1cmUgb24gdGhlIHRlc3Qgc3VpdGUgYnV0IGlz IG5vdCBhCj4gcGVyY2VpdmVkIHVzZXIgYnVnIC0geW91IHdpbGwganVzdCBub3Qgc2F2ZSBhcyBt dWNoIHBvd2VyIGFzIHlvdSBjb3VsZAo+IGlmIEZCQyBpcyBkaXNhYmxlZC4KPiAKPiB2MiwgcmV3 cml0ZSBwYXRjaCBhZnRlciBjbGFyaWZpY2F0aW9uIGZyb20gdGhlIEhhZHdhcmUgZ3V5czoKPiAg IC0gUmVuYW1lIGZ1bmN0aW9uIHNvIGl0J3MgY2xlYXIgd2hhdCB0aGUgY2hlY2sgaXMgZm9yLgo+ ICAgLSBVc2UgdGhlIG5ldyBpbnRlbF9mYmNfZ2V0X3BsYW5lX3NvdXJjZV9zaXplcygpIGZ1bmN0 aW9uIGluIG9yZGVyCj4gICAgIHRvIGdldCB0aGUgcHJvcGVyIHNpemVzIGFzIHNlZW4gYnkgRkJD Lgo+IAo+IFRlc3RjYXNlOiBpZ3Qva21zX2Zyb250YnVmZmVyX3RyYWNraW5nL2ZiYy1mYXJmcm9t ZmVuY2UgKFNLTCkKPiBTaWduZWQtb2ZmLWJ5OiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25p QGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMgfCAx OSArKysrKysrKysrKysrKy0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCsp LCA1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9mYmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jCj4gaW5kZXggZDUz ZjczZi4uMzEzZWY5MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9m YmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jCj4gQEAgLTgwNSwx MCArODA1LDE2IEBAIHN0YXRpYyBib29sIHBpeGVsX2Zvcm1hdF9pc192YWxpZChzdHJ1Y3QgZHJt X2ZyYW1lYnVmZmVyICpmYikKPiAgCX0KPiAgfQo+ICAKPiAtc3RhdGljIGJvb2wgcGlwZV9zaXpl X2lzX3ZhbGlkKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICsvKgo+ICsgKiBGb3Igc29tZSBy ZWFzb24sIHRoZSBoYXJkd2FyZSB0cmFja2luZyBzdGFydHMgbG9va2luZyBhdCB3aGF0ZXZlciB3 ZQo+ICsgKiBwcm9ncmFtbWVkIGFzIHRoZSBkaXNwbGF5IHBsYW5lIGJhc2UgYWRkcmVzcyByZWdp c3Rlci4gSXQgZG9lcyBub3QgbG9vayBhdAo+ICsgKiB0aGUgWCBhbmQgWSBvZmZzZXQgcmVnaXN0 ZXJzLiBUaGF0J3Mgd2h5IHdlIGxvb2sgYXQgdGhlIGNydGMtPmFkanVzdGVke3gseX0KPiArICog dmFyaWFibGVzIGluc3RlYWQgb2YganVzdCBsb29raW5nIGF0IHRoZSBwaXBlIHNpemUuCgoicGxh bmUgc2l6ZSIgb3Igc29tZXRoaW5nCgo+ICsgKi8KPiArc3RhdGljIGJvb2wgaW50ZWxfZmJjX2h3 X3RyYWNraW5nX2NvdmVyc19zY3JlZW4oc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIHsKPiAg CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGNydGMtPmJhc2UuZGV2LT5kZXZf cHJpdmF0ZTsKPiAtCXVuc2lnbmVkIGludCBtYXhfdywgbWF4X2g7Cj4gKwl1bnNpZ25lZCBpbnQg dXNlZF93LCB1c2VkX2gsIG1heF93LCBtYXhfaDsKPiAgCj4gIAlpZiAoSU5URUxfSU5GTyhkZXZf cHJpdiktPmdlbiA+PSA4IHx8IElTX0hBU1dFTEwoZGV2X3ByaXYpKSB7Cj4gIAkJbWF4X3cgPSA0 MDk2Owo+IEBAIC04MjEsOCArODI3LDExIEBAIHN0YXRpYyBib29sIHBpcGVfc2l6ZV9pc192YWxp ZChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCQltYXhfaCA9IDE1MzY7Cj4gIAl9Cj4gIAo+ IC0JcmV0dXJuIGNydGMtPmNvbmZpZy0+cGlwZV9zcmNfdyA8PSBtYXhfdyAmJgo+IC0JICAgICAg IGNydGMtPmNvbmZpZy0+cGlwZV9zcmNfaCA8PSBtYXhfaDsKPiArCWludGVsX2ZiY19nZXRfcGxh bmVfc291cmNlX3NpemVzKGNydGMsICZ1c2VkX3csICZ1c2VkX2gpOwo+ICsJdXNlZF93ICs9IGNy dGMtPmFkanVzdGVkX3g7Cj4gKwl1c2VkX2ggKz0gY3J0Yy0+YWRqdXN0ZWRfeTsKPiArCj4gKwly ZXR1cm4gdXNlZF93IDw9IG1heF93ICYmIHVzZWRfaCA8PSBtYXhfaDsKCk1ha2VzIHNlbnNlLiBO b3Qgc3VyZSB1c2VkXyBpcyB0aGUgYmVzdCBwcmVmaXguIE1heWJlIGVmZmVjdGl2ZV8gPyBCdXQg SQpkb24ndCBtaW5kIGlmIHlvdSB0aGluayB1c2VkXyBpcyBiZXR0ZXIuCgpTbyB3aXRoIHRoZSBj b21tZW50IGZpeGVkIGEgYml0IHRoaXMgaXMKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpZb3Uga25vdywgd2UgY291bGQgYXZvaWQg dGhlc2UgaXNzdWVzIGlmIHdlIHN0b3BwZWQgdXNpbmcgaHcgZ3R0CnRyYWNraW5nIHRvby4gQW5k IHRoZW4gd2UgY291bGQgdXNlIEZCQyB3aXRob3V0IGEgZmVuY2UsIGFuZCBoZW5jZQp3b3VsZG4n dCBuZWVkIFgtdGlsaW5nLiBJSVJDIHRoYXQncyBub3cgYWxsb3dlZCBvbiBTS0wrLgoKPiAgfQo+ ICAKPiAgLyoqCj4gQEAgLTg5OSw3ICs5MDgsNyBAQCBzdGF0aWMgdm9pZCBfX2ludGVsX2ZiY191 cGRhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCWdvdG8gb3V0X2Rp c2FibGU7Cj4gIAl9Cj4gIAo+IC0JaWYgKCFwaXBlX3NpemVfaXNfdmFsaWQoaW50ZWxfY3J0Yykp IHsKPiArCWlmICghaW50ZWxfZmJjX2h3X3RyYWNraW5nX2NvdmVyc19zY3JlZW4oaW50ZWxfY3J0 YykpIHsKPiAgCQlzZXRfbm9fZmJjX3JlYXNvbihkZXZfcHJpdiwgRkJDX01PREVfVE9PX0xBUkdF KTsKPiAgCQlnb3RvIG91dF9kaXNhYmxlOwo+ICAJfQo+IC0tIAo+IDIuNS4zCj4gCj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFp bGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBT eXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==