From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: prevent out of range pt in the PDE macros (take 3) Date: Fri, 2 Oct 2015 09:58:05 +0200 Message-ID: <20151002075805.GD3383@phenom.ffwll.local> References: <1443715175-32567-1-git-send-email-michel.thierry@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 463676E5C8 for ; Fri, 2 Oct 2015 00:55:11 -0700 (PDT) Received: by wicfx3 with SMTP id fx3so22008013wic.1 for ; Fri, 02 Oct 2015 00:55:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1443715175-32567-1-git-send-email-michel.thierry@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMDEsIDIwMTUgYXQgMDQ6NTk6MzVQTSArMDEwMCwgTWljaGVsIFRoaWVycnkg d3JvdGU6Cj4gV2UgdHJpZWQgdG8gZml4IHRoaXMgaW4gY29tbWl0IGZkYzQ1NGMxNDg0YSAoImRy bS9pOTE1OiBQcmV2ZW50IG91dCBvZgo+IHJhbmdlIHB0IGluIGdlbjZfZm9yX2VhY2hfcGRlIiku Cj4gCj4gQnV0IHRoZSBzdGF0aWMgYW5hbHl6ZXIgc3RpbGwgY29tcGxhaW5zIHRoYXQsIGp1c3Qg YmVmb3JlIHdlIGJyZWFrIGR1ZQo+IHRvICJpdGVyIDwgSTkxNV9QREVTIiwgd2UgZG8gInB0ID0g KHBkKS0+cGFnZV90YWJsZVtpdGVyXSIgd2l0aCBhbgo+IGl0ZXIgdmFsdWUgdGhhdCBpcyBiaWdn ZXIgdGhhbiBJOTE1X1BERVMuIE9mIGNvdXJzZSwgdGhpcyBpc24ndCByZWFsbHkKPiBhIHByb2Js ZW0gc2luY2Ugbm8gb25lIHVzZXMgcHQgb3V0c2lkZSB0aGUgbWFjcm8uIFN0aWxsLCBldmVyeSBz aW5nbGUKPiBuZXcgdXNhZ2Ugb2YgdGhlIG1hY3JvIHdpbGwgY3JlYXRlIGEgbmV3IGlzc3VlIGZv ciB1cyB0byBtYXJrIGFzIGEKPiBmYWxzZSBwb3NpdGl2ZS4KPiAKPiBBbHNvLCBQYXVsbyByZS1z dGFydGVkIHRoZSBkaXNjdXNzaW9uIGEgd2hpbGUgYWdvIFsxXSwgYnV0IGRpZG4ndCBlbmQgdXAK PiBpbXBsZW1lbnRlZC4KPiAKPiBJbiBvcmRlciB0byAic29sdmUiIHRoaXMgInByb2JsZW0iLCB0 aGlzIHBhdGNoIHRha2VzIHRoZSBpZGVhcyBmcm9tCj4gQ2hyaXMgYW5kIERhdmUsIGJ1dCB0aGF0 IGNoZWNrIHdvdWxkIGNoYW5nZSB0aGUgZGVzaXJlZCBiZWhhdmlvciBvZiB0aGUKPiBjb2RlLCBi ZWNhdXNlIHRoZSBvYmplY3QgKGZvciBleGFtcGxlIHBkcC0+cGFnZV9kaXJlY3RvcnlbaXRlcl0p IGNhbiBiZQo+IG51bGwgZHVyaW5nIGluaXQvYWxsb2MsIGFuZCBDIHdvdWxkIHRha2UgdGhpcyBh cyBmYWxzZSwgYnJlYWtpbmcgdGhlIGZvcgo+IGxvb3AgaW1tZWRpYXRlbHkuCj4gCj4gVGhpcyBo YXMgYmVlbiBhbHJlYWR5IHZlcmlmaWVkIHdpdGggInN0YXRpYyBhbmFseXNpcyB0b29scyIuCj4g Cj4gWzFdaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9pbnRlbC1nZngvMjAx NS1KdW5lLzA2ODU0OC5odG1sCj4gCj4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlA aW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4K PiBDYzogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPiBTaWduZWQtb2Zm LWJ5OiBNaWNoZWwgVGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgoKU28gbWF5YmUg SSdtIGRlbnNlIGFuZCBub3Qgc2VlaW5nIHdoYXQncyByZWFsbHkgZ29pbmcgb24sIGJ1dCB0aGUg b25seQp0aGluZyB3ZSBzZWVtIHRvIGJlIGRvaW5nIGlzIGNyZWF0ZSBhIHBvaW50ZXIgdG8gYXJy W1NJWkVdLCBpLmUuIGEgcG9pbnRlcgp0byB0aGUgZWxlbWVudCByaWdodCBhZnRlciB0aGUgbGFz dCB2YWxpZCBvbmUuIFBvaW50ZXIgYXJpdGhtZXRpYyBhbmQKY29tcGFyaXNvbiBhcmUgZXhwbGlj aXRseSBhbGxvd2VkIGJ5IHRoZSBDIHN0YW5kYXJkIG9uIHN1Y2ggYSBwb2ludGVyLiBUaGUKb25s eSB0aGluZyBub3QgYWxsb3dlZCBpcyBkZXJlZmVyZW5jZSBpdCAod2hpY2ggd2UgZG9uJ3Qgc2Vl bSB0byBiZSBkb2luZwpoZXJlKS4KClRoZSByZWFzb24gZm9yIHRoaXMgaXMgZXhhY3RseSB0aGlz IGNhc2UgaGVyZSwgbm90IGFsbG93aW5nIHRoaXMgbWVhbnMKY2hlY2tpbmcgd2hldGhlciB5b3Un dmUgcnVuIG9mZiB0aGUgZW5kIG9mIGFuIGFycmF5IG9mdGVuIGJlY29tZXMgdmVyeQp1bm5hdHVy YWwuCgpTbyBpZiB0aGVyZSdzIG5vdGhpbmcgZWxzZSBnb2luZyBvbiBJIHRoaW5rIHRoZSByaWdo dCBjaG9pY2UgaXMgdG8gbWFyawp0aGVtIGFsbCB1cCBhcyBmYWxzZSBwb3NpdGl2ZXMgLSB0aGUg dG9vbCBpcyB3cm9uZy4KLURhbmllbAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW1fZ3R0LmggfCAxNCArKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9n dHQuaAo+IGluZGV4IDlmYmIwN2QuLjk0ZjgzNDQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ndHQuaAo+IEBAIC0zOTQsNyArMzk0LDkgQEAgc3RydWN0IGk5MTVfaHdfcHBndHQgewo+ ICAgKi8KPiAgI2RlZmluZSBnZW42X2Zvcl9lYWNoX3BkZShwdCwgcGQsIHN0YXJ0LCBsZW5ndGgs IHRlbXAsIGl0ZXIpIFwKPiAgCWZvciAoaXRlciA9IGdlbjZfcGRlX2luZGV4KHN0YXJ0KTsgXAo+ IC0JICAgICBwdCA9IChwZCktPnBhZ2VfdGFibGVbaXRlcl0sIGxlbmd0aCA+IDAgJiYgaXRlciA8 IEk5MTVfUERFUzsgXAo+ICsJICAgICBwdCA9IChsZW5ndGggPiAwICYmIGl0ZXIgPCBJOTE1X1BE RVMpID8gXAo+ICsJCQkocGQpLT5wYWdlX3RhYmxlW2l0ZXJdIDogTlVMTCwgXAo+ICsJICAgICBs ZW5ndGggPiAwICYmIGl0ZXIgPCBJOTE1X1BERVM7IFwKPiAgCSAgICAgaXRlcisrLCBcCj4gIAkg ICAgIHRlbXAgPSBBTElHTihzdGFydCsxLCAxIDw8IEdFTjZfUERFX1NISUZUKSAtIHN0YXJ0LCBc Cj4gIAkgICAgIHRlbXAgPSBtaW5fdCh1bnNpZ25lZCwgdGVtcCwgbGVuZ3RoKSwgXAo+IEBAIC00 NTksNyArNDYxLDkgQEAgc3RhdGljIGlubGluZSB1aW50MzJfdCBnZW42X3BkZV9pbmRleCh1aW50 MzJfdCBhZGRyKQo+ICAgKi8KPiAgI2RlZmluZSBnZW44X2Zvcl9lYWNoX3BkZShwdCwgcGQsIHN0 YXJ0LCBsZW5ndGgsIHRlbXAsIGl0ZXIpCQlcCj4gIAlmb3IgKGl0ZXIgPSBnZW44X3BkZV9pbmRl eChzdGFydCk7IFwKPiAtCSAgICAgcHQgPSAocGQpLT5wYWdlX3RhYmxlW2l0ZXJdLCBsZW5ndGgg PiAwICYmIGl0ZXIgPCBJOTE1X1BERVM7CVwKPiArCSAgICAgcHQgPSAobGVuZ3RoID4gMCAmJiBp dGVyIDwgSTkxNV9QREVTKSA/IFwKPiArCQkJKHBkKS0+cGFnZV90YWJsZVtpdGVyXSA6IE5VTEws IFwKPiArCSAgICAgbGVuZ3RoID4gMCAmJiBpdGVyIDwgSTkxNV9QREVTOwlcCj4gIAkgICAgIGl0 ZXIrKywJCQkJXAo+ICAJICAgICB0ZW1wID0gQUxJR04oc3RhcnQrMSwgMSA8PCBHRU44X1BERV9T SElGVCkgLSBzdGFydCwJXAo+ICAJICAgICB0ZW1wID0gbWluKHRlbXAsIGxlbmd0aCksCQkJCQlc Cj4gQEAgLTQ2Nyw3ICs0NzEsOCBAQCBzdGF0aWMgaW5saW5lIHVpbnQzMl90IGdlbjZfcGRlX2lu ZGV4KHVpbnQzMl90IGFkZHIpCj4gIAo+ICAjZGVmaW5lIGdlbjhfZm9yX2VhY2hfcGRwZShwZCwg cGRwLCBzdGFydCwgbGVuZ3RoLCB0ZW1wLCBpdGVyKQlcCj4gIAlmb3IgKGl0ZXIgPSBnZW44X3Bk cGVfaW5kZXgoc3RhcnQpOyBcCj4gLQkgICAgIHBkID0gKHBkcCktPnBhZ2VfZGlyZWN0b3J5W2l0 ZXJdLCBcCj4gKwkgICAgIHBkID0gKGxlbmd0aCA+IDAgJiYgKGl0ZXIgPCBJOTE1X1BEUEVTX1BF Ul9QRFAoZGV2KSkpID8gXAo+ICsJCQkocGRwKS0+cGFnZV9kaXJlY3RvcnlbaXRlcl0gOiBOVUxM LCBcCj4gIAkgICAgIGxlbmd0aCA+IDAgJiYgKGl0ZXIgPCBJOTE1X1BEUEVTX1BFUl9QRFAoZGV2 KSk7IFwKPiAgCSAgICAgaXRlcisrLAkJCQlcCj4gIAkgICAgIHRlbXAgPSBBTElHTihzdGFydCsx LCAxIDw8IEdFTjhfUERQRV9TSElGVCkgLSBzdGFydCwJXAo+IEBAIC00NzYsNyArNDgxLDggQEAg c3RhdGljIGlubGluZSB1aW50MzJfdCBnZW42X3BkZV9pbmRleCh1aW50MzJfdCBhZGRyKQo+ICAK PiAgI2RlZmluZSBnZW44X2Zvcl9lYWNoX3BtbDRlKHBkcCwgcG1sNCwgc3RhcnQsIGxlbmd0aCwg dGVtcCwgaXRlcikJXAo+ICAJZm9yIChpdGVyID0gZ2VuOF9wbWw0ZV9pbmRleChzdGFydCk7CVwK PiAtCSAgICAgcGRwID0gKHBtbDQpLT5wZHBzW2l0ZXJdLCBcCj4gKwkgICAgIHBkcCA9IChsZW5n dGggPiAwICYmIGl0ZXIgPCBHRU44X1BNTDRFU19QRVJfUE1MNCkgPyBcCj4gKwkJCShwbWw0KS0+ cGRwc1tpdGVyXSA6IE5VTEwsIFwKPiAgCSAgICAgbGVuZ3RoID4gMCAmJiBpdGVyIDwgR0VOOF9Q TUw0RVNfUEVSX1BNTDQ7IFwKPiAgCSAgICAgaXRlcisrLAkJCQlcCj4gIAkgICAgIHRlbXAgPSBB TElHTihzdGFydCsxLCAxVUxMIDw8IEdFTjhfUE1MNEVfU0hJRlQpIC0gc3RhcnQsCVwKPiAtLSAK PiAyLjYuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9y YXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK