From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: prevent out of range pt in the PDE macros (take 3) Date: Tue, 6 Oct 2015 10:38:22 +0200 Message-ID: <20151006083822.GU3383@phenom.ffwll.local> References: <1443715175-32567-1-git-send-email-michel.thierry@intel.com> <1443791813-30551-1-git-send-email-michel.thierry@intel.com> <5612A6F4.7030706@intel.com> <5612AC86.3030202@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07DE96EA69 for ; Tue, 6 Oct 2015 01:35:30 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so155635222wic.0 for ; Tue, 06 Oct 2015 01:35:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5612AC86.3030202@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMDUsIDIwMTUgYXQgMDU6NTk6NTBQTSArMDEwMCwgTWljaGVsIFRoaWVycnkg d3JvdGU6Cj4gT24gMTAvNS8yMDE1IDU6MzYgUE0sIERhdmUgR29yZG9uIHdyb3RlOgo+ID5PbiAw Mi8xMC8xNSAxNDoxNiwgTWljaGVsIFRoaWVycnkgd3JvdGU6Cj4gPj5XZSB0cmllZCB0byBmaXgg dGhpcyBpbiBjb21taXQgZmRjNDU0YzE0ODRhICgiZHJtL2k5MTU6IFByZXZlbnQgb3V0IG9mCj4g Pj5yYW5nZSBwdCBpbiBnZW42X2Zvcl9lYWNoX3BkZSIpLgo+ID4+Cj4gPj5CdXQgdGhlIHN0YXRp YyBhbmFseXplciBzdGlsbCBjb21wbGFpbnMgdGhhdCwganVzdCBiZWZvcmUgd2UgYnJlYWsgZHVl Cj4gPj50byAiaXRlciA8IEk5MTVfUERFUyIsIHdlIGRvICJwdCA9IChwZCktPnBhZ2VfdGFibGVb aXRlcl0iIHdpdGggYW4KPiA+Pml0ZXIgdmFsdWUgdGhhdCBpcyBiaWdnZXIgdGhhbiBJOTE1X1BE RVMuIE9mIGNvdXJzZSwgdGhpcyBpc24ndCByZWFsbHkKPiA+PmEgcHJvYmxlbSBzaW5jZSBubyBv bmUgdXNlcyBwdCBvdXRzaWRlIHRoZSBtYWNyby4gU3RpbGwsIGV2ZXJ5IHNpbmdsZQo+ID4+bmV3 IHVzYWdlIG9mIHRoZSBtYWNybyB3aWxsIGNyZWF0ZSBhIG5ldyBpc3N1ZSBmb3IgdXMgdG8gbWFy ayBhcyBhCj4gPj5mYWxzZSBwb3NpdGl2ZS4KPiA+Pgo+ID4+QWxzbywgUGF1bG8gcmUtc3RhcnRl ZCB0aGUgZGlzY3Vzc2lvbiBhIHdoaWxlIGFnbyBbMV0sIGJ1dCBkaWRuJ3QgZW5kIHVwCj4gPj5p bXBsZW1lbnRlZC4KPiA+Pgo+ID4+SW4gb3JkZXIgdG8gInNvbHZlIiB0aGlzICJwcm9ibGVtIiwg dGhpcyBwYXRjaCB0YWtlcyB0aGUgaWRlYXMgZnJvbQo+ID4+Q2hyaXMgYW5kIERhdmUsIGJ1dCB0 aGF0IGNoZWNrIHdvdWxkIGNoYW5nZSB0aGUgZGVzaXJlZCBiZWhhdmlvciBvZiB0aGUKPiA+PmNv ZGUsIGJlY2F1c2UgdGhlIG9iamVjdCAoZm9yIGV4YW1wbGUgcGRwLT5wYWdlX2RpcmVjdG9yeVtp dGVyXSkgY2FuIGJlCj4gPj5udWxsIGR1cmluZyBpbml0L2FsbG9jLCBhbmQgQyB3b3VsZCB0YWtl IHRoaXMgYXMgZmFsc2UsIGJyZWFraW5nIHRoZSBmb3IKPiA+Pmxvb3AgaW1tZWRpYXRlbHkuCj4g Pj4KPiA+PlRoaXMgaGFzIGJlZW4gYWxyZWFkeSB2ZXJpZmllZCB3aXRoICJzdGF0aWMgYW5hbHlz aXMgdG9vbHMiLgo+ID4+Cj4gPj5bMV1odHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hp dmVzL2ludGVsLWdmeC8yMDE1LUp1bmUvMDY4NTQ4Lmh0bWwKPiA+Pgo+ID4+djI6IE1ha2UgaXQg YSBzaW5nbGUgc3RhdGVtZW50LCB3aGlsZSBwcmV2ZW50aW5nIHRoZSBjb21tb24gc3ViZXhwcmVz c2lvbgo+ID4+ZWxpbWluYXRpb24gKENocmlzKQo+ID4+Cj4gPj5DYzogUGF1bG8gWmFub25pIDxw YXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4gPj5DYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+Cj4gPj5DYzogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVs LmNvbT4KPiA+PlNpZ25lZC1vZmYtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBp bnRlbC5jb20+Cj4gPj4tLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0 LmggfCAxNCArKysrKysrKy0tLS0tLQo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25z KCspLCA2IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiA+PmIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f Z3R0LmgKPiA+PmluZGV4IDlmYmIwN2QuLmEyMTYzOTcgMTAwNjQ0Cj4gPj4tLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaAo+ID4+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fZ3R0LmgKPiA+PkBAIC0zOTQsNyArMzk0LDggQEAgc3RydWN0IGk5MTVfaHdf cHBndHQgewo+ID4+ICAgKi8KPiA+PiAgI2RlZmluZSBnZW42X2Zvcl9lYWNoX3BkZShwdCwgcGQs IHN0YXJ0LCBsZW5ndGgsIHRlbXAsIGl0ZXIpIFwKPiA+PiAgICAgIGZvciAoaXRlciA9IGdlbjZf cGRlX2luZGV4KHN0YXJ0KTsgXAo+ID4+LSAgICAgICAgIHB0ID0gKHBkKS0+cGFnZV90YWJsZVtp dGVyXSwgbGVuZ3RoID4gMCAmJiBpdGVyIDwgSTkxNV9QREVTOyBcCj4gPj4rICAgICAgICAgbGVu Z3RoID4gMCAmJiBpdGVyIDwgSTkxNV9QREVTID8gXAo+ID4+KyAgICAgICAgICAgIChwdCA9IChw ZCktPnBhZ2VfdGFibGVbaXRlcl0pLCAxIDogMDsgXAo+ID4+ICAgICAgICAgICBpdGVyKyssIFwK PiA+PiAgICAgICAgICAgdGVtcCA9IEFMSUdOKHN0YXJ0KzEsIDEgPDwgR0VONl9QREVfU0hJRlQp IC0gc3RhcnQsIFwKPiA+PiAgICAgICAgICAgdGVtcCA9IG1pbl90KHVuc2lnbmVkLCB0ZW1wLCBs ZW5ndGgpLCBcCj4gPj5AQCAtNDU5LDcgKzQ2MCw4IEBAIHN0YXRpYyBpbmxpbmUgdWludDMyX3Qg Z2VuNl9wZGVfaW5kZXgodWludDMyX3QgYWRkcikKPiA+PiAgICovCj4gPj4gICNkZWZpbmUgZ2Vu OF9mb3JfZWFjaF9wZGUocHQsIHBkLCBzdGFydCwgbGVuZ3RoLCB0ZW1wLCBpdGVyKSAgICAgICAg XAo+ID4+ICAgICAgZm9yIChpdGVyID0gZ2VuOF9wZGVfaW5kZXgoc3RhcnQpOyBcCj4gPj4tICAg ICAgICAgcHQgPSAocGQpLT5wYWdlX3RhYmxlW2l0ZXJdLCBsZW5ndGggPiAwICYmIGl0ZXIgPAo+ ID4+STkxNV9QREVTOyAgICBcCj4gPj4rICAgICAgICAgbGVuZ3RoID4gMCAmJiBpdGVyIDwgSTkx NV9QREVTID8gXAo+ID4+KyAgICAgICAgICAgIChwdCA9IChwZCktPnBhZ2VfdGFibGVbaXRlcl0p LCAxIDogMDsgXAo+ID4+ICAgICAgICAgICBpdGVyKyssICAgICAgICAgICAgICAgIFwKPiA+PiAg ICAgICAgICAgdGVtcCA9IEFMSUdOKHN0YXJ0KzEsIDEgPDwgR0VOOF9QREVfU0hJRlQpIC0gc3Rh cnQsICAgIFwKPiA+PiAgICAgICAgICAgdGVtcCA9IG1pbih0ZW1wLCBsZW5ndGgpLCAgICAgICAg ICAgICAgICAgICAgXAo+ID4+QEAgLTQ2Nyw4ICs0NjksOCBAQCBzdGF0aWMgaW5saW5lIHVpbnQz Ml90IGdlbjZfcGRlX2luZGV4KHVpbnQzMl90IGFkZHIpCj4gPj4KPiA+PiAgI2RlZmluZSBnZW44 X2Zvcl9lYWNoX3BkcGUocGQsIHBkcCwgc3RhcnQsIGxlbmd0aCwgdGVtcCwgaXRlcikgICAgXAo+ ID4+ICAgICAgZm9yIChpdGVyID0gZ2VuOF9wZHBlX2luZGV4KHN0YXJ0KTsgXAo+ID4+LSAgICAg ICAgIHBkID0gKHBkcCktPnBhZ2VfZGlyZWN0b3J5W2l0ZXJdLCBcCj4gPj4tICAgICAgICAgbGVu Z3RoID4gMCAmJiAoaXRlciA8IEk5MTVfUERQRVNfUEVSX1BEUChkZXYpKTsgXAo+ID4+KyAgICAg ICAgIGxlbmd0aCA+IDAgJiYgKGl0ZXIgPCBJOTE1X1BEUEVTX1BFUl9QRFAoZGV2KSkgPyBcCj4g Pj4rICAgICAgICAgICAgKHBkID0gKHBkcCktPnBhZ2VfZGlyZWN0b3J5W2l0ZXJdKSwgMSA6IDA7 IFwKPiA+PiAgICAgICAgICAgaXRlcisrLCAgICAgICAgICAgICAgICBcCj4gPj4gICAgICAgICAg IHRlbXAgPSBBTElHTihzdGFydCsxLCAxIDw8IEdFTjhfUERQRV9TSElGVCkgLSBzdGFydCwgICAg XAo+ID4+ICAgICAgICAgICB0ZW1wID0gbWluKHRlbXAsIGxlbmd0aCksICAgICAgICAgICAgICAg ICAgICBcCj4gPj5AQCAtNDc2LDggKzQ3OCw4IEBAIHN0YXRpYyBpbmxpbmUgdWludDMyX3QgZ2Vu Nl9wZGVfaW5kZXgodWludDMyX3QgYWRkcikKPiA+Pgo+ID4+ICAjZGVmaW5lIGdlbjhfZm9yX2Vh Y2hfcG1sNGUocGRwLCBwbWw0LCBzdGFydCwgbGVuZ3RoLCB0ZW1wLCBpdGVyKSAgICBcCj4gPj4g ICAgICBmb3IgKGl0ZXIgPSBnZW44X3BtbDRlX2luZGV4KHN0YXJ0KTsgICAgXAo+ID4+LSAgICAg ICAgIHBkcCA9IChwbWw0KS0+cGRwc1tpdGVyXSwgXAo+ID4+LSAgICAgICAgIGxlbmd0aCA+IDAg JiYgaXRlciA8IEdFTjhfUE1MNEVTX1BFUl9QTUw0OyBcCj4gPj4rICAgICAgICAgbGVuZ3RoID4g MCAmJiBpdGVyIDwgR0VOOF9QTUw0RVNfUEVSX1BNTDQgPyBcCj4gPj4rICAgICAgICAgICAgKHBk cCA9IChwbWw0KS0+cGRwc1tpdGVyXSksIDEgOiAwOyBcCj4gPgo+ID50aGlzIHdvbid0IGNvbXBp bGUgLS0gc2VlIGJlbG93Cj4gCj4gSG1tLCBpdCBjb21waWxlZCAoYWxzbyBnb3QgcmlkIG9mIG9m IHRoZSAiYW5hbHlzaXMgdG9vbCBlcnJvciIgYW5kIGRpZG4ndAo+IHNlZSBhbnkgYmVoYXZpb3Ig Y2hhbmdlKS4KPiAKPiA+Cj4gPj4gICAgICAgICAgIGl0ZXIrKywgICAgICAgICAgICAgICAgXAo+ ID4+ICAgICAgICAgICB0ZW1wID0gQUxJR04oc3RhcnQrMSwgMVVMTCA8PCBHRU44X1BNTDRFX1NI SUZUKSAtIHN0YXJ0LCAgICBcCj4gPj4gICAgICAgICAgIHRlbXAgPSBtaW4odGVtcCwgbGVuZ3Ro KSwgICAgICAgICAgICAgICAgICAgIFwKPiA+Cj4gPlRoZSBtYW4gcGFnZSBmb3IgQyBvcGVyYXRv cnMgdGVsbHMgdXM6Cj4gPgo+ID4gICAgICAgIE9wZXJhdG9yICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBBc3NvY2lhdGl2aXR5Cj4gPiAgICAgICAgKCkgW10gLT4gLiAgICAgICAgICAgICAg ICAgICAgICAgICAgIGxlZnQgdG8gcmlnaHQKPiA+ICAgICAgICAhIH4gKysgLS0gKyAtICh0eXBl KSAqICYgc2l6ZW9mICAgICAgcmlnaHQgdG8gbGVmdAo+ID4gICAgICAgICogLyAlICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBsZWZ0IHRvIHJpZ2h0Cj4gPiAgICAgICAgKyAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxlZnQgdG8gcmlnaHQKPiA+ICAgICAgICA8PCA+ PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGVmdCB0byByaWdodAo+ID4gICAgICAg IDwgPD0gPiA+PSAgICAgICAgICAgICAgICAgICAgICAgICAgICBsZWZ0IHRvIHJpZ2h0Cj4gPiAg ICAgICAgPT0gIT0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxlZnQgdG8gcmlnaHQK PiA+ICAgICAgICAmICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGVmdCB0byBy aWdodAo+ID4gICAgICAgIF4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsZWZ0 IHRvIHJpZ2h0Cj4gPiAgICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGxlZnQgdG8gcmlnaHQKPiA+ICAgICAgICAmJiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbGVmdCB0byByaWdodAo+ID4gICAgICAgIHx8ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBsZWZ0IHRvIHJpZ2h0Cj4gPiAgICAgICAgPzogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJpZ2h0IHRvIGxlZnQKPiA+ICAgICAgICA9ICs9IC09ICo9IC89ICU9 IDw8PSA+Pj0gJj0gXj0gfD0gICAgcmlnaHQgdG8gbGVmdAo+ID4gICAgICAgICwgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBsZWZ0IHRvIHJpZ2h0Cj4gPgo+ID5TbyB0aGVyZSdz IGEgcHJvYmxlbSB3aXRoIHRoZSBhYm92ZSBjb2RlLCBiZWNhdXNlIHRoZSBjb21tYSBvcGVyYXRv ciBpcwo+ID5MT1dFUiBwcmVjZWRlbmNlIHRoYW4gZWl0aGVyIGFzc2lnbm1lbnQgb3IgPzogWW91 J2QgbmVlZCB0byBwdXQgdGhlCj4gPnBhcmVudGhlc2VzIGFyb3VuZCB0aGUgKHBkcCA9IC4uLiAs IDEpIHNlY3Rpb24sIG5vdCBqdXN0IHRoZSBhc3NpZ25tZW50Lgo+ID4KPiA+T3IgZm9yIHlldCBh bm90aGVyIHZhcmlhdGlvbiwgaG93IGFib3V0Ogo+ID4KPiA+I2RlZmluZSBnZW44X2Zvcl9lYWNo X3BkcGUocGQsIHBkcCwgc3RhcnQsIGxlbmd0aCwgdGVtcCwgaXRlcikgICAgICAgICBcCj4gPiAg ICAgICAgIGZvciAoaXRlciA9IGdlbjhfcGRwZV9pbmRleChzdGFydCk7ICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFwKPiA+ICAgICAgICAgICAgICBpdGVyIDwgSTkxNV9QRFBFU19QRVJfUERQ KGRldikgJiYgICAgICAgICAgICAgICAgICAgICAgICAgXAo+ID4gICAgICAgICAgICAgICAgIChw ZCA9IChwZHApLT5wYWdlX2RpcmVjdG9yeVtpdGVyXSwgbGVuZ3RoID4gMCk7ICAgICAgICBcCj4g PiAgICAgICAgICAgICAgaXRlcisrLCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFwKPiA+ICAgICAgICAgICAgICB0ZW1wID0gQUxJR04oc3RhcnQrMSwg MSA8PCBHRU44X1BEUEVfU0hJRlQpIC0gc3RhcnQsICAgICAgXAo+ID4gICAgICAgICAgICAgIHRl bXAgPSBtaW4odGVtcCwgbGVuZ3RoKSwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBc Cj4gPiAgICAgICAgICAgICAgc3RhcnQgKz0gdGVtcCwgbGVuZ3RoIC09IHRlbXApCj4gPgo+ID4j ZGVmaW5lIGdlbjhfZm9yX2VhY2hfcG1sNGUocGRwLCBwbWw0LCBzdGFydCwgbGVuZ3RoLCB0ZW1w LCBpdGVyKSAgICAgIFwKPiA+ICAgICAgICAgZm9yIChpdGVyID0gZ2VuOF9wbWw0ZV9pbmRleChz dGFydCk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAo+ID4gICAgICAgICAgICAgIGl0ZXIg PCBHRU44X1BNTDRFU19QRVJfUE1MNCAmJiAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCj4g PiAgICAgICAgICAgICAgICAgKHBkcCA9IChwbWw0KS0+cGRwc1tpdGVyXSwgbGVuZ3RoID4gMCk7 ICAgICAgICAgICAgICAgIFwKPiA+ICAgICAgICAgICAgICBpdGVyKyssICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAo+ID4gICAgICAgICAgICAgIHRl bXAgPSBBTElHTihzdGFydCsxLCAxVUxMIDw8IEdFTjhfUE1MNEVfU0hJRlQpIC0gc3RhcnQsICBc Cj4gPiAgICAgICAgICAgICAgdGVtcCA9IG1pbih0ZW1wLCBsZW5ndGgpLCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIFwKPiA+ICAgICAgICAgICAgICBzdGFydCArPSB0ZW1wLCBsZW5n dGggLT0gdGVtcCkKPiA+Cj4gPndpdGggbm8gdWdseSA/OiBhdCBhbGwgOikKPiAKPiBUaGlzIGFs c28gd29ya3MuCj4gCj4gU2luY2UgaXQncyBhIGNoYW5nZSBmb3Igbm90IGEgcmVhbCBpc3N1ZSwg SSBkb24ndCBoYXZlIGEgcHJlZmVyZW5jZS4KPiBJIGNhbiBzZW5kIGVpdGhlci4KClllYWgsIHNp bmNlID86IGlzIGEgdGVybmFyeSBvcGVyYXRvciBwYXJzaW5nIGltcGxpY2l0bHkgYWRkcyB0aGUg KCkgaW4gdGhlCm1pZGRsZSBhbmQgYWx3YXlzIHBhcnNlcyBpdCBhcyBhID8gKGIpIDogYy4gSWYg bG93ZXItbGV2ZWwgb3BlcmF0b3JzIGluCnRoZSBtaWRkbGUgY291bGQgc3BsaXQgdGhlIHRlcm5h cnkgb3BlcmF0b3IgdGhlbiBpdCB3b3VsZCByZXN1bHQgaW4KcGFyc2luZyBmYWlsIChzaW5jID8g d2l0aG91dCB0aGUgOiBpcyBqdXN0IHVzZWxlc3MpLiBTbyBsZ3RtLiBTb21lb25lCndpbGxpbmcg dG8gc21hY2sgYW4gci1iIG9udG8gdGhlIHBhdGNoPwotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVy ClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5j aApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=