From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, kbuild-all@01.org,
kbuild test robot <fengguang.wu@intel.com>
Subject: Re: [RFC PATCH drm-intel] drm/i915/bxt: vlv_dsi_reset_clocks() can be static
Date: Tue, 6 Oct 2015 10:57:16 +0200 [thread overview]
Message-ID: <20151006085716.GZ3383@phenom.ffwll.local> (raw)
In-Reply-To: <87mvvxa5oa.fsf@intel.com>
On Mon, Oct 05, 2015 at 02:57:57PM +0300, Jani Nikula wrote:
> On Mon, 05 Oct 2015, kbuild test robot <fengguang.wu@intel.com> wrote:
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
>
> > ---
> > intel_dsi_pll.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dsi_pll.c b/drivers/gpu/drm/i915/intel_dsi_pll.c
> > index c9a38f4..d85f1eaf 100644
> > --- a/drivers/gpu/drm/i915/intel_dsi_pll.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi_pll.c
> > @@ -384,7 +384,7 @@ u32 vlv_get_dsi_pclk(struct intel_encoder *encoder, int pipe_bpp)
> > return pclk;
> > }
> >
> > -void vlv_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> > +static void vlv_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> > {
> > u32 temp;
> > struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
> > @@ -542,7 +542,7 @@ void intel_disable_dsi_pll(struct intel_encoder *encoder)
> > bxt_disable_dsi_pll(encoder);
> > }
> >
> > -void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> > +static void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> > {
> > u32 tmp;
> > struct drm_device *dev = encoder->base.dev;
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-10-06 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 8:21 [drm-intel:for-linux-next 809/813] drivers/gpu/drm/i915/intel_dsi_pll.c:387:6: sparse: symbol 'vlv_dsi_reset_clocks' was not declared. Should it be static? kbuild test robot
2015-10-05 8:21 ` [RFC PATCH drm-intel] drm/i915/bxt: vlv_dsi_reset_clocks() can be static kbuild test robot
2015-10-05 11:57 ` Jani Nikula
2015-10-06 8:57 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006085716.GZ3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=fengguang.wu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kbuild-all@01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox