From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Drop i915_gem_obj_is_pinned() from set-cache-level Date: Tue, 6 Oct 2015 13:28:07 +0200 Message-ID: <20151006112807.GK3383@phenom.ffwll.local> References: <1444127996-23561-1-git-send-email-chris@chris-wilson.co.uk> <1444127996-23561-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3CCCC6EA91 for ; Tue, 6 Oct 2015 04:25:15 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so161958137wic.0 for ; Tue, 06 Oct 2015 04:25:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1444127996-23561-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMDYsIDIwMTUgYXQgMTE6Mzk6NTZBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFNpbmNlIHRoZSByZW1vdmUgb2YgdGhlIHBpbi1pb2N0bCwgd2Ugb25seSBjYXJlIGFi b3V0IG5vdCBjaGFuZ2luZyB0aGUKPiBjYWNoZSBsZXZlbCBvbiBidWZmZXJzIHBpbm5lZCB0byB0 aGUgaGFyZHdhcmUgYXMgaW5kaWNhdGVkIGJ5Cj4gb2JqLT5waW5fZGlzcGxheS4gU28gd2UgY2Fu IHNhZmVseSByZXBsYWNlIGk5MTVfZ2VtX29iamVjdF9pc19waW5uZWQoKQo+IGhlcmUgd2l0aCBh IHBsYWluIG9iai0+cGluX2Rpc3BsYXkgY2hlY2suIER1cmluZyByZWJpbmRpbmcsIHdlIHdpbGwg Y2hlY2sKPiBzYW5pdHkgY2hlY2tzIGluIGNhc2Ugdm1hLT5waW5fY291bnQgaXMgZXJyb25lb3Vz bHkgc2V0Lgo+IAo+IEF0IHRoZSBzYW1lIHRpbWUsIHdlIGNhbiBtaWNyby1vcHRpbWlzZSBHVFQg bW1hcCgpIGJlaGF2aW91ciBzaW5jZSB3ZQo+IG9ubHkgbmVlZCB0byByZWxpbnF1aXNoIHRoZSBt bWFwcyBiZWZvcmUgU2FuZHlicmlkZ2UuCgpBY3R1YWwgY29uZGl0aW9uIGlzICFMTEMgc28gd291 bGQgbmVlZCB0byBiZSB1cGRhdGVkIChhbmQgc3BsaXQgb3V0IGltbykuCiAKPiBTaWduZWQtb2Zm LWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDQwICsrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDE2 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IGQ0YTNiZGYw YzViNi4uMmI4ZWQ3YTJmYWFiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTM2 MjksMzEgKzM2MjksMzQgQEAgaW50IGk5MTVfZ2VtX29iamVjdF9zZXRfY2FjaGVfbGV2ZWwoc3Ry dWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2Ug KmRldiA9IG9iai0+YmFzZS5kZXY7Cj4gIAlzdHJ1Y3QgaTkxNV92bWEgKnZtYSwgKm5leHQ7Cj4g Kwlib29sIGJvdW5kID0gZmFsc2U7Cj4gIAlpbnQgcmV0ID0gMDsKPiAgCj4gIAlpZiAob2JqLT5j YWNoZV9sZXZlbCA9PSBjYWNoZV9sZXZlbCkKPiAgCQlnb3RvIG91dDsKPiAgCj4gLQlpZiAoaTkx NV9nZW1fb2JqX2lzX3Bpbm5lZChvYmopKSB7Cj4gLQkJRFJNX0RFQlVHKCJjYW4gbm90IGNoYW5n ZSB0aGUgY2FjaGUgbGV2ZWwgb2YgcGlubmVkIG9iamVjdHNcbiIpOwo+IC0JCXJldHVybiAtRUJV U1k7Cj4gLQl9Cj4gLQo+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHZtYSwgbmV4dCwgJm9i ai0+dm1hX2xpc3QsIHZtYV9saW5rKSB7Cj4gKwkJaWYgKCFkcm1fbW1fbm9kZV9hbGxvY2F0ZWQo JnZtYS0+bm9kZSkpCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiArCQlpZiAodm1hLT5waW5fY291bnQp IHsKPiArCQkJRFJNX0RFQlVHKCJjYW4gbm90IGNoYW5nZSB0aGUgY2FjaGUgbGV2ZWwgb2YgcGlu bmVkIG9iamVjdHNcbiIpOwo+ICsJCQlyZXR1cm4gLUVCVVNZOwo+ICsJCX0KPiArCj4gIAkJaWYg KCFpOTE1X2dlbV92YWxpZF9ndHRfc3BhY2Uodm1hLCBjYWNoZV9sZXZlbCkpIHsKPiAgCQkJcmV0 ID0gaTkxNV92bWFfdW5iaW5kKHZtYSk7Cj4gIAkJCWlmIChyZXQpCj4gIAkJCQlyZXR1cm4gcmV0 Owo+IC0JCX0KPiArCQl9IGVsc2UKPiArCQkJYm91bmQgPSB0cnVlOwo+ICAJfQo+ICAKPiAtCWlm IChpOTE1X2dlbV9vYmpfYm91bmRfYW55KG9iaikpIHsKPiArCWlmIChib3VuZCkgewo+ICAJCXJl dCA9IGk5MTVfZ2VtX29iamVjdF93YWl0X3JlbmRlcmluZyhvYmosIGZhbHNlKTsKPiAgCQlpZiAo cmV0KQo+ICAJCQlyZXR1cm4gcmV0OwoKU2hvdWxkbid0IHRoZSBiZWxvdyBiZSBzcGxpdCBvdXQg aW50byBhIHNlcGFyYXRlIHBhdGNoPyBBbmQgbWF5YmUgZm9yCnBhcmFub2lhIGtlZXAgY2FsbGlu ZyBmaW5pc2hfZ3R0IGJ1dCByZXN0cmljdCBpdCB0byAhTExDICYmIHNub29wZWQgbGlrZQp5b3Ug ZG8gYmVsb3cuCi1EYW5pZWwKCj4gIAo+IC0JCWk5MTVfZ2VtX29iamVjdF9maW5pc2hfZ3R0KG9i aik7Cj4gLQo+ICAJCS8qIEJlZm9yZSBTYW5keUJyaWRnZSwgeW91IGNvdWxkIG5vdCB1c2UgdGls aW5nIG9yIGZlbmNlCj4gIAkJICogcmVnaXN0ZXJzIHdpdGggc25vb3BlZCBtZW1vcnksIHNvIHJl bGlucXVpc2ggYW55IGZlbmNlcwo+ICAJCSAqIGN1cnJlbnRseSBwb2ludGluZyB0byBvdXIgcmVn aW9uIGluIHRoZSBhcGVydHVyZS4KPiBAQCAtMzY2NCwxMyArMzY2NywxOCBAQCBpbnQgaTkxNV9n ZW1fb2JqZWN0X3NldF9jYWNoZV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2Jq LAo+ICAJCQkJcmV0dXJuIHJldDsKPiAgCQl9Cj4gIAo+IC0JCWxpc3RfZm9yX2VhY2hfZW50cnko dm1hLCAmb2JqLT52bWFfbGlzdCwgdm1hX2xpbmspCj4gLQkJCWlmIChkcm1fbW1fbm9kZV9hbGxv Y2F0ZWQoJnZtYS0+bm9kZSkpIHsKPiAtCQkJCXJldCA9IGk5MTVfdm1hX2JpbmQodm1hLCBjYWNo ZV9sZXZlbCwKPiAtCQkJCQkJICAgIFBJTl9VUERBVEUpOwo+IC0JCQkJaWYgKHJldCkKPiAtCQkJ CQlyZXR1cm4gcmV0Owo+IC0JCQl9Cj4gKwkJLyogQWNjZXNzIHRvIHNub29wYWJsZSBwYWdlcyB0 aHJvdWdoIHRoZSBHVFQgaXMgaW5jb2hlcmVudC4gKi8KPiArCQlpZiAoY2FjaGVfbGV2ZWwgIT0g STkxNV9DQUNIRV9OT05FICYmICFIQVNfTExDKGRldikpCj4gKwkJCWk5MTVfZ2VtX3JlbGVhc2Vf bW1hcChvYmopOwo+ICsKPiArCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHZtYSwgJm9iai0+dm1hX2xp c3QsIHZtYV9saW5rKSB7Cj4gKwkJCWlmICghZHJtX21tX25vZGVfYWxsb2NhdGVkKCZ2bWEtPm5v ZGUpKQo+ICsJCQkJY29udGludWU7Cj4gKwo+ICsJCQlyZXQgPSBpOTE1X3ZtYV9iaW5kKHZtYSwg Y2FjaGVfbGV2ZWwsIFBJTl9VUERBVEUpOwo+ICsJCQlpZiAocmV0KQo+ICsJCQkJcmV0dXJuIHJl dDsKPiArCQl9Cj4gIAl9Cj4gIAo+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEsICZvYmotPnZt YV9saXN0LCB2bWFfbGluaykKPiAtLSAKPiAyLjYuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK