From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm: Check fb against plane size rather
 than CRTC mode for pageflip
Date: Wed, 7 Oct 2015 15:02:53 +0300
Message-ID: <20151007120253.GF26517@intel.com>
References: <1444176167-28319-1-git-send-email-matthew.d.roper@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 409706E0E3
 for <intel-gfx@lists.freedesktop.org>; Wed,  7 Oct 2015 05:02:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1444176167-28319-1-git-send-email-matthew.d.roper@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBPY3QgMDYsIDIwMTUgYXQgMDU6MDI6NDdQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90
ZToKPiBUaGUgbGVnYWN5IHBhZ2VmbGlwIGlvY3RsIGNhbGxzIGRybV9jcnRjX2NoZWNrX3ZpZXdw
b3J0KCkgdG8gZGV0ZXJtaW5lCj4gd2hldGhlciB0aGUgZnJhbWVidWZmZXIgYmVpbmcgZmxpcHBl
ZCBpcyBiaWcgZW5vdWdoIHRvIGZpbGwgdGhlIGRpc3BsYXkKPiBpdCBpcyBiZWluZyBmbGlwcGVk
IHRvLiAgSG93ZXZlciBzb21lIGRyaXZlcnMgc3VwcG9ydCAid2luZG93aW5nIiBvZgo+IHRoZWly
IHByaW1hcnkgcGxhbmVzIChpLmUuLCBhIHByaW1hcnkgcGxhbmUgdGhhdCBkb2VzIG5vdCBjb3Zl
ciB0aGUKPiBlbnRpcmUgQ1JUQyBkaW1lbnNpb25zKTsgaW4gc3VjaCBzaXR1YXRpb25zIHdlIGNh
biB3aW5kIHVwIHJlamVjdGluZwo+IHZhbGlkIHBhZ2VmbGlwcyBvZiBidWZmZXJzIHRoYXQgYXJl
IHNtYWxsZXIgdGhhbiB0aGUgZGlzcGxheSBtb2RlLCBidXQKPiBzdGlsbCBsYXJnZSBlbm91Z2gg
dG8gZmlsbCB0aGUgZW50aXJlIHByaW1hcnkgcGxhbmUuCj4gCj4gV2hhdCB3ZSByZWFsbHkgd2Fu
dCB0byBiZSBjb21wYXJpbmcgYWdhaW5zdCBmb3IgcGFnZWZsaXBzIGlzIHRoZSBzaXplIG9mCj4g
dGhlIHByaW1hcnkgcGxhbmUsIHdoaWNoIGNhbiBiZSBmb3VuZCBpbiBjcnRjLT5wcmltYXJ5LT5z
dGF0ZSBmb3IgYXRvbWljCj4gZHJpdmVycyAoYW5kIGRyaXZlcnMgaW4gdGhlIHByb2Nlc3Mgb2Yg
dHJhbnNpdGlvbmluZyB0byBhdG9taWMpLiAgVGhlcmUKPiBhcmUgbm8gbm9uLWF0b21pYyBkcml2
ZXJzIHRoYXQgc3VwcG9ydCBwcmltYXJ5IHBsYW5lIHdpbmRvd2luZyBhdCB0aGUKPiBtb21lbnQs
IHNvIHdlJ2xsIGNvbnRpbnVlIHRvIHVzZSB0aGUgY3VycmVudCBiZWhhdmlvciBvZiBsb29raW5n
IGF0IHRoZQo+IENSVEMgbW9kZSBzaXplIG9uIGRyaXZlcnMgdGhhdCBkb24ndCBoYXZlIGEgY3J0
Yy0+cHJpbWFyeS0+c3RhdGUuICBXZSdsbAo+IGFsc28gY29udGludWUgdG8gdXNlIHRoZSBleGlz
dGluZyBsb2dpYyBmb3IgU2V0Q3J0Yywgd2hpY2ggaXMgdGhlIG90aGVyCj4gY2FsbHNpdGUgZm9y
IGRybV9jcnRjX2NoZWNrX3ZpZXdwb3J0KCksIHNpbmNlIGxlZ2FjeSBtb2Rlc2V0cyByZXByb2dy
YW0KPiB0aGUgcHJpbWFyeSBwbGFuZSBhbmQgcmVtb3ZlIHdpbmRvd2luZy4KPiAKPiBOb3RlIHRo
YXQgdGhlIGV4aXN0aW5nIGNvZGUgd2FzIGNoZWNraW5nIGEgY3J0Yy0+aW52ZXJ0X2RpbWVuc2lv
bnMgZmllbGQKPiB0byBkZXRlcm1pbmUgd2hldGhlciB0aGUgd2lkdGgvaGVpZ2h0IG9mIHRoZSBt
b2RlIG5lZWRlZCB0byBiZSBzd2FwcGVkLgo+IEEgYm9udXMgb2YgY2hlY2tpbmcgcGxhbmUgc2l6
ZSBpcyB0aGF0IHRoZSBzb3VyY2Ugd2lkdGgvaGVpZ2h0IHdlIGdldAo+IGFscmVhZHkgdGFrZSBy
b3RhdGlvbiBpbnRvIGFjY291bnQgc28gdGhhdCBjaGVjayBpcyBubyBsb25nZXIgbmVjZXNzYXJ5
Cj4gd2hlbiB1c2luZyB0aGUgcGxhbmUgc2l6ZS4KPiAKPiBUZXN0Y2FzZTogaWd0L3VuaXZlcnNh
bC1wbGFuZS1nZW45LWZlYXR1cmVzLXBpcGUtIwo+IFJlcG9ydGVkLWJ5OiBUdnJ0a28gVXJzdWxp
biA8dHZydGtvLnVyc3VsaW5AbGludXguaW50ZWwuY29tPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8
dHZydGtvLnVyc3VsaW5AbGludXguaW50ZWwuY29tPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZp
bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIg
PG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f
Y3J0Yy5jIHwgODcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0t
LQo+ICAxIGZpbGUgY2hhbmdlZCwgNzEgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4g
Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUv
ZHJtL2RybV9jcnRjLmMKPiBpbmRleCBlNjAwYTVmLi4zNWNkNGRjIDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRj
LmMKPiBAQCAtMjUzNCw5ICsyNTM0LDc2IEBAIHZvaWQgZHJtX2NydGNfZ2V0X2h2X3RpbWluZyhj
b25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiAgfQo+ICBFWFBPUlRfU1lNQk9M
KGRybV9jcnRjX2dldF9odl90aW1pbmcpOwo+ICAKPiArc3RhdGljIGludCBjaGVja192aWV3cG9y
dChpbnQgaGRpc3BsYXksCj4gKwkJCSAgaW50IHZkaXNwbGF5LAo+ICsJCQkgIGludCB4LAo+ICsJ
CQkgIGludCB5LAo+ICsJCQkgIGJvb2wgaW52ZXJ0X2RpbWVuc2lvbnMsCj4gKwkJCSAgY29uc3Qg
c3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gK3sKPiArCWlmIChpbnZlcnRfZGltZW5zaW9u
cykKPiArCQlzd2FwKGhkaXNwbGF5LCB2ZGlzcGxheSk7Cj4gKwo+ICsJaWYgKGhkaXNwbGF5ID4g
ZmItPndpZHRoIHx8Cj4gKwkgICAgdmRpc3BsYXkgPiBmYi0+aGVpZ2h0IHx8Cj4gKwkgICAgeCA+
IGZiLT53aWR0aCAtIGhkaXNwbGF5IHx8Cj4gKwkgICAgeSA+IGZiLT5oZWlnaHQgLSB2ZGlzcGxh
eSkgewo+ICsJCURSTV9ERUJVR19LTVMoIkludmFsaWQgZmIgc2l6ZSAldXgldSBmb3IgQ1JUQyB2
aWV3cG9ydCAldXgldSslZCslZCVzLlxuIiwKPiArCQkJICAgICAgZmItPndpZHRoLCBmYi0+aGVp
Z2h0LCBoZGlzcGxheSwgdmRpc3BsYXksIHgsIHksCj4gKwkJCSAgICAgIGludmVydF9kaW1lbnNp
b25zID8gIiAoaW52ZXJ0ZWQpIiA6ICIiKTsKPiArCQlyZXR1cm4gLUVOT1NQQzsKPiArCX0KPiAr
Cj4gKwlyZXR1cm4gMDsKPiArfQoKSSB0aGluayBJJ2QgcmF0aGVyIHB1bGwgdGhlIGxpbWl0IGNo
ZWNrIGNvZGUgZnJvbSB0aGUgc2V0cGxhbmUgcGF0aCB0byBhCnNlcGFyYXRlIGZ1bmN0aW9uLCBh
bmQgY2FsbCB0aGF0IHdpdGggdGhlIHNyYyBjb29yZGluYXRlcyBkZXJpdmVkIGZyb20KZWl0aGVy
IHRoZSBwbGFuZSBzdGF0ZSBvciB0aGUgbW9kZSBkZXBlbmRpbmcgb24gdGhlIHVzZSBjYXNlLiBU
aGF0IHdheQp0aGUgaW52ZXJ0X2RpbWVuc2lvbnMgY3JhcCBjYW4gc3RheSBvbmx5IGluIHRoZSBj
b2RlcGF0aCB0aGF0IGFjdHVhbGx5Cm5lZWRzIGl0LgoKPiArCj4gKy8qKgo+ICsgKiBkcm1fcGxh
bmVfY2hlY2tfdmlld3BvcnQgLSBDaGVja3MgdGhhdCBhIGZyYW1lYnVmZmVyIGlzIGJpZyBlbm91
Z2ggZm9yIHRoZQo+ICsgKiAgICAgcGxhbmUncyB2aWV3cG9ydAo+ICsgKiBAcGxhbmU6IFBsYW5l
IHRoYXQgZnJhbWVidWZmZXIgd2lsbCBiZSBkaXNwbGF5ZWQgb24KPiArICogQHg6IHggcGFubmlu
Zwo+ICsgKiBAeTogeSBwYW5uaW5nCj4gKyAqIEBmYjogZnJhbWVidWZmZXIgdG8gY2hlY2sgc2l6
ZSBvZgo+ICsgKgo+ICsgKiBBdG9taWMgZHJpdmVycyAob3IgdHJhbnNpdGlvbmluZyBkcml2ZXJz
IHRoYXQgc3VwcG9ydCBwcm9wZXIgcGxhbmUgc3RhdGUpCj4gKyAqIG1heSBjYWxsIHRoaXMgZnVu
Y3Rpb24gb24gYW55IHBsYW5lLiAgTm9uLWF0b21pYyBkcml2ZXJzIG1heSBvbmx5IGNhbGwgdGhp
cwo+ICsgKiBmb3IgdGhlIHByaW1hcnkgcGxhbmUgd2hpbGUgdGhlIENSVEMgaXMgYWN0aXZlICh3
ZSdsbCBhc3N1bWUgdGhhdCB0aGUKPiArICogcHJpbWFyeSBwbGFuZSBjb3ZlcnMgdGhlIGVudGly
ZSBDUlRDIGluIHRoYXQgY2FzZSkuCj4gKyAqLwo+ICtpbnQgZHJtX3BsYW5lX2NoZWNrX3ZpZXdw
b3J0KGNvbnN0IHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICsJCQkgICAgIGludCB4LAo+ICsJ
CQkgICAgIGludCB5LAo+ICsJCQkgICAgIGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZi
KQo+ICsKPiArewo+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjID0gcGxhbmUtPmNydGM7Cj4gKwlp
bnQgaGRpc3BsYXksIHZkaXNwbGF5Owo+ICsKPiArCWlmIChXQVJOX09OKHBsYW5lLT5zdGF0ZSA9
PSBOVUxMICYmCj4gKwkJICAgIHBsYW5lLT50eXBlICE9IERSTV9QTEFORV9UWVBFX1BSSU1BUlkp
KQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCS8qCj4gKwkgKiBOb24tYXRvbWljIGRyaXZl
cnMgbWF5IG5vdCBoYXZlIHZhbGlkIHBsYW5lIHN0YXRlIHRvIGxvb2sgYXQuICBCdXQKPiArCSAq
IHRob3NlIGRyaXZlcnMgYWxzbyBkb24ndCBzdXBwb3J0IHdpbmRvd2luZyBvZiB0aGUgcHJpbWFy
eSBwbGFuZSwgc28KPiArCSAqIHdlIGNhbiBmYWxsIGJhY2sgdG8gbG9va2luZyBhdCB0aGUgbW9k
ZSBvZiB0aGUgb3duaW5nIENSVEMuCj4gKwkgKi8KPiArCWlmIChwbGFuZS0+c3RhdGUpIHsKPiAr
CQloZGlzcGxheSA9IHBsYW5lLT5zdGF0ZS0+c3JjX3cgPj4gMTY7Cj4gKwkJdmRpc3BsYXkgPSBw
bGFuZS0+c3RhdGUtPnNyY19oID4+IDE2OwoKWW91IHNob3VsZG4ndCB0cnVuY2F0ZSB0aGVzZS4K
Cj4gKwl9IGVsc2UgaWYgKFdBUk5fT04oIWNydGMpKSB7Cj4gKwkJaGRpc3BsYXkgPSB2ZGlzcGxh
eSA9IDA7Cj4gKwl9IGVsc2Ugewo+ICsJCWRybV9jcnRjX2dldF9odl90aW1pbmcoJmNydGMtPm1v
ZGUsICZoZGlzcGxheSwgJnZkaXNwbGF5KTsKPiArCX0KPiArCj4gKwlyZXR1cm4gY2hlY2tfdmll
d3BvcnQoaGRpc3BsYXksIHZkaXNwbGF5LCB4LCB5LCBmYWxzZSwgZmIpOwo+ICt9Cj4gK0VYUE9S
VF9TWU1CT0woZHJtX3BsYW5lX2NoZWNrX3ZpZXdwb3J0KTsKPiArCj4gIC8qKgo+ICAgKiBkcm1f
Y3J0Y19jaGVja192aWV3cG9ydCAtIENoZWNrcyB0aGF0IGEgZnJhbWVidWZmZXIgaXMgYmlnIGVu
b3VnaCBmb3IgdGhlCj4gLSAqICAgICBDUlRDIHZpZXdwb3J0Cj4gKyAqICAgICBDUlRDIHZpZXdw
b3J0IHdoZW4gcnVubmluZyBpbiB0aGUgc3BlY2lmaWVkIG1vZGUKPiAgICogQGNydGM6IENSVEMg
dGhhdCBmcmFtZWJ1ZmZlciB3aWxsIGJlIGRpc3BsYXllZCBvbgo+ICAgKiBAeDogeCBwYW5uaW5n
Cj4gICAqIEB5OiB5IHBhbm5pbmcKPiBAQCAtMjU1MywyMCArMjYyMCw4IEBAIGludCBkcm1fY3J0
Y19jaGVja192aWV3cG9ydChjb25zdCBzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAo+ICAJZHJt
X2NydGNfZ2V0X2h2X3RpbWluZyhtb2RlLCAmaGRpc3BsYXksICZ2ZGlzcGxheSk7Cj4gIAo+IC0J
aWYgKGNydGMtPmludmVydF9kaW1lbnNpb25zKQo+IC0JCXN3YXAoaGRpc3BsYXksIHZkaXNwbGF5
KTsKPiAtCj4gLQlpZiAoaGRpc3BsYXkgPiBmYi0+d2lkdGggfHwKPiAtCSAgICB2ZGlzcGxheSA+
IGZiLT5oZWlnaHQgfHwKPiAtCSAgICB4ID4gZmItPndpZHRoIC0gaGRpc3BsYXkgfHwKPiAtCSAg
ICB5ID4gZmItPmhlaWdodCAtIHZkaXNwbGF5KSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygiSW52YWxp
ZCBmYiBzaXplICV1eCV1IGZvciBDUlRDIHZpZXdwb3J0ICV1eCV1KyVkKyVkJXMuXG4iLAo+IC0J
CQkgICAgICBmYi0+d2lkdGgsIGZiLT5oZWlnaHQsIGhkaXNwbGF5LCB2ZGlzcGxheSwgeCwgeSwK
PiAtCQkJICAgICAgY3J0Yy0+aW52ZXJ0X2RpbWVuc2lvbnMgPyAiIChpbnZlcnRlZCkiIDogIiIp
Owo+IC0JCXJldHVybiAtRU5PU1BDOwo+IC0JfQo+IC0KPiAtCXJldHVybiAwOwo+ICsJcmV0dXJu
IGNoZWNrX3ZpZXdwb3J0KGhkaXNwbGF5LCB2ZGlzcGxheSwgeCwgeSwKPiArCQkJICAgICAgY3J0
Yy0+aW52ZXJ0X2RpbWVuc2lvbnMsIGZiKTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9jcnRj
X2NoZWNrX3ZpZXdwb3J0KTsKPiAgCj4gQEAgLTUxODEsNyArNTIzNiw3IEBAIGludCBkcm1fbW9k
ZV9wYWdlX2ZsaXBfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQlnb3RvIG91dDsK
PiAgCX0KPiAgCj4gLQlyZXQgPSBkcm1fY3J0Y19jaGVja192aWV3cG9ydChjcnRjLCBjcnRjLT54
LCBjcnRjLT55LCAmY3J0Yy0+bW9kZSwgZmIpOwo+ICsJcmV0ID0gZHJtX3BsYW5lX2NoZWNrX3Zp
ZXdwb3J0KGNydGMtPnByaW1hcnksIGNydGMtPngsIGNydGMtPnksIGZiKTsKPiAgCWlmIChyZXQp
Cj4gIAkJZ290byBvdXQ7Cj4gIAo+IC0tIAo+IDIuMS40CgotLSAKVmlsbGUgU3lyasOkbMOkCklu
dGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ
bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0
cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=