From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi,
Mika Kuoppala <miku@testikku.fi.intel.com>
Subject: Re: [PATCH 07/12] drm/i915: Write mmio workarounds after gpu reset
Date: Wed, 7 Oct 2015 16:23:27 +0200 [thread overview]
Message-ID: <20151007142327.GL3383@phenom.ffwll.local> (raw)
In-Reply-To: <20151007135254.GJ26517@intel.com>
On Wed, Oct 07, 2015 at 04:52:54PM +0300, Ville Syrjälä wrote:
> On Wed, Oct 07, 2015 at 09:43:07AM +0100, Chris Wilson wrote:
> > On Tue, Oct 06, 2015 at 05:26:48PM +0300, Mika Kuoppala wrote:
> > > @@ -6973,8 +6989,12 @@ void intel_init_clock_gating(struct drm_device *dev)
> > > {
> > > struct drm_i915_private *dev_priv = dev->dev_private;
> > >
> > > + intel_wa_init(&dev_priv->mmio_workarounds);
> > > +
> > > if (dev_priv->display.init_clock_gating)
> > > dev_priv->display.init_clock_gating(dev);
> > > +
> > > + intel_wa_write_mmio(dev_priv, &dev_priv->mmio_workarounds);
> > > }
> >
> > Given that we have this function which is in charge of setting the w/a
> > regs and is supposed to be called when initialising the hw after
> > load/reset/resume, why?
>
> I think ideally we should move all the GT related w/as, or at least the
> ones clobbered by a GPU reset into ring init, or somewhere close by.
> The display stuff (and UCGCTL at least) could stay where they are.
> Although I suspect we should move the init_clock_gating earlier in the
> init/resume sequence anyway. I think now we might be a bit late in doing
> it.
Yes, this is how it's supposed to work. Any w/a which gets clobbered by GT
reset and which is still in the init_clock_gating code is just plain a bug
in our driver. We have them aplenty unfortunately :(
Maybe we should add a big kerneldoc to intel_init_clock_gating explaining
that.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-07 14:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 14:26 [PATCH 00/12] MMIO workaround list Mika Kuoppala
2015-10-06 14:26 ` [PATCH 01/12] drm/i915: Prepare for multiple workaround lists Mika Kuoppala
2015-10-06 14:26 ` [PATCH 02/12] drm/i915: Raise the amount of workarounds one list has Mika Kuoppala
2015-10-06 14:26 ` [PATCH 03/12] drm/i915: Don't return inside WA_REG macro Mika Kuoppala
2015-10-06 14:26 ` [PATCH 04/12] drm/i915: Move workaround macros to i915_drv.h Mika Kuoppala
2015-10-06 14:26 ` [PATCH 05/12] drm/i915: Specify the wa list in WA_* macros Mika Kuoppala
2015-10-06 14:26 ` [PATCH 06/12] drm/i915: Introduce mmio workaround list Mika Kuoppala
2015-10-06 14:26 ` [PATCH 07/12] drm/i915: Write mmio workarounds after gpu reset Mika Kuoppala
2015-10-07 8:43 ` Chris Wilson
2015-10-07 13:52 ` Ville Syrjälä
2015-10-07 14:23 ` Daniel Vetter [this message]
2015-10-07 14:22 ` Daniel Vetter
2015-10-06 14:26 ` [PATCH 08/12] drm/i915: Use mmio workaround list for skl/bxt Mika Kuoppala
2015-10-06 14:26 ` [PATCH 09/12] drm/i915/bdw: Use mmio workarounds in init clock gating Mika Kuoppala
2015-10-06 14:26 ` [PATCH 10/12] drm/i915/hsw: " Mika Kuoppala
2015-10-06 14:26 ` [PATCH 11/12] drm/i915/ivb: " Mika Kuoppala
2015-10-06 14:26 ` [PATCH 12/12] drm/i915/ivb: Simplify row chicken setup logic Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007142327.GL3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=miku@iki.fi \
--cc=miku@testikku.fi.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox