From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [v2] drm/i915/skl: Init cdclk in the driver rather than relying on pre-os Date: Thu, 8 Oct 2015 15:24:14 +0300 Message-ID: <20151008122414.GU26517@intel.com> References: <1444058564-13663-1-git-send-email-shobhit.kumar@intel.com> <1444278535-16483-1-git-send-email-shobhit.kumar@intel.com> <1444303746.13547.11.camel@intel.com> <56165DF5.1000307@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F99E6E070 for ; Thu, 8 Oct 2015 05:24:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <56165DF5.1000307@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Kumar, Shobhit" Cc: Shobhit Kumar , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMDgsIDIwMTUgYXQgMDU6NDM6NDFQTSArMDUzMCwgS3VtYXIsIFNob2JoaXQg d3JvdGU6Cj4gT24gMTAvMDgvMjAxNSAwNDo1OSBQTSwgSW1yZSBEZWFrIHdyb3RlOgo+ID4gT24g dG8sIDIwMTUtMTAtMDggYXQgMDk6NTggKzA1MzAsIFNob2JoaXQgS3VtYXIgd3JvdGU6Cj4gPj4g UmV1c2Ugd2hhdCBpcyBwcm9ncmFtbWVkIGJ5IHByZS1vcywgYnV0IGluIGNhc2UgdGhlcmUgaXMg bm8gcHJlLW9zCj4gPj4gaW5pdGlhbGl6YXRpb24sIGluaXQgdGhlIGNkY2xrIHdpdGggdGhlIG1h eCB2YWx1ZSBieSBkZWZhdWx0IHVudGlsbAo+ID4+IGR5bmFtaWMgY2RjbGsgc3VwcG9ydCBjb21l cy4KPiA+Pgo+ID4+IHYyOiBDaGVjayBpZiBCSU9TIHByb2dyYW1tZWQgY29ycmVjdGx5IHJhdGhl ciB0aGFuIGFsd2F5cyBjYWxsaW5nIGluaXQKPiA+PiAgICAgIC0gRG8gdmFsaWRhdGlvbiBvZiBw cm9ncmFtbWVkIGNkY3RsIGFuZCB3aGF0IGl0IGlzIGV4cGVjdGVkCj4gPj4gICAgICAtIE9ubHkg ZG8gc2xrX2luaXRfY2RjbGsgaWYgdmFsaWRhdGlvbiBmYWlsZWQgZWxzZSByZXVzZSBCSU9TCj4g Pj4gICAgICAgIHByb2dyYW1tZWQgdmFsdWUKPiA+Pgo+ID4+IENjOiBJbXJlIERlYWsgPGltcmUu ZGVha0BpbnRlbC5jb20+Cj4gPj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4gPj4gU2lnbmVkLW9mZi1ieTogU2hvYmhpdCBLdW1hciA8c2hvYmhp dC5rdW1hckBpbnRlbC5jb20+Cj4gPj4gLS0tCj4gPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kZGkuYyAgICAgfCAxOCArKysrKysrKysrKystLS0tLQo+ID4+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMzkgKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tCj4gPj4gICAyIGZpbGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDE1IGRl bGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+PiBpbmRleCAy ZDNjYzgyLi4zZWM1NjE4IDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RkaS5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+ PiBAQCAtMjk0NiwxMSArMjk0NiwxOSBAQCB2b2lkIGludGVsX2RkaV9wbGxfaW5pdChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2KQo+ID4+ICAgCQlpbnQgY2RjbGtfZnJlcTsKPiA+Pgo+ID4+ICAgCQlj ZGNsa19mcmVxID0gZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Rpc3BsYXlfY2xvY2tfc3BlZWQoZGV2 KTsKPiA+PiAtCQlkZXZfcHJpdi0+c2tsX2Jvb3RfY2RjbGsgPSBjZGNsa19mcmVxOwo+ID4+IC0J CWlmICghKEk5MTVfUkVBRChMQ1BMTDFfQ1RMKSAmIExDUExMX1BMTF9FTkFCTEUpKQo+ID4+IC0J CQlEUk1fRVJST1IoIkxDUExMMSBpcyBkaXNhYmxlZFxuIik7Cj4gPj4gLQkJZWxzZQo+ID4+IC0J CQlpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwgUE9XRVJfRE9NQUlOX1BMTFMpOwo+ ID4+ICsKPiA+PiArCQkvKiBJbnZhbGlkIENEQ0xLIGZyb20gQklPUyA/ICovCj4gPj4gKwkJaWYg KGNkY2xrX2ZyZXEgPCAwKSB7Cj4gPj4gKwkJCS8qIHByb2dyYW0gdG8gbWF4aW11bSBjZGNsayB0 aWxsIHdlIGhhdmUgZHluYW1pYyBjZGNsayBzdXBwb3J0ICovCj4gPj4gKwkJCWRldl9wcml2LT5z a2xfYm9vdF9jZGNsayA9IDY3NTAwMDsKPiA+PiArCQkJc2tsX2luaXRfY2RjbGsoZGV2X3ByaXYp Owo+ID4KPiA+IFRoaXMgd291bGQgc3RpbGwgdHJ5IHRvIHJlcHJvZ3JhbSBDRENMSyBpZiBCSU9T IGVuYWJsZWQgYW4gb3V0cHV0IHdpdGgKPiA+IGFuIGluY29ycmVjdCBDRENMSyBkZWNpbWFsIHBh cnQuIElzbid0IHRoaXMgdGhlIGV4YWN0IHNjZW5hcmlvIHlvdSdyZQo+ID4gc2VlaW5nPyBBcyBz YWlkIGJlZm9yZSByZXByb2dyYW1taW5nIENEQ0xLIGluIHRoYXQgY2FzZSB3b3VsZCByZXF1aXJl Cj4gPiBkaXNhYmxpbmcgdGhlIG91dHB1dHMgZmlyc3QuCj4gCj4gSSB3ZW50IHdpdGggdGhlIGh5 cG90aGVzaXMgdGhhdCBpZiBWQklPUy9HT1Agd2FzIGxvYWRlZCBpdCB3b3VsZCBoYXZlIHRvIAo+ IGNvcnJlY3QgdGhlIGNkY2xvY2ssIHdpdGggd3JvbmcgZGVjaW1hbCB2YWx1ZSBkaXNwbGF5IGNh bm5vdCBiZSBlbmFibGVkLiAKPiBGb3IgZXhhbXBsZSBBVVggd2lsbCBmYWlsIG9uIFNLTC4gU28g Zm9yIGNvcnJlY3QgZGlzcGxheSBvdXRwdXQgZW5hYmxlZCAKPiBjZGNsb2NrIGhhcyB0byBiZSBj b3JyZWN0bHkgcHJvZ3JhbW1lZC4gSWYgaXQgaXMgd3JvbmcgZGlzcGxheSB3YXMgbm90IAo+IGVu YWJsZWQgYXQgYWxsLgo+IAo+IFRoZSBzY2VuYXJpbyB3aGljaCBJIGFtIHNlZWluZyBpcyBWQklP Uy9HT1AgaXMgbm90IGxvYWRlZCBhdCBhbGwsIGFuZCAKPiB0aGUgcHJlLW9zIGlzIG5vdCBsZWF2 aW5nIGNkY2xvY2sgaW4gY29ycmVjdCBzdGF0ZS4KCkJ1dCBpdCBzdGlsbCBlbmFibGVkIERQTEww PyBXaHkgZG9lcyBpdCBkbyB0aGF0IGlmIGl0IGRvZXNuJ3Qgc2V0IHVwCmNkY2xrPwoKPiAKPiA+ Cj4gPiBXZSB3b3VsZCBhbHNvIG5lZWQgdG8gY2FsbCBza2xfaW5pdF9jZGNsayBpZiB0aGUgQklP UyBoYXNuJ3QgZW5hYmxlZCB0aGUKPiA+IFBMTCBmb3Igc29tZSByZWFzb24uIEJ1dCBJIGd1ZXNz IHRoYXQgY291bGQgYmUgYSBzZXBhcmF0ZSBjaGFuZ2UuCj4gPgo+ID4+ICsJCX0gZWxzZSB7Cj4g Pj4gKwkJCWRldl9wcml2LT5za2xfYm9vdF9jZGNsayA9IGNkY2xrX2ZyZXE7Cj4gPj4gKwkJCWlm ICghKEk5MTVfUkVBRChMQ1BMTDFfQ1RMKSAmIExDUExMX1BMTF9FTkFCTEUpKQo+ID4+ICsJCQkJ RFJNX0VSUk9SKCJMQ1BMTDEgaXMgZGlzYWJsZWRcbiIpOwo+ID4+ICsJCQllbHNlCj4gPj4gKwkJ CQlpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwgUE9XRVJfRE9NQUlOX1BMTFMpOwo+ ID4+ICsJCX0KPiA+PiAgIAl9IGVsc2UgaWYgKElTX0JST1hUT04oZGV2KSkgewo+ID4+ICAgCQli cm94dG9uX2luaXRfY2RjbGsoZGV2KTsKPiA+PiAgIAkJYnJveHRvbl9kZGlfcGh5X2luaXQoZGV2 KTsKPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4gaW5kZXggYmJlYjZk My4uZjczNDQxMCAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK PiA+PiBAQCAtNjYzNCwxMiArNjYzNCwxNSBAQCBzdGF0aWMgaW50IHNreWxha2VfZ2V0X2Rpc3Bs YXlfY2xvY2tfc3BlZWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+PiAgIAl1aW50MzJfdCBs Y3BsbDEgPSBJOTE1X1JFQUQoTENQTEwxX0NUTCk7Cj4gPj4gICAJdWludDMyX3QgY2RjdGwgPSBJ OTE1X1JFQUQoQ0RDTEtfQ1RMKTsKPiA+PiAgIAl1aW50MzJfdCBsaW5rcmF0ZTsKPiA+PiArCWlu dCBmcmVxOwo+ID4+Cj4gPj4gICAJaWYgKCEobGNwbGwxICYgTENQTExfUExMX0VOQUJMRSkpCj4g Pj4gICAJCXJldHVybiAyNDAwMDsgLyogMjRNSHogaXMgdGhlIGNkIGZyZXEgd2l0aCBOU1NDIHJl ZiAqLwo+ID4+Cj4gPj4gLQlpZiAoKGNkY3RsICYgQ0RDTEtfRlJFUV9TRUxfTUFTSykgPT0gQ0RD TEtfRlJFUV81NDApCj4gPj4gLQkJcmV0dXJuIDU0MDAwMDsKPiA+PiArCWlmICgoY2RjdGwgJiBD RENMS19GUkVRX1NFTF9NQVNLKSA9PSBDRENMS19GUkVRXzU0MCkgewo+ID4+ICsJCWZyZXEgPSA1 NDAwMDA7Cj4gPj4gKwkJZ290byB2ZXJpZnk7Cj4gPj4gKwl9Cj4gPj4KPiA+PiAgIAlsaW5rcmF0 ZSA9IChJOTE1X1JFQUQoRFBMTF9DVFJMMSkgJgo+ID4+ICAgCQkgICAgRFBMTF9DVFJMMV9MSU5L X1JBVEVfTUFTSyhTS0xfRFBMTDApKSA+PiAxOwo+ID4+IEBAIC02NjQ5LDMwICs2NjUyLDQ2IEBA IHN0YXRpYyBpbnQgc2t5bGFrZV9nZXRfZGlzcGxheV9jbG9ja19zcGVlZChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2KQo+ID4+ICAgCQkvKiB2Y28gODY0MCAqLwo+ID4+ICAgCQlzd2l0Y2ggKGNkY3Rs ICYgQ0RDTEtfRlJFUV9TRUxfTUFTSykgewo+ID4+ICAgCQljYXNlIENEQ0xLX0ZSRVFfNDUwXzQz MjoKPiA+PiAtCQkJcmV0dXJuIDQzMjAwMDsKPiA+PiArCQkJZnJlcSA9IDQzMjAwMDsKPiA+PiAr CQkJYnJlYWs7Cj4gPj4gICAJCWNhc2UgQ0RDTEtfRlJFUV8zMzdfMzA4Ogo+ID4+IC0JCQlyZXR1 cm4gMzA4NTcwOwo+ID4+ICsJCQlmcmVxID0gMzA4NTcwOwo+ID4+ICsJCQlicmVhazsKPiA+PiAg IAkJY2FzZSBDRENMS19GUkVRXzY3NV82MTc6Cj4gPj4gLQkJCXJldHVybiA2MTcxNDA7Cj4gPj4g KwkJCWZyZXEgPSA2MTcxNDA7Cj4gPj4gKwkJCWJyZWFrOwo+ID4+ICAgCQlkZWZhdWx0Ogo+ID4+ ICAgCQkJV0FSTigxLCAiVW5rbm93biBjZCBmcmVxIHNlbGVjdGlvblxuIik7Cj4gPj4gKwkJCXJl dHVybiAtRUlOVkFMOwo+ID4+ICAgCQl9Cj4gPj4gICAJfSBlbHNlIHsKPiA+PiAgIAkJLyogdmNv IDgxMDAgKi8KPiA+PiAgIAkJc3dpdGNoIChjZGN0bCAmIENEQ0xLX0ZSRVFfU0VMX01BU0spIHsK PiA+PiAgIAkJY2FzZSBDRENMS19GUkVRXzQ1MF80MzI6Cj4gPj4gLQkJCXJldHVybiA0NTAwMDA7 Cj4gPj4gKwkJCWZyZXEgPSA0NTAwMDA7Cj4gPj4gKwkJCWJyZWFrOwo+ID4+ICAgCQljYXNlIENE Q0xLX0ZSRVFfMzM3XzMwODoKPiA+PiAtCQkJcmV0dXJuIDMzNzUwMDsKPiA+PiArCQkJZnJlcSA9 IDMzNzUwMDsKPiA+PiArCQkJYnJlYWs7Cj4gPj4gICAJCWNhc2UgQ0RDTEtfRlJFUV82NzVfNjE3 Ogo+ID4+IC0JCQlyZXR1cm4gNjc1MDAwOwo+ID4+ICsJCQlmcmVxID0gNjc1MDAwOwo+ID4+ICsJ CQlicmVhazsKPiA+PiAgIAkJZGVmYXVsdDoKPiA+PiAgIAkJCVdBUk4oMSwgIlVua25vd24gY2Qg ZnJlcSBzZWxlY3Rpb25cbiIpOwo+ID4+ICsJCQlyZXR1cm4gLUVJTlZBTDsKPiA+PiAgIAkJfQo+ ID4+ICAgCX0KPiA+Pgo+ID4+IC0JLyogZXJyb3IgY2FzZSwgZG8gYXMgaWYgRFBMTDAgaXNuJ3Qg ZW5hYmxlZCAqLwo+ID4+IC0JcmV0dXJuIDI0MDAwOwo+ID4+ICt2ZXJpZnk6Cj4gPj4gKwkvKgo+ ID4+ICsJICogTm90aWNlZCBpbiBzb21lIGluc3RhbmNlcyB0aGF0IHRoZSBmcmVxIHNlbGVjdGlv biBpcyBjb3JyZWN0IGJ1dAo+ID4+ICsJICogZGVjaW1hbCBwYXJ0IGlzIHByb2dyYW1tZWQgd3Jv bmcgZnJvbSBCSU9TIHdoZXJlIHByZS1vcyBkb2VzIG5vdAo+ID4+ICsJICogZW5hYmxlIGRpc3Bs YXkuIFZlcmlmeSB0aGUgc2FtZSBhcyB3ZWxsLgo+ID4+ICsJICovCj4gPj4gKwlpZiAoY2RjdGwg PT0gKChjZGN0bCAmIENEQ0xLX0ZSRVFfU0VMX01BU0spIHwgc2tsX2NkY2xrX2RlY2ltYWwoZnJl cSkpKQo+ID4+ICsJCXJldHVybiBmcmVxOwo+ID4+ICsJZWxzZQo+ID4+ICsJCXJldHVybiAtRUlO VkFMOwo+ID4+ICAgfQo+ID4+Cj4gPj4gICBzdGF0aWMgaW50IGJyb3h0b25fZ2V0X2Rpc3BsYXlf Y2xvY2tfc3BlZWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+Cj4gPgo+ID4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWls aW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiA+Cj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxs ZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==