From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/3] drm/i915: Refactor duplicate object
 vmap functions
Date: Thu, 8 Oct 2015 15:58:13 +0300
Message-ID: <20151008125813.GW26517@intel.com>
References: <1444307996-9573-1-git-send-email-chris@chris-wilson.co.uk>
 <1444307996-9573-2-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTP id AEE3C6E0B0
 for <intel-gfx@lists.freedesktop.org>; Thu,  8 Oct 2015 05:58:16 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1444307996-9573-2-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBPY3QgMDgsIDIwMTUgYXQgMDE6Mzk6NTVQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFdlIG5vdyBoYXZlIHR3byBpbXBsZW1lbnRhdGlvbnMgZm9yIHZtYXBwaW5nIGEgd2hv
bGUgb2JqZWN0LCBvbmUgZm9yCj4gZG1hLWJ1ZiBhbmQgb25lIGZvciB0aGUgcmluZ2J1ZmZlci4g
SWYgd2UgY291cGxlIHRoZSB2bWFwcGluZyBpbnRvIHRoZQo+IG9iai0+cGFnZXMgbGlmZXRpbWUs
IHRoZW4gd2UgY2FuIHJldXNlIGFuIG9iai0+dm1hcHBpbmcgZm9yIGJvdGggYW5kIGF0Cj4gdGhl
IHNhbWUgdGltZSBjb3VwbGUgaXQgaW50byB0aGUgc2hyaW5rZXIuCj4gCj4gU2lnbmVkLW9mZi1i
eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gIGRyaXZl
cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICB8IDEyICsrKystLS0KPiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgIHwgNDEgKysrKysrKysrKysrKysrKysr
KysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2RtYWJ1Zi5jICB8IDU1ICsr
KysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9yaW5nYnVmZmVyLmMgfCA1MyArKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g
IDQgZmlsZXMgY2hhbmdlZCwgNzIgaW5zZXJ0aW9ucygrKSwgODkgZGVsZXRpb25zKC0pCj4gCj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggNDA5M2VlZGZkNjY0Li4zNDNhMGE3MjNkMmMg
MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjA4OSwxMCArMjA4OSw3IEBAIHN0
cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0IHsKPiAgCQlzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnOwo+
ICAJCWludCBsYXN0Owo+ICAJfSBnZXRfcGFnZTsKPiAtCj4gLQkvKiBwcmltZSBkbWEtYnVmIHN1
cHBvcnQgKi8KPiAtCXZvaWQgKmRtYV9idWZfdm1hcHBpbmc7Cj4gLQlpbnQgdm1hcHBpbmdfY291
bnQ7Cj4gKwl2b2lkICp2bWFwcGluZzsKPiAgCj4gIAkvKiogQnJlYWRjcnVtYiBvZiBsYXN0IHJl
bmRlcmluZyB0byB0aGUgYnVmZmVyLgo+ICAJICogVGhlcmUgY2FuIG9ubHkgYmUgb25lIHdyaXRl
ciwgYnV0IHdlIGFsbG93IGZvciBtdWx0aXBsZSByZWFkZXJzLgo+IEBAIC0yODQwLDEyICsyODM3
LDE5IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBpOTE1X2dlbV9vYmplY3RfcGluX3BhZ2VzKHN0cnVj
dCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gIAlCVUdfT04ob2JqLT5wYWdlcyA9PSBOVUxM
KTsKPiAgCW9iai0+cGFnZXNfcGluX2NvdW50Kys7Cj4gIH0KPiArCj4gIHN0YXRpYyBpbmxpbmUg
dm9pZCBpOTE1X2dlbV9vYmplY3RfdW5waW5fcGFnZXMoc3RydWN0IGRybV9pOTE1X2dlbV9vYmpl
Y3QgKm9iaikKPiAgewo+ICAJQlVHX09OKG9iai0+cGFnZXNfcGluX2NvdW50ID09IDApOwo+ICAJ
b2JqLT5wYWdlc19waW5fY291bnQtLTsKPiAgfQo+ICAKPiArdm9pZCAqX19tdXN0X2NoZWNrIGk5
MTVfZ2VtX29iamVjdF9waW5fdm1hcChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKTsK
PiArc3RhdGljIGlubGluZSB2b2lkIGk5MTVfZ2VtX29iamVjdF91bnBpbl92bWFwKHN0cnVjdCBk
cm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gK3sKPiArCWk5MTVfZ2VtX29iamVjdF91bnBpbl9w
YWdlcyhvYmopOwo+ICt9Cj4gKwo+ICBpbnQgX19tdXN0X2NoZWNrIGk5MTVfbXV0ZXhfbG9ja19p
bnRlcnJ1cHRpYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICBpbnQgaTkxNV9nZW1fb2Jq
ZWN0X3N5bmMoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgCQkJIHN0cnVjdCBp
bnRlbF9lbmdpbmVfY3MgKnRvLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDc4NjQw
YWVjZjg2ZC4uNDQ2Y2YwNjYyYTM4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAg
LTIxNTksNiArMjE1OSwxMSBAQCBpOTE1X2dlbV9vYmplY3RfcHV0X3BhZ2VzKHN0cnVjdCBkcm1f
aTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gIAlvcHMtPnB1dF9wYWdlcyhvYmopOwo+ICAJb2JqLT5w
YWdlcyA9IE5VTEw7Cj4gIAo+ICsJaWYgKG9iai0+dm1hcHBpbmcpIHsKPiArCQl2dW5tYXAob2Jq
LT52bWFwcGluZyk7Cj4gKwkJb2JqLT52bWFwcGluZyA9IE5VTEw7Cj4gKwl9Cj4gKwo+ICAJaTkx
NV9nZW1fb2JqZWN0X2ludmFsaWRhdGUob2JqKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiBAQCAtMjMy
NSw2ICsyMzMwLDQyIEBAIGk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZXMoc3RydWN0IGRybV9pOTE1
X2dlbV9vYmplY3QgKm9iaikKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ICt2b2lkICppOTE1X2dl
bV9vYmplY3RfcGluX3ZtYXAoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPiArewo+
ICsJaW50IHJldDsKPiArCj4gKwlyZXQgPSBpOTE1X2dlbV9vYmplY3RfZ2V0X3BhZ2VzKG9iaik7
Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gKwo+ICsJaTkxNV9nZW1f
b2JqZWN0X3Bpbl9wYWdlcyhvYmopOwo+ICsKPiArCWlmIChvYmotPnZtYXBwaW5nID09IE5VTEwp
IHsKPiArCQlzdHJ1Y3Qgc2dfcGFnZV9pdGVyIHNnX2l0ZXI7Cj4gKwkJc3RydWN0IHBhZ2UgKipw
YWdlczsKPiArCQlpbnQgbjsKPiArCj4gKwkJbiA9IG9iai0+YmFzZS5zaXplID4+IFBBR0VfU0hJ
RlQ7Cj4gKwkJcGFnZXMgPSBrbWFsbG9jKG4qc2l6ZW9mKCpwYWdlcyksIEdGUF9URU1QT1JBUlkp
OwoKUmFuZG9tIGRyaXZlYnk6IGttYWxsb2NfYXJyYXkoKQoKQWxzbyBfX0dGUF9OT1dBUk4/CgpJ
IHdvbmRlciBpZiB0aGUgZHJtX21hbGxvYyBzdHVmZiBzaG91bGQgZG8gdGhlIGttYWxsb2MgYXR0
ZW1wdApyZWdhcmRsZXNzIGZvIHRoZSBzaXplLCBzbyB3ZSB3b3VsZG4ndCBoYXZlIHRvIGRvIGl0
IGhlcmU/Cgo+ICsJCWlmIChwYWdlcyA9PSBOVUxMKQo+ICsJCQlwYWdlcyA9IGRybV9tYWxsb2Nf
YWIobiwgc2l6ZW9mKCpwYWdlcykpOwo+ICsJCWlmIChwYWdlcyAhPSBOVUxMKSB7Cj4gKwkJCW4g
PSAwOwo+ICsJCQlmb3JfZWFjaF9zZ19wYWdlKG9iai0+cGFnZXMtPnNnbCwgJnNnX2l0ZXIsIG9i
ai0+cGFnZXMtPm5lbnRzLCAwKQo+ICsJCQkJcGFnZXNbbisrXSA9IHNnX3BhZ2VfaXRlcl9wYWdl
KCZzZ19pdGVyKTsKPiArCj4gKwkJCW9iai0+dm1hcHBpbmcgPSB2bWFwKHBhZ2VzLCBuLCAwLCBQ
QUdFX0tFUk5FTCk7Cj4gKwkJCWRybV9mcmVlX2xhcmdlKHBhZ2VzKTsKPiArCQl9Cj4gKwkJaWYg
KG9iai0+dm1hcHBpbmcgPT0gTlVMTCkgewo+ICsJCQlpOTE1X2dlbV9vYmplY3RfdW5waW5fcGFn
ZXMob2JqKTsKPiArCQkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4gKwkJfQo+ICsJfQo+ICsK
PiArCXJldHVybiBvYmotPnZtYXBwaW5nOwo+ICt9Cj4gKwo+ICB2b2lkIGk5MTVfdm1hX21vdmVf
dG9fYWN0aXZlKHN0cnVjdCBpOTE1X3ZtYSAqdm1hLAo+ICAJCQkgICAgIHN0cnVjdCBkcm1faTkx
NV9nZW1fcmVxdWVzdCAqcmVxKQo+ICB7CjxzbmlwPgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl
bCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50
ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK