From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: fix CFB size calculation Date: Fri, 9 Oct 2015 00:29:27 +0300 Message-ID: <20151008212927.GE26517@intel.com> References: <1443740082.2442.27.camel@intel.com> <1443740157-3803-1-git-send-email-paulo.r.zanoni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id D7E037A093 for ; Thu, 8 Oct 2015 14:29:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1443740157-3803-1-git-send-email-paulo.r.zanoni@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMDEsIDIwMTUgYXQgMDc6NTU6NTdQTSAtMDMwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IFdlIHdlcmUgY29uc2lkZXJpbmcgdGhlIHdob2xlIGZyYW1lYnVmZmVyIGhlaWdodCwg YnV0IHRoZSBzcGVjIHNheXMgd2UKPiBzaG91bGQgb25seSBjb25zaWRlciB0aGUgYWN0aXZlIGRp c3BsYXkgaGVpZ2h0IHNpemUuIFRoZXJlIHdlcmUgc3RpbGwKPiBzb21lIHVuY2xlYXIgcXVlc3Rp b25zIGJhc2VkIG9uIHRoZSBzcGVjLCBidXQgdGhlIGhhcmR3YXJlIGd1eXMKPiBjbGFyaWZpZWQg dGhlbSBmb3IgdXMuIEFjY29yZGluZyB0byB0aGVtOgo+IAo+IC0gQ0ZCIHNpemUgPSBDRkIgc3Ry aWRlICogTnVtYmVyIG9mIGxpbmVzIEZCQyB3cml0ZXMgdG8gQ0ZCCj4gLSBDRkIgc3RyaWRlID0g cGxhbmUgc3RyaWRlIC8gY29tcHJlc3Npb24gbGltaXQKPiAtIE51bWJlciBvZiBsaW5lcyBGQkMg d3JpdGVzIHRvIENGQiA9IE1JTihwbGFuZSBzb3VyY2UgaGVpZ2h0LCBtYXhpbXVtCj4gICBudW1i ZXIgb2YgbGluZXMgRkJDIHdyaXRlcyB0byBDRkIpCj4gLSBQbGFuZSBzb3VyY2UgaGVpZ2h0ID0K PiAgIC0gcGlwZSBzb3VyY2UgaGVpZ2h0IChQSVBFX1NSQ1NaIHJlZ2lzdGVyKSAoYmVmb3JlIFNL TCkKPiAgIC0gcGxhbmUgc2l6ZSByZWdpc3RlciBoZWlnaHQgKFBMQU5FX1NJWkUgcmVnaXN0ZXIp IChTS0wrKQo+IC0gTWF4aW11bSBudW1iZXIgb2YgbGluZXMgRkJDIHdyaXRlcyB0byBDRkIgPQo+ ICAgLSBwbGFuZSBzb3VyY2UgaGVpZ2h0IChiZWZvcmUgSFNXKQo+ICAgLSAyMDQ4IChIU1crKQo+ IAo+IEZvciB0aGUgcGxhbmUgc291cmNlIGhlaWdodCwgSSBjb3VsZCBqdXN0IGhhdmUgbWFkZSBv dXIgY29kZSBkbwo+IEk5MTVfUkVBRCgpIGluIG9yZGVyIHRvIGJlIG1vcmUgZnV0dXJlIHByb29m LCBidXQgc2luY2UgaXQncyBub3QgY29vbAo+IHRvIGRvIHJlZ2lzdGVyIHJlYWRzIEkgZGVjaWRl ZCB0byBqdXN0IHJlY2FsY3VsYXRlIHRoZSB2YWx1ZXMgd2UgdXNlCj4gd2hlbiB3ZSBhY3R1YWxs eSB3cml0ZSB0byB0aG9zZSByZWdpc3RlcnMuCj4gCj4gV2l0aCB0aGlzIHBhdGNoLCBkZXBlbmRp bmcgb24geW91ciBtYWNoaW5lIGNvbmZpZ3VyYXRpb24sIGEgbG90IG9mIHRoZQo+IGttc19mcm9u dGJ1ZmZlcl90cmFja2luZyBzdWJ0ZXN0cyB0aGF0IHVzZWQgdG8gcmVzdWx0IGluIGEgU0tJUCBk dWUgdG8KPiBub3QgZW5vdWdoIHN0b2xlbiBtZW1vcnkgc3RpbGwgc3RhcnQgcmVzdWx0aW5nIGlu IGEgUEFTUy4KPiAKPiB2MjogVXNlIHRoZSBjbGlwcGVkIHNyYyBzaXplIGluc3RlYWQgb2YgcGlw ZV9zcmNfaCAoVmlsbGUpLgo+IHYzOiBVc2UgdGhlIGFwcHJvcHJpYXRlIGluZm9ybWF0aW9uIHBy b3ZpZGVkIGJ5IHRoZSBoYXJkd2FyZSBndXlzLgo+IHY0OiBCaWtlc2hlZHM6IHMvc2l6ZXMvc2l6 ZS8sIHMvZmJfY3BwL2NwcC8gKFZpbGxlKS4KPiB2NTogLSBEb24ndCB1c2UgY3J0Yy0+Y29uZmln LT5waXBlX3NyY194IGZvciBCRFctIChWaWxsZSkuCj4gICAgIC0gRml4IHRoZSByZWdpc3RlciBu YW1lIHdyaXR0ZW4gaW4gdGhlIGNvbW1lbnQuCj4gCj4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFu b25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2ZiYy5jIHwgNTQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+IGluZGV4IDFiMmViYjIuLjE4ZTIyOGIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+IEBAIC02OTgsMTYgKzY5OCw2MSBAQCB2b2lk IGludGVsX2ZiY19jbGVhbnVwX2NmYihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gIAltdXRleF91bmxvY2soJmRldl9wcml2LT5mYmMubG9jayk7Cj4gIH0KPiAgCj4gLXN0YXRp YyBpbnQgaW50ZWxfZmJjX3NldHVwX2NmYihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsIGludCBzaXplLAo+IC0JCQkgICAgICAgaW50IGZiX2NwcCkKPiArLyoKPiArICogRm9yIFNL TCssIHRoZSBwbGFuZSBzb3VyY2Ugc2l6ZSB1c2VkIGJ5IHRoZSBoYXJkd2FyZSBpcyBiYXNlZCBv biB0aGUgdmFsdWUgd2UKPiArICogd3JpdGUgdG8gdGhlIFBMQU5FX1NJWkUgcmVnaXN0ZXIuIEZv ciBCRFctLCB0aGUgaGFyZHdhcmUgbG9va3MgYXQgdGhlIHZhbHVlCj4gKyAqIHdlIHdyb3RlIHRv IFBJUEVTUkMuCj4gKyAqLwo+ICtzdGF0aWMgdm9pZCBpbnRlbF9mYmNfZ2V0X3BsYW5lX3NvdXJj ZV9zaXplKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICsJCQkJCSAgICBpbnQgKndpZHRoLCBp bnQgKmhlaWdodCkKPiAgewo+ICsJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0 ZSA9Cj4gKwkJCXRvX2ludGVsX3BsYW5lX3N0YXRlKGNydGMtPmJhc2UucHJpbWFyeS0+c3RhdGUp Owo+ICsJaW50IHcsIGg7Cj4gKwo+ICsJaWYgKGludGVsX3JvdGF0aW9uXzkwX29yXzI3MChwbGFu ZV9zdGF0ZS0+YmFzZS5yb3RhdGlvbikpIHsKPiArCQl3ID0gZHJtX3JlY3RfaGVpZ2h0KCZwbGFu ZV9zdGF0ZS0+c3JjKSA+PiAxNjsKPiArCQloID0gZHJtX3JlY3Rfd2lkdGgoJnBsYW5lX3N0YXRl LT5zcmMpID4+IDE2Owo+ICsJfSBlbHNlIHsKPiArCQl3ID0gZHJtX3JlY3Rfd2lkdGgoJnBsYW5l X3N0YXRlLT5zcmMpID4+IDE2Owo+ICsJCWggPSBkcm1fcmVjdF9oZWlnaHQoJnBsYW5lX3N0YXRl LT5zcmMpID4+IDE2Owo+ICsJfQo+ICsKPiArCWlmICh3aWR0aCkKPiArCQkqd2lkdGggPSB3Owo+ ICsJaWYgKGhlaWdodCkKPiArCQkqaGVpZ2h0ID0gaDsKPiArfQoKWWVwLCBJIGxpa2UgdGhpcyBt dWNoIGJldHRlci4gCgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KCj4gKwo+ICtzdGF0aWMgaW50IGludGVsX2ZiY19jYWxjdWxhdGVf Y2ZiX3NpemUoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IGNydGMtPmJhc2UuZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0 cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gY3J0Yy0+YmFzZS5wcmltYXJ5LT5mYjsKPiArCWlu dCBsaW5lczsKPiArCj4gKwlpbnRlbF9mYmNfZ2V0X3BsYW5lX3NvdXJjZV9zaXplKGNydGMsIE5V TEwsICZsaW5lcyk7Cj4gKwlpZiAoSU5URUxfSU5GTyhkZXZfcHJpdiktPmdlbiA+PSA3KQo+ICsJ CWxpbmVzID0gbWluKGxpbmVzLCAyMDQ4KTsKPiArCj4gKwlyZXR1cm4gbGluZXMgKiBmYi0+cGl0 Y2hlc1swXTsKPiArfQo+ICsKPiArc3RhdGljIGludCBpbnRlbF9mYmNfc2V0dXBfY2ZiKHN0cnVj dCBpbnRlbF9jcnRjICpjcnRjKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSBjcnRjLT5iYXNlLmRldi0+ZGV2X3ByaXZhdGU7Cj4gKwlzdHJ1Y3QgZHJtX2ZyYW1l YnVmZmVyICpmYiA9IGNydGMtPmJhc2UucHJpbWFyeS0+ZmI7Cj4gKwlpbnQgc2l6ZSwgY3BwOwo+ ICsKPiArCXNpemUgPSBpbnRlbF9mYmNfY2FsY3VsYXRlX2NmYl9zaXplKGNydGMpOwo+ICsJY3Bw ID0gZHJtX2Zvcm1hdF9wbGFuZV9jcHAoZmItPnBpeGVsX2Zvcm1hdCwgMCk7Cj4gKwo+ICAJaWYg KHNpemUgPD0gZGV2X3ByaXYtPmZiYy51bmNvbXByZXNzZWRfc2l6ZSkKPiAgCQlyZXR1cm4gMDsK PiAgCj4gIAkvKiBSZWxlYXNlIGFueSBjdXJyZW50IGJsb2NrICovCj4gIAlfX2ludGVsX2ZiY19j bGVhbnVwX2NmYihkZXZfcHJpdik7Cj4gIAo+IC0JcmV0dXJuIGludGVsX2ZiY19hbGxvY19jZmIo ZGV2X3ByaXYsIHNpemUsIGZiX2NwcCk7Cj4gKwlyZXR1cm4gaW50ZWxfZmJjX2FsbG9jX2NmYihk ZXZfcHJpdiwgc2l6ZSwgY3BwKTsKPiAgfQo+ICAKPiAgc3RhdGljIGJvb2wgc3RyaWRlX2lzX3Zh bGlkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiBAQCAtODk3LDggKzk0Miw3 IEBAIHN0YXRpYyB2b2lkIF9faW50ZWxfZmJjX3VwZGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gIAkJZ290byBvdXRfZGlzYWJsZTsKPiAgCX0KPiAgCj4gLQlpZiAoaW50 ZWxfZmJjX3NldHVwX2NmYihkZXZfcHJpdiwgb2JqLT5iYXNlLnNpemUsCj4gLQkJCQlkcm1fZm9y bWF0X3BsYW5lX2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAwKSkpIHsKPiArCWlmIChpbnRlbF9mYmNf c2V0dXBfY2ZiKGludGVsX2NydGMpKSB7Cj4gIAkJc2V0X25vX2ZiY19yZWFzb24oZGV2X3ByaXYs IEZCQ19TVE9MRU5fVE9PX1NNQUxMKTsKPiAgCQlnb3RvIG91dF9kaXNhYmxlOwo+ICAJfQo+IC0t IAo+IDIuNS4zCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==