From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/3] drm/i915: fix FBC buffer size checks Date: Fri, 9 Oct 2015 09:36:08 +0200 Message-ID: <20151009073608.GD18060@phenom.ffwll.local> References: <1443722639.2442.22.camel@intel.com> <1443740232-3918-1-git-send-email-paulo.r.zanoni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D7F86E636 for ; Fri, 9 Oct 2015 00:33:15 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so55002231wic.1 for ; Fri, 09 Oct 2015 00:33:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1443740232-3918-1-git-send-email-paulo.r.zanoni@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMDEsIDIwMTUgYXQgMDc6NTc6MTJQTSAtMDMwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IEFjY29yZGluZyB0byBteSBleHBlcmltZW50cyAoYW5kIGxhdGVyIGNvbmZpcm1hdGlv biBmcm9tIHRoZSBoYXJkd2FyZQo+IGRldmVsb3BlcnMpLCB0aGUgbWF4aW11bSBzaXplcyBtZW50 aW9uZWQgaW4gdGhlIHNwZWNpZmljYXRpb24gZGVsaW1pdAo+IGhvdyBmYXIgaW4gdGhlIGJ1ZmZl ciB0aGUgaGFyZHdhcmUgdHJhY2tpbmcgY2FuIGdvLiBBbmQgdGhlIGhhcmR3YXJlCj4gY2FsY3Vs YXRlcyB0aGUgc2l6ZSBiYXNlZCBvbiB0aGUgcGxhbmUgYWRkcmVzcyB3ZSBwcm92aWRlIC0gYW5k IHRoZQo+IHByb3ZpZGVkIHBsYW5lIGFkZHJlc3MgbWlnaHQgbm90IGJlIHRoZSByZWFsIHg6MCx5 OjAgcG9pbnQgZHVlIHRvIHRoZQo+IGNvbXB1dGVfcGFnZV9vZmZzZXQoKSBmdW5jdGlvbi4KPiAK PiBPbiBwbGF0Zm9ybXMgdGhhdCBkbyB0aGUgeC95IG9mZnNldCBhZGp1c3RtZW50IHRyaWNrIGl0 IHdpbGwgYmUgcmVhbGx5Cj4gaGFyZCB0byByZXByb2R1Y2UgYSBidWcsIGJ1dCBvbiB0aGUgY3Vy cmVudCBTS0wgd2UgY2FuIHJlcHJvZHVjZSB0aGUKPiBidWcgd2l0aCBpZ3Qva21zX2Zyb250YnVm ZmVyX3RyYWNraW5nL2ZiYy1mYXJmcm9tZmVuY2UuIFdpdGggdGhpcwo+IHBhdGNoLCB3ZSdsbCBn byBmcm9tICJDUkMgYXNzZXJ0aW9uIGZhaWx1cmUiIHRvICJGQkMgdW5leHBlY3RlZGx5Cj4gZGlz YWJsZWQiLCB3aGljaCBpcyBzdGlsbCBhIGZhaWx1cmUgb24gdGhlIHRlc3Qgc3VpdGUgYnV0IGlz IG5vdCBhCj4gcGVyY2VpdmVkIHVzZXIgYnVnIC0geW91IHdpbGwganVzdCBub3Qgc2F2ZSBhcyBt dWNoIHBvd2VyIGFzIHlvdSBjb3VsZAo+IGlmIEZCQyBpcyBkaXNhYmxlZC4KPiAKPiB2MiwgcmV3 cml0ZSBwYXRjaCBhZnRlciBjbGFyaWZpY2F0aW9uIGZyb20gdGhlIEhhZHdhcmUgZ3V5czoKPiAg IC0gUmVuYW1lIGZ1bmN0aW9uIHNvIGl0J3MgY2xlYXIgd2hhdCB0aGUgY2hlY2sgaXMgZm9yLgo+ ICAgLSBVc2UgdGhlIG5ldyBpbnRlbF9mYmNfZ2V0X3BsYW5lX3NvdXJjZV9zaXplcygpIGZ1bmN0 aW9uIGluIG9yZGVyCj4gICAgIHRvIGdldCB0aGUgcHJvcGVyIHNpemVzIGFzIHNlZW4gYnkgRkJD Lgo+IHYzOgo+ICAgLSBSZWJhc2UgYWZ0ZXIgdGhlIHMvc2l6ZXMvc2l6ZS8gb24gdGhlIHByZXZp b3VzIHBhdGNoLgo+ICAgLSBBZGp1c3QgY29tbWVudCB3b3JkaW5nIChWaWxsZSkuCj4gICAtIHMv dXNlZF8vZWZmZWN0aXZlXy8gKFZpbGxlKS4KPiAKPiBUZXN0Y2FzZTogaWd0L2ttc19mcm9udGJ1 ZmZlcl90cmFja2luZy9mYmMtZmFyZnJvbWZlbmNlIChTS0wpCj4gUmV2aWV3ZWQtYnk6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1i eTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+CgpNZXJnZWQgdGhlc2Ug dGhyZWUgcGF0Y2hlcyB0byBkaW5xLCB0aGFua3MuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jIHwgMTkgKysrKysrKysrKysrKystLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9mYmMuYwo+IGluZGV4IDE4ZTIyOGIuLmNmNDczNTIgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9mYmMuYwo+IEBAIC03OTksMTAgKzc5OSwxNiBAQCBzdGF0aWMgYm9vbCBwaXhl bF9mb3JtYXRfaXNfdmFsaWQoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gIAl9Cj4gIH0K PiAgCj4gLXN0YXRpYyBib29sIHBpcGVfc2l6ZV9pc192YWxpZChzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YykKPiArLyoKPiArICogRm9yIHNvbWUgcmVhc29uLCB0aGUgaGFyZHdhcmUgdHJhY2tpbmcg c3RhcnRzIGxvb2tpbmcgYXQgd2hhdGV2ZXIgd2UKPiArICogcHJvZ3JhbW1lZCBhcyB0aGUgZGlz cGxheSBwbGFuZSBiYXNlIGFkZHJlc3MgcmVnaXN0ZXIuIEl0IGRvZXMgbm90IGxvb2sgYXQKPiAr ICogdGhlIFggYW5kIFkgb2Zmc2V0IHJlZ2lzdGVycy4gVGhhdCdzIHdoeSB3ZSBsb29rIGF0IHRo ZSBjcnRjLT5hZGp1c3RlZHt4LHl9Cj4gKyAqIHZhcmlhYmxlcyBpbnN0ZWFkIG9mIGp1c3QgbG9v a2luZyBhdCB0aGUgcGlwZS9wbGFuZSBzaXplLgo+ICsgKi8KPiArc3RhdGljIGJvb2wgaW50ZWxf ZmJjX2h3X3RyYWNraW5nX2NvdmVyc19zY3JlZW4oc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4g IHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGNydGMtPmJhc2UuZGV2 LT5kZXZfcHJpdmF0ZTsKPiAtCXVuc2lnbmVkIGludCBtYXhfdywgbWF4X2g7Cj4gKwl1bnNpZ25l ZCBpbnQgZWZmZWN0aXZlX3csIGVmZmVjdGl2ZV9oLCBtYXhfdywgbWF4X2g7Cj4gIAo+ICAJaWYg KElOVEVMX0lORk8oZGV2X3ByaXYpLT5nZW4gPj0gOCB8fCBJU19IQVNXRUxMKGRldl9wcml2KSkg ewo+ICAJCW1heF93ID0gNDA5NjsKPiBAQCAtODE1LDggKzgyMSwxMSBAQCBzdGF0aWMgYm9vbCBw aXBlX3NpemVfaXNfdmFsaWQoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIAkJbWF4X2ggPSAx NTM2Owo+ICAJfQo+ICAKPiAtCXJldHVybiBjcnRjLT5jb25maWctPnBpcGVfc3JjX3cgPD0gbWF4 X3cgJiYKPiAtCSAgICAgICBjcnRjLT5jb25maWctPnBpcGVfc3JjX2ggPD0gbWF4X2g7Cj4gKwlp bnRlbF9mYmNfZ2V0X3BsYW5lX3NvdXJjZV9zaXplKGNydGMsICZlZmZlY3RpdmVfdywgJmVmZmVj dGl2ZV9oKTsKPiArCWVmZmVjdGl2ZV93ICs9IGNydGMtPmFkanVzdGVkX3g7Cj4gKwllZmZlY3Rp dmVfaCArPSBjcnRjLT5hZGp1c3RlZF95Owo+ICsKPiArCXJldHVybiBlZmZlY3RpdmVfdyA8PSBt YXhfdyAmJiBlZmZlY3RpdmVfaCA8PSBtYXhfaDsKPiAgfQo+ICAKPiAgLyoqCj4gQEAgLTg5Myw3 ICs5MDIsNyBAQCBzdGF0aWMgdm9pZCBfX2ludGVsX2ZiY191cGRhdGUoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCWdvdG8gb3V0X2Rpc2FibGU7Cj4gIAl9Cj4gIAo+IC0J aWYgKCFwaXBlX3NpemVfaXNfdmFsaWQoaW50ZWxfY3J0YykpIHsKPiArCWlmICghaW50ZWxfZmJj X2h3X3RyYWNraW5nX2NvdmVyc19zY3JlZW4oaW50ZWxfY3J0YykpIHsKPiAgCQlzZXRfbm9fZmJj X3JlYXNvbihkZXZfcHJpdiwgRkJDX01PREVfVE9PX0xBUkdFKTsKPiAgCQlnb3RvIG91dF9kaXNh YmxlOwo+ICAJfQo+IC0tIAo+IDIuNS4zCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2lu ZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=