Re: [PATCH 4/7] drm/i915: export size_is_valid() from __intel_fbc_update()

Paulo Zanoni
2015-09-28T13:13:06Z

2015-09-28 9:47 GMT-03:00 Ville Syrjälä <ville.syrjala@linux.intel.com>:
> On Mon, Sep 28, 2015 at 10:59:13AM +0200, Daniel Vetter wrote:
>> On Wed, Sep 23, 2015 at 06:09:04PM +0100, Chris Wilson wrote:
>> > s/Export/Extract/
>> >
>> > Export made me think you wanted to use it from another file.
>> >
>> > On Wed, Sep 23, 2015 at 12:52:24PM -0300, Paulo Zanoni wrote:
>> > > Make the giant function a little less giant
>> >
>> > ...and make it a little more self-documenting by refactoring the
>> > valid size predicate..
>> >
>> > > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> > > ---
>> > > drivers/gpu/drm/i915/intel_fbc.c | 35 ++++++++++++++++++++++-------------
>> > > 1 file changed, 22 insertions(+), 13 deletions(-)
>> > >
>> > > diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
>> > > index 0a6b454..0c7b59b 100644
>> > > --- a/drivers/gpu/drm/i915/intel_fbc.c
>> > > +++ b/drivers/gpu/drm/i915/intel_fbc.c
>> > > @@ -755,6 +755,26 @@ static bool pixel_format_is_valid(struct drm_framebuffer *fb)
>> > > }
>> > > }
>> > >
>> > > +static bool size_is_valid(struct intel_crtc *crtc)
>> >
>> > Which size?
>> >
>> > pipe_size_fits_in_fbc()
>> > pipe_size_valid()
>> > pipe_size_fits()
>> >
>> > I think I prefer pipe_size_valid().
>>
>> Painted while applying, thanks.
>
> And it's not what we really want. We should be looking at the plane src size.

I can fix the name on patch 5/7 if we need.

>
>> -Daniel
>>
>> >
>> > Naming quibles aside (but admittedly that is the purpose of the patch!),
>> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>>
>> Yea
>> > -Chris
>> >
>> > --
>> > Chris Wilson, Intel Open Source Technology Centre
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> http://blog.ffwll.ch
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni