Re: [PATCH 1/2] drm/i915/skl: Enable pipe gamma for sprite planes.

Ville Syrjälä
2015-10-15T12:45:13Z

On Thu, Aug 27, 2015 at 01:46:30PM -0700, Bob Paauwe wrote:
> Since SKL has universal planes, we should configure the sprite planes
> and the primary plane the same. For the primary plane we do enable
> the pipe gamma on the plane so do the same for the non-primary planes.
>
> Without this, the pipe CRC values will be different for something
> displayed on the primary plane and something displayed on a sprite
> plane when the ARGB8888 format is used.
>
> Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
> drivers/gpu/drm/i915/intel_sprite.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 9d8af2f..048d397 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -189,6 +189,7 @@ skl_update_plane(struct drm_plane *drm_plane, struct drm_crtc *crtc,
> int scaler_id;
>
> plane_ctl = PLANE_CTL_ENABLE |
> + PLANE_CTL_PIPE_GAMMA_ENABLE |
> PLANE_CTL_PIPE_CSC_ENABLE;
>
> plane_ctl |= skl_plane_ctl_format(fb->pixel_format);
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel OTC