From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH v5 1/2] drm/i915: Fix failure paths around
 initial fbdev allocation
Date: Thu, 15 Oct 2015 19:14:35 +0200
Message-ID: <20151015171435.GA17598@wunner.de>
References: <f0cd66427039ce1bdc61460a9d833e6d858cff3e.1441363361.git.lukas@wunner.de>
 <20151013150440.GR26517@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mailout1.hostsharing.net (mailout1.hostsharing.net
 [83.223.95.204])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 395D66E039
 for <intel-gfx@lists.freedesktop.org>; Thu, 15 Oct 2015 10:14:42 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20151013150440.GR26517@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

SGkgVmlsbGUsCgpPbiBUdWUsIE9jdCAxMywgMjAxNSBhdCAwNjowNDo0MFBNICswMzAwLCBWaWxs
ZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gT24gVHVlLCBKdW4gMzAsIDIwMTUgYXQgMTA6MDY6MjdBTSAr
MDEwMCwgTHVrYXMgV3VubmVyIHdyb3RlOgo+ID4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRr
by51cnN1bGluQGludGVsLmNvbT4KPiA+IAo+ID4gV2UgaGFkIHR3byBmYWlsdXJlIG1vZGVzIGhl
cmU6Cj4gPiAKPiA+IDEuCj4gPiBEZWFkbG9jayBpbiBpbnRlbGZiX2FsbG9jIGZhaWx1cmUgcGF0
aCB3aGVyZSBpdCBjYWxscwo+ID4gZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZSwgd2hpY2ggZ3JhYnMg
dGhlIHN0cnVjdCBtdXRleCBhbmQgaW50ZWxmYl9jcmVhdGUKPiA+IChjYWxsZXIgb2YgaW50ZWxm
Yl9hbGxvYykgd2FzIGFscmVhZHkgaG9sZGluZyBpdC4KPiA+IAo+ID4gMi4KPiA+IERlYWRsb2Nr
IGluIGludGVsZmJfY3JlYXRlIGZhaWx1cmUgcGF0aCB3aGVyZSBpdCBjYWxscwo+ID4gZHJtX2Zy
YW1lYnVmZmVyX3VucmVmZXJlbmNlLCB3aGljaCBncmFicyB0aGUgc3RydWN0IG11dGV4IGFuZAo+
ID4gaW50ZWxmYl9jcmVhdGUgd2FzIGFscmVhZHkgaG9sZGluZyBpdC4KPiA+IAo+ID4gdjI6Cj4g
PiAgICAqIFJlZm9ybWF0IGNvbW1pdCBtc2cgdG8gNzIgY2hhcnMuIChMdWthcyBXdW5uZXIpCj4g
PiAgICAqIEFkZCB0aGlyZCBmYWlsdXJlIG1vZGUuIChMdWthcyBXdW5uZXIpCj4gPiAKPiA+IHYz
Ogo+ID4gICAgKiBPbiBmYiBhbGxvYyBmYWlsdXJlLCB1bnJlZiBnZW0gb2JqZWN0IHdoZXJlIGl0
IGdldHMgcmVmZWQsCj4gPiAgICAgIGZpeCBkb3VibGUgdW5yZWYgaW4gc2VwYXJhdGUgY29tbWl0
LiAoVmlsbGUgU3lyasOkbMOkKQo+ID4gCj4gPiB2NDoKPiA+ICAgICogTG9jayBzdHJ1Y3QgbXV0
ZXggb24gdW5yZWYuIChDaHJpcyBXaWxzb24pCj4gPiAKPiA+IHY1Ogo+ID4gICAgKiBSZWJhc2Ug
b24gZHJtLWludGVsLW5pZ2h0bHkgMjAxNXktMDltLTA0ZC0wOGgtMTltLTM1cyBVVEMsCj4gPiAg
ICAgIHJlcGhyYXNlIGNvbW1pdCBtZXNzYWdlLiAoSmFuaSBOaWN1bGEpCj4gPiAKPiA+IFRlc3Rl
ZC1ieTogUGllcnJlIE1vcmVhdSA8cGllcnJlLm1vcnJvd0BmcmVlLmZyPgo+ID4gICAgIFtNQlAg
IDUsMyAyMDA5ICBudmlkaWEgOTQwME0gKyA5NjAwTSBHVCAgIHByZS1yZXRpbmFdCj4gPiBUZXN0
ZWQtYnk6IFBhdWwgSG9yZGlpZW5rbyA8cHZ0LmdvcmRAZ21haWwuY29tPgo+ID4gICAgIFtNQlAg
IDYsMiAyMDEwICBpbnRlbCBJTEsgKyBudmlkaWEgR1QyMTYgIHByZS1yZXRpbmFdCj4gPiBUZXN0
ZWQtYnk6IFdpbGxpYW0gQnJvd24gPHdpbGxpYW1AYmxhY2toYXRzLm5ldC5hdT4KPiA+ICAgICBb
TUJQICA4LDIgMjAxMSAgaW50ZWwgU05CICsgYW1kIHR1cmtzICAgICBwcmUtcmV0aW5hXQo+ID4g
VGVzdGVkLWJ5OiBMdWthcyBXdW5uZXIgPGx1a2FzQHd1bm5lci5kZT4KPiA+ICAgICBbTUJQICA5
LDEgMjAxMiAgaW50ZWwgSVZCICsgbnZpZGlhIEdLMTA3ICBwcmUtcmV0aW5hXQo+ID4gVGVzdGVk
LWJ5OiBCcnVubyBCaWVyYmF1bWVyIDxicnVub0BiaWVyYmF1bWVyLm5ldD4KPiA+ICAgICBbTUJQ
IDExLDMgMjAxMyAgaW50ZWwgSFNXICsgbnZpZGlhIEdLMTA3ICByZXRpbmFdCj4gPiAKPiA+IFNp
Z25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4g
PiBGaXhlczogNjBhNWNhMDE1ZmZkICgiZHJtL2k5MTU6IEFkZCBsb2NraW5nIGFyb3VuZAo+ID4g
ICAgIGZyYW1lYnVmZmVyX3JlZmVyZW5jZXMtLSIpCj4gPiBSZXBvcnRlZC1ieTogTHVrYXMgV3Vu
bmVyIDxsdWthc0B3dW5uZXIuZGU+Cj4gPiBbTHVrYXM6IENyZWF0ZSB2MyArIHY0ICsgdjUgYmFz
ZWQgb24gVHZydGtvJ3MgdjJdCj4gPiBTaWduZWQtb2ZmLWJ5OiBMdWthcyBXdW5uZXIgPGx1a2Fz
QHd1bm5lci5kZT4KPiA+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51
az4KPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t
Pgo+ID4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+
ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIHwgMjAgKysrKysrKysrKysrLS0t
LS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMo
LSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2
LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gPiBpbmRleCA5NjQ3NmQ3
Li5lZWUzMzA2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJk
ZXYuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+ID4gQEAg
LTExOSw3ICsxMTksNyBAQCBzdGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9o
ZWxwZXIgKmhlbHBlciwKPiA+ICB7Cj4gPiAgCXN0cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2ID0K
PiA+ICAJCWNvbnRhaW5lcl9vZihoZWxwZXIsIHN0cnVjdCBpbnRlbF9mYmRldiwgaGVscGVyKTsK
PiA+IC0Jc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmI7Cj4gPiArCXN0cnVjdCBkcm1fZnJhbWVi
dWZmZXIgKmZiID0gTlVMTDsKPiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGhlbHBlci0+
ZGV2Owo+ID4gIAlzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiBtb2RlX2NtZCA9IHt9Owo+ID4gIAlz
dHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+ID4gQEAgLTEzNyw2ICsxMzcsOCBAQCBz
dGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiA+
ICAJbW9kZV9jbWQucGl4ZWxfZm9ybWF0ID0gZHJtX21vZGVfbGVnYWN5X2ZiX2Zvcm1hdChzaXpl
cy0+c3VyZmFjZV9icHAsCj4gPiAgCQkJCQkJCSAgc2l6ZXMtPnN1cmZhY2VfZGVwdGgpOwo+ID4g
IAo+ID4gKwltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gPiArCj4gPiAgCXNpemUg
PSBtb2RlX2NtZC5waXRjaGVzWzBdICogbW9kZV9jbWQuaGVpZ2h0Owo+ID4gIAlzaXplID0gUEFH
RV9BTElHTihzaXplKTsKPiA+ICAJb2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9zdG9sZW4o
ZGV2LCBzaXplKTsKPiA+IEBAIC0xNTgsMTggKzE2MCwyMSBAQCBzdGF0aWMgaW50IGludGVsZmJf
YWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiA+ICAJcmV0ID0gaW50ZWxfcGlu
X2FuZF9mZW5jZV9mYl9vYmooTlVMTCwgZmIsIE5VTEwsIE5VTEwsIE5VTEwpOwo+ID4gIAlpZiAo
cmV0KSB7Cj4gPiAgCQlEUk1fRVJST1IoImZhaWxlZCB0byBwaW4gb2JqOiAlZFxuIiwgcmV0KTsK
PiA+IC0JCWdvdG8gb3V0X2ZiOwo+ID4gKwkJZ290byBvdXRfdW5yZWY7Cj4gPiAgCX0KPiA+ICAK
PiA+ICsJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gPiArCj4gPiAgCWlmYmRl
di0+ZmIgPSB0b19pbnRlbF9mcmFtZWJ1ZmZlcihmYik7Cj4gPiAgCj4gPiAgCXJldHVybiAwOwo+
ID4gIAo+ID4gLW91dF9mYjoKPiA+IC0JZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZShmYik7Cj4gPiAg
b3V0X3VucmVmOgo+ID4gIAlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsK
PiAKPiBJZiBmYiBpbml0IHN1Y2NlZWRlZCBpdCB0b29rIG92ZXIgdGhlIHJlZiwgbm8/IFNvIGRy
bV9mcmFtZWJ1ZmZlcl9yZW1vdmUoKQo+IHdpbGwgbm93IGF0dGVtcHQgdG8gdW5yZWYgb25lIHRv
byBtYW55IHRpbWVzLgo+IAo+IFRoaXMgdGFraW5nIG92ZXIgcmVmcyBzdHVmZiBpcyBjb25mdXNp
bmcuIE1heWJlIGl0IHdvdWxkIGJlIGJldHRlciBpZgo+IGV2ZXJ5b25lIGp1c3QgdG9vayBhbiBl
eHRyYSByZWYgd2hlbiB0aGV5IHN0YXNoIHRoZSBvYmogcG9pbnRlcgo+IHNvbWV3aGVyZSwgYW5k
IGV2ZXJ5b25lIHdvdWxkIHRoZW4gYWx3YXlzIHJlbGVhc2Ugd2hhdGV2ZXIgcmVmIHRoZXkgb3du
Cj4gYW5kIG5vIGxvbmdlciBuZWVkLgo+IAo+ID4gIG91dDoKPiA+ICsJbXV0ZXhfdW5sb2NrKCZk
ZXYtPnN0cnVjdF9tdXRleCk7Cj4gPiArCWlmIChmYikKPiA+ICsJCWRybV9mcmFtZWJ1ZmZlcl9y
ZW1vdmUoZmIpOwo+ID4gIAlyZXR1cm4gcmV0Owo+ID4gIH0KPiA+ICAKCkhtLCB3aHkgZG8geW91
IHRoaW5rIHdlIHVucmVmIG9uZSB0b28gbWFueSB0aW1lcz8KCkEgYml0IGZ1cnRoZXIgdXAgaW4g
dGhpcyBmdW5jdGlvbiB3ZSBjYWxsIF9faW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlKCkKd2hpY2gg
c2V0cyB0aGUgcmVmY291bnQgdG8gMS4gKEl0IGNhbGxzIGludGVsX2ZyYW1lYnVmZmVyX2luaXQo
KSwgd2hpY2gKY2FsbHMgZHJtX2ZyYW1lYnVmZmVyX2luaXQoKSwgd2hpY2ggY2FsbHMga3JlZl9p
bml0KCZmYi0+cmVmY291bnQpLikKClNvIGlmIGludGVsX3Bpbl9hbmRfZmVuY2VfZmJfb2JqKCkg
ZmFpbHMsIHdlIGRvIG5lZWQgdG8gdW5yZWZlcmVuY2UgYW5kCnRlYXIgZG93biB0aGUgZmIuIFRo
dXMsIGRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUoKSBzZWVtcyByaWdodCBoZXJlIHRvIG1lLgoKSG93
ZXZlciwgYmVjYXVzZSBvZiB5b3VyIG9iamVjdGlvbiBJJ3ZlIG5vdGljZWQgbm93IHRoYXQgImlm
IChmYikiIHNlZW1zCnRvIGJlIHdyb25nLCBJIHRoaW5rIHRoaXMgc2hvdWxkIGJlICJpZiAoIUlT
X0VSUl9PUl9OVUxMKGZiKSkiLgoKQmVjYXVzZSBpZiBfX2ludGVsX2ZyYW1lYnVmZmVyX2NyZWF0
ZSgpIGZhaWxlZCwgZmIgd2lsbCBiZSBhIFBUUl9FUlIoKSwKc28gbm90IG51bGwsIGFuZCB3ZSdk
IGNhbGwgZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZSgpIG9uIHRoaXMuIElzIHRoYXQKd2hhdCB5b3Ug
bWVhbnQ/CgoKPiA+IEBAIC0xODcsOCArMTkyLDYgQEAgc3RhdGljIGludCBpbnRlbGZiX2NyZWF0
ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ID4gIAlpbnQgc2l6ZSwgcmV0Owo+ID4g
IAlib29sIHByZWFsbG9jID0gZmFsc2U7Cj4gPiAgCj4gPiAtCW11dGV4X2xvY2soJmRldi0+c3Ry
dWN0X211dGV4KTsKPiA+IC0KPiA+ICAJaWYgKGludGVsX2ZiICYmCj4gPiAgCSAgICAoc2l6ZXMt
PmZiX3dpZHRoID4gaW50ZWxfZmItPmJhc2Uud2lkdGggfHwKPiA+ICAJICAgICBzaXplcy0+ZmJf
aGVpZ2h0ID4gaW50ZWxfZmItPmJhc2UuaGVpZ2h0KSkgewo+ID4gQEAgLTIwMyw3ICsyMDYsNyBA
QCBzdGF0aWMgaW50IGludGVsZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIs
Cj4gPiAgCQlEUk1fREVCVUdfS01TKCJubyBCSU9TIGZiLCBhbGxvY2F0aW5nIGEgbmV3IG9uZVxu
Iik7Cj4gPiAgCQlyZXQgPSBpbnRlbGZiX2FsbG9jKGhlbHBlciwgc2l6ZXMpOwo+ID4gIAkJaWYg
KHJldCkKPiA+IC0JCQlnb3RvIG91dF91bmxvY2s7Cj4gPiArCQkJcmV0dXJuIHJldDsKPiA+ICAJ
CWludGVsX2ZiID0gaWZiZGV2LT5mYjsKPiA+ICAJfSBlbHNlIHsKPiA+ICAJCURSTV9ERUJVR19L
TVMoInJlLXVzaW5nIEJJT1MgZmJcbiIpOwo+ID4gQEAgLTIxNSw2ICsyMTgsOCBAQCBzdGF0aWMg
aW50IGludGVsZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gPiAgCW9i
aiA9IGludGVsX2ZiLT5vYmo7Cj4gPiAgCXNpemUgPSBvYmotPmJhc2Uuc2l6ZTsKPiA+ICAKPiA+
ICsJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ID4gKwo+IAo+IEknbSB0aGlua2lu
ZyB3ZSB3b24ndCBldmVuIG5lZWQgdGhlIGxvY2sgaGVyZSBhbnltb3JlLiBCdXQgbWF5YmUgSSdt
Cj4gbWlzc2luZyBzb21ldGhpbmcuCj4gCj4gPiAgCWluZm8gPSBkcm1fZmJfaGVscGVyX2FsbG9j
X2ZiaShoZWxwZXIpOwo+ID4gIAlpZiAoSVNfRVJSKGluZm8pKSB7Cj4gPiAgCQlyZXQgPSBQVFJf
RVJSKGluZm8pOwo+ID4gQEAgLTI3Niw3ICsyODEsNiBAQCBvdXRfZGVzdHJveV9mYmk6Cj4gPiAg
b3V0X3VucGluOgo+ID4gIAlpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbihvYmopOwo+ID4gIAlk
cm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiAKPiBBbmQgdGhpcyByZWYg
d2UgZG9uJ3Qgb3duIGVpdGhlciBBRkFJQ1MuCgpXaHk/IFdlIGRpZCBjYWxsIGludGVsZmJfYWxs
b2MoKSBhYm92ZSwgc28gaWYgc29tZXRoaW5nIHN1YnNlcXVlbnRseQpnb2VzIHdyb25nLCB3ZSBu
ZWVkIHRvIHJldmVydCB0aGUgc3RlcHMgdGhhdCBpbnRlbGZiX2FsbG9jKCkgY2FycmllZApvdXQu
IFRoZSBkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgpIHRoZXJlZm9yZSBzZWVtcyByaWdodCBo
ZXJlIHRvIG1lLgoKSG93ZXZlciBJJ20gcHV6emxlZCB3aHkgd2UgZG9uJ3QgY2FsbCBkcm1fZnJh
bWVidWZmZXJfcmVtb3ZlKCkgdW5kZXIKdGhlIG91dF91bnBpbjogbGFiZWwuIEFyZW4ndCB3ZSBs
ZWFraW5nIGEgZnJhbWVidWZmZXIgaGVyZSB3aXRob3V0IHRoYXQ/CgpNYXliZSB5b3UncmUgcmVm
ZXJyaW5nIHRvIHRoZSBmYWN0IHRoYXQgdGhpcyBmdW5jdGlvbiBlaXRoZXIgaW5oZXJpdHMKdGhl
IEJJT1MgZmIgb3IgY3JlYXRlcyBhIG5ldyBmYiB3aXRoIGludGVsZmJfYWxsb2MoKS4gSSdtIG5v
dCBzdXJlIGlmCnRoZSBjbGVhbnVwIG9uIGVycm9yIGlzIGlkZW50aWNhbCBpbiB0aGVzZSB0d28g
Y2FzZXMuIE1heWJlIHlvdSBtZWFudAp0aGF0IHdlIGRvbid0IG93biB0aGUgcmVmIGluIHRoZSBj
YXNlIHRoYXQgdGhlIGZiIHdhcyBpbmhlcml0ZWQgZnJvbQpCSU9TPwoKCkJlc3QgcmVnYXJkcywK
Ckx1a2FzCgo+IAo+ID4gLW91dF91bmxvY2s6Cj4gPiAgCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1
Y3RfbXV0ZXgpOwo+ID4gIAlyZXR1cm4gcmV0Owo+ID4gIH0KPiA+IC0tIAo+ID4gMi4xLjAKPiAK
PiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n
ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp
bG1hbi9saXN0aW5mby9pbnRlbC1nZngK