From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/fb-helper: Fix fb refcounting in pan_display_atomic Date: Fri, 16 Oct 2015 19:48:37 +0300 Message-ID: <20151016164837.GW26517@intel.com> References: <1445012594-25988-1-git-send-email-daniel.vetter@ffwll.ch> <1445012594-25988-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1445012594-25988-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMTYsIDIwMTUgYXQgMDY6MjM6MTRQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBJbgo+IAo+IGNvbW1pdCBiYmIxZTUyNDAyYjJhMjg4YjA5YWUzN2U4MTgyNTk5OTMx YzdlOWRmCj4gQXV0aG9yOiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5jb20+Cj4gRGF0ZTog ICBUdWUgQXVnIDI1IDE1OjM1OjU4IDIwMTUgLTA0MDAKPiAKPiAgICAgZHJtL2ZiLWhlbHBlcjog YXRvbWljIHJlc3RvcmVfZmJkZXZfbW9kZSgpLi4KPiAKPiB3ZSd2ZSBmb3Jnb3R0ZW4gdG8gZG8g dGhlIHBsYW5lLT5vbGRfZmIgcmVmY291bnQgZGFuY2UgZm9yCj4gcGFuX2Rpc3BsYXlfYXRvbWlj LCB3aGljaCBjYW4gcmVzdWx0IGluIHJlZmNvdW50IGxlYWtzIGlmIHRoZSBjdXJyZW50Cj4gY29u ZmlndXJhdGlvbiBpcyBub3QgZnJvbSBmYmNvbi4gV2hpY2ggYXBwYXJlbnRseSBjYW4gaGFwcGVu IHdoZW4KPiB2dC1zd2l0Y2hpbmcgLSBmYmNvbiBkb2VzIGEgcGFuIGZpcnN0IGJlZm9yZSBhIHNl dF9wYXIuCj4gCj4gT0NELWFsaWduIGZ1bmN0aW9uIHBhcmFtZXRlcnMgd2hpbGUgYXQgaXQuCj4g Cj4gQ2M6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4KPiBDYzogUm9kcmlnbyBWaXZp IDxyb2RyaWdvLnZpdmlAZ21haWwuY29tPgo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRl c2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD05MjQ4Mwo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2ZiX2hlbHBlci5jIHwgMjcgKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gIDEgZmls ZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9mYl9oZWxwZXIuYwo+IGluZGV4IDBhYzBmY2M5YjBkMi4uYjJjZjI4ZGQ5MGZlIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gQEAgLTEyNDksNiArMTI0OSw4IEBAIHJldHJ5Ogo+ICAK PiAgCQltb2RlX3NldCA9ICZmYl9oZWxwZXItPmNydGNfaW5mb1tpXS5tb2RlX3NldDsKPiAgCj4g KwkJbW9kZV9zZXQtPmNydGMtPnByaW1hcnktPm9sZF9mYiA9IG1vZGVfc2V0LT5jcnRjLT5wcmlt YXJ5LT5mYjsKPiArCj4gIAkJbW9kZV9zZXQtPnggPSB2YXItPnhvZmZzZXQ7Cj4gIAkJbW9kZV9z ZXQtPnkgPSB2YXItPnlvZmZzZXQ7Cj4gIAo+IEBAIC0xMjY0LDEzICsxMjY2LDM0IEBAIHJldHJ5 Ogo+ICAJaW5mby0+dmFyLnhvZmZzZXQgPSB2YXItPnhvZmZzZXQ7Cj4gIAlpbmZvLT52YXIueW9m ZnNldCA9IHZhci0+eW9mZnNldDsKPiAgCj4gLQlyZXR1cm4gMDsKPiAgCj4gIGZhaWw6CgpUaW1l IHRvIHJlbmFtZSB0aGUgbGFiZWwgdG9vPwoKPiArCWZvcihpID0gMDsgaSA8IGZiX2hlbHBlci0+ Y3J0Y19jb3VudDsgaSsrKSB7Cj4gKwkJc3RydWN0IGRybV9tb2RlX3NldCAqbW9kZV9zZXQ7Cj4g KwkJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gKwo+ICsJCW1vZGVfc2V0ID0gJmZiX2hlbHBl ci0+Y3J0Y19pbmZvW2ldLm1vZGVfc2V0Owo+ICsJCXBsYW5lID0gbW9kZV9zZXQtPmNydGMtPnBy aW1hcnk7Cj4gKwo+ICsJCWlmIChyZXQgPT0gMCkgewo+ICsJCQlzdHJ1Y3QgZHJtX2ZyYW1lYnVm ZmVyICpuZXdfZmIgPSBwbGFuZS0+c3RhdGUtPmZiOwo+ICsKPiArCQkJaWYgKG5ld19mYikKPiAr CQkJCWRybV9mcmFtZWJ1ZmZlcl9yZWZlcmVuY2UobmV3X2ZiKTsKPiArCQkJcGxhbmUtPmZiID0g bmV3X2ZiOwo+ICsJCQlwbGFuZS0+Y3J0YyA9IHBsYW5lLT5zdGF0ZS0+Y3J0YzsKPiArCj4gKwkJ CWlmIChwbGFuZS0+b2xkX2ZiKQo+ICsJCQkJZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlKHBs YW5lLT5vbGRfZmIpOwo+ICsJCX0KPiArCQlwbGFuZS0+b2xkX2ZiID0gTlVMTDsKPiArCX0KPiAr Cj4gIAlpZiAocmV0ID09IC1FREVBRExLKQo+ICAJCWdvdG8gYmFja29mZjsKPiAgCj4gLQlkcm1f YXRvbWljX3N0YXRlX2ZyZWUoc3RhdGUpOwo+ICsJaWYgKHJldCAhPSAwKQo+ICsJCWRybV9hdG9t aWNfc3RhdGVfZnJlZShzdGF0ZSk7Cj4gIAo+ICAJcmV0dXJuIHJldDsKPiAgCj4gLS0gCj4gMi41 LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK