From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: Only call commit_planes when there are things to commit.
Date: Mon, 19 Oct 2015 11:38:51 +0200 [thread overview]
Message-ID: <20151019093850.GR13786@phenom.ffwll.local> (raw)
In-Reply-To: <20151016124737.GP26517@intel.com>
On Fri, Oct 16, 2015 at 03:47:37PM +0300, Ville Syrjälä wrote:
> On Wed, Sep 23, 2015 at 04:29:39PM +0200, Maarten Lankhorst wrote:
> > The atomic helpers set planes_changed on a crtc_state if there is
> > any plane_state bound to that crtc. If there's none and there is
> > no pipe update required the crtc has nothing to update, so vblank
> > evasion can be skipped.
> >
> > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index f64ea430b976..9754ee2bb37c 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -13146,7 +13146,8 @@ static int intel_atomic_commit(struct drm_device *dev,
> > if (!modeset)
> > intel_pre_plane_update(intel_crtc);
> >
> > - if (crtc->state->active)
> > + if (crtc->state->active &&
> > + (crtc->state->planes_changed || update_pipe))
> > drm_atomic_helper_commit_planes_on_crtc(crtc_state);
> >
> > if (put_domains)
>
> Series lgtm
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
All four merged to dinq, thanks.
-Daniel
>
> > --
> > 2.1.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-10-19 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 14:29 [PATCH 0/4] Remainder of 'Nuke legacy state' patch series Maarten Lankhorst
2015-09-23 14:29 ` [PATCH 1/4] drm/i915: Update legacy primary state outside the commit hook, v2 Maarten Lankhorst
2015-09-23 14:29 ` [PATCH 2/4] drm/i915: Only commit active planes when updating planes during reset Maarten Lankhorst
2015-09-23 14:29 ` [PATCH 3/4] drm/i915: Only run commit when crtc is active, v2 Maarten Lankhorst
2015-09-23 14:29 ` [PATCH 4/4] drm/i915: Only call commit_planes when there are things to commit Maarten Lankhorst
2015-10-16 12:47 ` Ville Syrjälä
2015-10-19 9:38 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019093850.GR13786@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox