From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915/guc: Fix a false alert of memory leak when free LRC Date: Tue, 20 Oct 2015 09:45:37 +0200 Message-ID: <20151020074537.GT13786@phenom.ffwll.local> References: <1445292346-7693-1-git-send-email-yu.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 638A96EB06 for ; Tue, 20 Oct 2015 00:45:41 -0700 (PDT) Received: by wicfv8 with SMTP id fv8so15197623wic.0 for ; Tue, 20 Oct 2015 00:45:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1445292346-7693-1-git-send-email-yu.dai@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: yu.dai@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTksIDIwMTUgYXQgMDM6MDU6NDZQTSAtMDcwMCwgeXUuZGFpQGludGVsLmNv bSB3cm90ZToKPiBGcm9tOiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiAKPiBUaGVyZSBp cyBhIG1lbW9yeSBsZWFrIHdhcm5pbmcgbWVzc2FnZSBmcm9tIGk5MTVfZ2VtX2NvbnRleHRfY2xl YW4KPiB3aGVuIEd1QyBzdWJtaXNzaW9uIGlzIGVuYWJsZWQuIFRoZSByZWFzb24gaXMgdGhhdCB0 aGUgcmVxdWVzdCAoc28KPiB0aGUgTFJDIGFzc29jaWF0ZWQgd2l0aCBpdCkgaXMgZnJlZWQgZWFy bHkgdGhhbiBtb3ZpbmcgdGhlIHZtYSBsaXN0Cj4gdG8gaW5hY3RpdmUuIFdoZW4gcmV0aXJlIGEg Z2VtIG9iamVjdCwgdGhpcyBwYXRjaCBtb3ZlcyBpdHMgdm1hCj4gbGlzdCB0byBpbmFjdGl2ZSBm aXJzdCB0byBhdm9pZCB0aGUgZmFsc2UgYWxlcnQgb2YgbWVtb3J5IGxlYWsuCj4gCj4gV2UgYXJl IG5vdCBzZWVpbmcgdGhpcyBpbiBFeGVjTGlzdCAobm9uLUd1QykgbW9kZSBiZWNhdXNlIHRoZSBn ZW0KPiByZXF1ZXN0IGlzIG1vdmVkIHRvIGV4ZWNsaXN0X3JldGlyZWRfcmVxX2xpc3QgcXVldWUu IFRoZSBtYW5hZ2VtZW50Cj4gb2YgdGhpcyBxdWV1ZSwgdGhlcmVmb3JlIGZyZWUgb2YgTFJDLCBo YXBwZW5zIGFmdGVyIHJldGlyZSBvZiB2bWEKPiBsaXN0IChpOTE1X2dlbV9yZXRpcmVfcmVxdWVz dHNfcmluZykuCgpJbnN0ZWFkIG9mIGhhY2tpbmcgdXAgdGhlIGNvcmUgYWN0aXZlIHRyYWNraW5n IGNvZGUgY2FuIHdlIGp1c3QgZml4IGxyYwpjb250ZXh0IG9iamVjdCB0cmFja2luZyBpbnN0ZWFk PyBUaGlzIHBhdGNoIGhlcmUgc2VlbXMgdG8gYmUgc3VwcmVtZWx5CmZyYWdpbGUsIGFuZCBJIHJl YWxseSBkb24ndCB3YW50IGl0LgotRGFuaWVsCgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFsZXggRGFp IDx5dS5kYWlAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jIHwgMjkgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDE2IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYwo+IGluZGV4IDdkNmIwYzguLmE5MDNkNDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPiBAQCAtMjM3NywyOCArMjM3NywzMSBAQCBpOTE1X2dlbV9vYmplY3RfcmV0aXJlX19yZWFk KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosIGludCByaW5nKQo+ICAJUlFfQlVHX09O KG9iai0+bGFzdF9yZWFkX3JlcVtyaW5nXSA9PSBOVUxMKTsKPiAgCVJRX0JVR19PTighKG9iai0+ YWN0aXZlICYgKDEgPDwgcmluZykpKTsKPiAgCj4gKwlvYmotPmFjdGl2ZSAmPSB+KDEgPDwgcmlu Zyk7Cj4gKwlpZiAoIW9iai0+YWN0aXZlKSB7Cj4gKwkJLyogQnVtcCBvdXIgcGxhY2Ugb24gdGhl IGJvdW5kIGxpc3QgdG8ga2VlcCBpdCByb3VnaGx5IGluIExSVQo+ICsJCSAqIG9yZGVyIHNvIHRo YXQgd2UgZG9uJ3Qgc3RlYWwgZnJvbSByZWNlbnRseSB1c2VkIGJ1dCBpbmFjdGl2ZQo+ICsJCSAq IG9iamVjdHMgKHVubGVzcyB3ZSBhcmUgZm9yY2VkIHRvIG9mYyEpCj4gKwkJICovCj4gKwkJbGlz dF9tb3ZlX3RhaWwoJm9iai0+Z2xvYmFsX2xpc3QsCj4gKwkJCQkmdG9faTkxNShvYmotPmJhc2Uu ZGV2KS0+bW0uYm91bmRfbGlzdCk7Cj4gKwo+ICsJCWxpc3RfZm9yX2VhY2hfZW50cnkodm1hLCAm b2JqLT52bWFfbGlzdCwgdm1hX2xpbmspIHsKPiArCQkJaWYgKCFsaXN0X2VtcHR5KCZ2bWEtPm1t X2xpc3QpKQo+ICsJCQkJbGlzdF9tb3ZlX3RhaWwoJnZtYS0+bW1fbGlzdCwKPiArCQkJCQkJJnZt YS0+dm0tPmluYWN0aXZlX2xpc3QpOwo+ICsJCX0KPiArCX0KPiArCj4gIAlsaXN0X2RlbF9pbml0 KCZvYmotPnJpbmdfbGlzdFtyaW5nXSk7Cj4gIAlpOTE1X2dlbV9yZXF1ZXN0X2Fzc2lnbigmb2Jq LT5sYXN0X3JlYWRfcmVxW3JpbmddLCBOVUxMKTsKPiAgCj4gIAlpZiAob2JqLT5sYXN0X3dyaXRl X3JlcSAmJiBvYmotPmxhc3Rfd3JpdGVfcmVxLT5yaW5nLT5pZCA9PSByaW5nKQo+ICAJCWk5MTVf Z2VtX29iamVjdF9yZXRpcmVfX3dyaXRlKG9iaik7Cj4gIAo+IC0Jb2JqLT5hY3RpdmUgJj0gfigx IDw8IHJpbmcpOwo+ICAJaWYgKG9iai0+YWN0aXZlKQo+ICAJCXJldHVybjsKPiAgCj4gLQkvKiBC dW1wIG91ciBwbGFjZSBvbiB0aGUgYm91bmQgbGlzdCB0byBrZWVwIGl0IHJvdWdobHkgaW4gTFJV IG9yZGVyCj4gLQkgKiBzbyB0aGF0IHdlIGRvbid0IHN0ZWFsIGZyb20gcmVjZW50bHkgdXNlZCBi dXQgaW5hY3RpdmUgb2JqZWN0cwo+IC0JICogKHVubGVzcyB3ZSBhcmUgZm9yY2VkIHRvIG9mYyEp Cj4gLQkgKi8KPiAtCWxpc3RfbW92ZV90YWlsKCZvYmotPmdsb2JhbF9saXN0LAo+IC0JCSAgICAg ICAmdG9faTkxNShvYmotPmJhc2UuZGV2KS0+bW0uYm91bmRfbGlzdCk7Cj4gLQo+IC0JbGlzdF9m b3JfZWFjaF9lbnRyeSh2bWEsICZvYmotPnZtYV9saXN0LCB2bWFfbGluaykgewo+IC0JCWlmICgh bGlzdF9lbXB0eSgmdm1hLT5tbV9saXN0KSkKPiAtCQkJbGlzdF9tb3ZlX3RhaWwoJnZtYS0+bW1f bGlzdCwgJnZtYS0+dm0tPmluYWN0aXZlX2xpc3QpOwo+IC0JfQo+IC0KPiAgCWk5MTVfZ2VtX3Jl cXVlc3RfYXNzaWduKCZvYmotPmxhc3RfZmVuY2VkX3JlcSwgTlVMTCk7Cj4gIAlkcm1fZ2VtX29i amVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiAgfQo+IC0tIAo+IDEuOS4xCj4gCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=