From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 14:07:16 +0300 Message-ID: <20151020110716.GF26517@intel.com> References: <1444212083-3302-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20151019182036.GD26517@intel.com> <20151020074225.GS13786@phenom.ffwll.local> <56260432.1030007@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id EDF656E1D6 for ; Tue, 20 Oct 2015 04:07:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <56260432.1030007@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjAsIDIwMTUgYXQgMTA6MDY6NThBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMjAvMTAvMTUgMDg6NDIsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiBP biBNb24sIE9jdCAxOSwgMjAxNSBhdCAwOToyMDozNlBNICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qg d3JvdGU6Cj4gPj4gT24gV2VkLCBPY3QgMDcsIDIwMTUgYXQgMTE6MDE6MjNBTSArMDEwMCwgVHZy dGtvIFVyc3VsaW4gd3JvdGU6Cj4gPj4+IEZyb206IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJz dWxpbkBpbnRlbC5jb20+Cj4gPj4+Cj4gPj4+IFByZXZpb3VzbHkgcm90YXRpb24gd2FzIGlnbm9y ZWQgYW5kIHdyb25nIHN0cmlkZSBwcm9ncmFtbWVkCj4gPj4+IGludG8gdGhlIHBsYW5lIHJlZ2lz dGVycyByZXN1bHRpbmcgaW4gYSBjb3JydXB0IGltYWdlIG9uIHNjcmVlbi4KPiA+Pj4KPiA+Pj4g U2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiA+Pj4gQ2M6IFNvbmlrYSBKaW5kYWwgPHNvbmlrYS5qaW5kYWxAaW50ZWwuY29tPgo+ID4+PiAt LS0KPiA+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxNiArKysr KysrKysrKystLS0tCj4gPj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDQg ZGVsZXRpb25zKC0pCj4gPj4+Cj4gPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK PiA+Pj4gaW5kZXggNTM5YzM3MzdlODIzLi42MzI4Nzg4MTkzZTQgMTAwNjQ0Cj4gPj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+Pj4gQEAgLTExMTI2LDkgKzExMTI2LDEw IEBAIHN0YXRpYyB2b2lkIHNrbF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVsX2NydGMgKmludGVs X2NydGMpCj4gPj4+ICAgewo+ID4+PiAgIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50ZWxf Y3J0Yy0+YmFzZS5kZXY7Cj4gPj4+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPj4+ICsJc3RydWN0IGRybV9wbGFuZSAqcGxhbmUgPSBp bnRlbF9jcnRjLT5iYXNlLnByaW1hcnk7Cj4gPj4+ICAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIg KmZiID0gaW50ZWxfY3J0Yy0+YmFzZS5wcmltYXJ5LT5mYjsKPiA+Pj4gICAJY29uc3QgZW51bSBw aXBlIHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+ID4+PiAtCXUzMiBjdGwsIHN0cmlkZTsKPiA+ Pj4gKwl1MzIgY3RsLCBzdHJpZGUsIHRpbGVfaGVpZ2h0Owo+ID4+Pgo+ID4+PiAgIAljdGwgPSBJ OTE1X1JFQUQoUExBTkVfQ1RMKHBpcGUsIDApKTsKPiA+Pj4gICAJY3RsICY9IH5QTEFORV9DVExf VElMRURfTUFTSzsKPiA+Pj4gQEAgLTExMTUyLDkgKzExMTUzLDE2IEBAIHN0YXRpYyB2b2lkIHNr bF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMpCj4gPj4+ICAgCSAq IFRoZSBzdHJpZGUgaXMgZWl0aGVyIGV4cHJlc3NlZCBhcyBhIG11bHRpcGxlIG9mIDY0IGJ5dGVz IGNodW5rcyBmb3IKPiA+Pj4gICAJICogbGluZWFyIGJ1ZmZlcnMgb3IgaW4gbnVtYmVyIG9mIHRp bGVzIGZvciB0aWxlZCBidWZmZXJzLgo+ID4+PiAgIAkgKi8KPiA+Pj4gLQlzdHJpZGUgPSBmYi0+ cGl0Y2hlc1swXSAvCj4gPj4+IC0JCSBpbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGRldiwgZmIt Pm1vZGlmaWVyWzBdLAo+ID4+PiAtCQkJCQkgICBmYi0+cGl4ZWxfZm9ybWF0KTsKPiA+Pj4gKwlp ZiAoaW50ZWxfcm90YXRpb25fOTBfb3JfMjcwKHBsYW5lLT5zdGF0ZS0+cm90YXRpb24pKSB7Cj4g Pj4+ICsJCS8qIHN0cmlkZSA9IFN1cmZhY2UgaGVpZ2h0IGluIHRpbGVzICovCj4gPj4+ICsJCXRp bGVfaGVpZ2h0ID0gaW50ZWxfdGlsZV9oZWlnaHQoZGV2LCBmYi0+cGl4ZWxfZm9ybWF0LAo+ID4+ PiArCQkJCQkJZmItPm1vZGlmaWVyWzBdLCAwKTsKPiA+Pj4gKwkJc3RyaWRlID0gRElWX1JPVU5E X1VQKGZiLT5oZWlnaHQsIHRpbGVfaGVpZ2h0KTsKPiA+Pj4gKwl9IGVsc2Ugewo+ID4+PiArCQlz dHJpZGUgPSBmYi0+cGl0Y2hlc1swXSAvCj4gPj4+ICsJCQkJaW50ZWxfZmJfc3RyaWRlX2FsaWdu bWVudChkZXYsIGZiLT5tb2RpZmllclswXSwKPiA+Pj4gKwkJCQkJCQkgIGZiLT5waXhlbF9mb3Jt YXQpOwo+ID4+PiArCX0KPiA+Pgo+ID4+IEkgd2FzIHdvbmRlcmluZyB3aHkgd2UgYXJlIGFsbG93 aW5nIHN0cmlkZSBjaGFuZ2VzIGR1cmluZyBwYWdlIGZsaXAsIGJ1dAo+ID4+IGFmdGVyIGxvb2tp bmcgYXQgdGhlIGhpc3RvcnkgaXQgc2VlbXMgd2UgYXJlIG5vdC4gVGhlIHJlYXNvbiBmb3IKPiA+ PiB1cGRhdGluZyB0aGUgc3RyaWRlIHJlZ2lzdGVyIGlzIHRoZSBmYWN0IHRoYXQgdGhlIHVuaXRz IHdlIHNwZWNpZnkgaXQKPiA+PiBpbiBjaGFuZ2UgYmV0d2VlbiBkaWZmZXJlbnQgdGlsaW5nIG1v ZGVzIG9uIFNLTCsuIFdlIHN0aWxsIHJlamVjdCBhY3R1YWwKPiA+PiBzdHJpZGUgY2hhbmdlcyBk dXJpbmcgcGFnZSBmbGlwLCB3aGljaCBpcyBnb29kIGJlY2F1c2UgYWxsb3dpbmcgaXQgd291bGQK PiA+PiBjYXVzZSBwcm9ibGVtcyBmb3IgbXkgZmItPm9mZnNldHNbXSBzdHVmZiBzaW5jZSB0aGUg aW50ZXJwcmV0YXRpb24gb2YgdGhlCj4gPj4gbGluZWFyIG9mZnNldCB3b3VsZCBjaGFuZ2Ugd2l0 aCB0aGUgc3RyaWRlLgo+ID4+Cj4gPj4gV2UgZG8gYWxsb3cgY2hhbmdlcyB0byB0aGUgcm90YXRl ZCBzdHJpZGUgdGhvdWdoIHNpbmNlIHdlIGRvbid0IHJlamVjdAo+ID4+IGNoYW5nZXMgdG8gdGhl IGZiIGhlaWdodC4gSSB0aGluayBJIG5lZWQgdG8gZHJhdyBzb21lIHBpY3R1cmVzIGJlZm9yZSBJ Cj4gPj4gY2FuIHNheSBmb3Igc3VyZSB3aGV0aGVyIHRoYXQgY2FuIGNhdXNlIHByb2JsZW1zIG9y IG5vdC4gQnV0IHdlIGNhCj4gPj4gbGVhdmUgdGhhdCBmb3IgYW5vdGhlciBwYXRjaCBpZiBpdCB0 dXJucyBvdXQgdG8gbmVlZCBoYW5kbGluZy4KPiA+Pgo+ID4+IE9uZSB0aGluZyB0aGF0J3MgZG9k Z3kgaGVyZSBpcyB0aGUgcGxhbmUtPnN0YXRlLT5yb3RhdGlvbiBjaGVjay4gSQo+ID4+IHRoaW5r IGN1cnJlbnRseSB3ZSB3YWl0IGZvciBwZW5kaW5nIGZsaXBzIGR1cmluZyB0aGUgYXRvbWljIGNv bW1pdAo+ID4+IHBoYXNlIGFmdGVyIHdlJ3ZlIHN3YXBwZWQgdGhlIHN0YXRlLiBTbyB0aGlzIG1h eSBlbmQgdXAgdXNpbmcgdGhlCj4gPj4gd3Jvbmcgcm90YXRpb24gc2V0dGluZy4gSXQgd291bGQg YmUgYW4gZXZlbiBiaWdnZXIgcHJvYmxlbSBpZiB3ZQo+ID4+IGFscmVhZHkgYWxsb3dlZCBxdWV1 ZWluZyB1cCBvciByZXBsYWNlaW5nIHBlbmRpbmcgcGxhbmUgdXBkYXRlcy4gSQo+ID4+IHN1cHBv c2UgdGhlIHByaW1hcnktPmZiIHRoaW5nIGRvZXNuJ3Qgc3VmZmVyIGZyb20gdGhpcyBwcm9ibGVt IGJlY2F1c2UKPiA+PiB3ZSBzd2FwIHRoYXQgcG9pbnRlciBvbmx5IGFmdGVyIHdlJ3ZlIHdhaXRl ZCBmb3IgcGVuZGluZyBmbGlwcy4KPiA+Cj4gPiBDdXJyZW50IHJ1bGUgaXMgdGhhdCBwYWdlZmxp cCBkb2Vzbid0IGFsbG93IGFueSBjaGFuZ2UgaW4gYW55IG1ldGFkYXRhLgo+ID4gVGhlcmUncyBz b21lIG1pbm9yIGV4Y2VwdGlvbiB0aGF0IG9uIHNvbWUgcGxhdGZvcm1zIHdlIGNhbiBjaGFuZ2Ug dGhlCj4gPiB0aWxpbmcgYmVjYXVzZSBzb21lb25lIGFza2VkIGZvciB0aGF0IHNwZWNpZmljYWxs eSBhbmQgaXQncyBwb3NzaWJsZS4KPiA+Cj4gPiBhdG9taWMgZmxpcHMgd2lsbCBiZSBhYmxlIHRv IGNvcGUgd2l0aCB0aGlzLiBCdXQgZm9yIGxlZ2FjeSBwYWdlZmxpcHMgaW1vCj4gPiByZWplY3Qg ZXZlcnl0aGluZyBhZ2dyZXNzaXZlbHkgdGhhdCBjaGFuZ2VzIG1ldGFkYXRhIChzdHJpZGUsIHRp bGluZywKPiA+IHJvdGF0aW9uKS4KPiAKPiBJIGFtIG5vdCBzdXJlIHdoYXQgaXMgdGhlIGNvbmNs dXNpb24uIFRvIHJlLWl0ZXJhdGUsIGlkZWEgaXMgbm90IHRvIAo+IGFsbG93IHJvdGF0aW9uIGNo YW5nZXMgYmV0d2VlbiBwYWdlIGZsaXBzLCBqdXN0IHRvIHByb2dyYW0gUExBTkVfU1RSSURFIAo+ IGFjY29yZGluZ2x5LCB3aGVuIHJvdGF0aW9uIGlzIGFscmVhZHkgZW5hYmxlZC4gU2luY2Ugb3Ro ZXJ3aXNlIHBhZ2UgZmxpcCAKPiB3aWxsIGNhbGN1bGF0ZSBpdCBpbmNvcnJlY3RseS4KPiAKPiBJ IHRob3VnaCBWaWxsZSB3YXMgcmFpc2luZyB0d28gY29uY2VybnM6Cj4gCj4gMS4gV2lsbCB0aGUg cGxhbmUgc3RhdGUgYmUgc3dhcHBlZCBmcm9tIHVuZGVyIHRoZSBwZW5kaW5nIHBhZ2UgZmxpcHMg Cj4gcHJlbWF0dXJlbHk/CgpUaGUgYW5zd2VyIGlzIHllcy4KCj4gCj4gMi4gRG8gd2UgbmVlZCB0 byBwcm9ncmFtIHRoZSBzdHJpZGUgaW4gcGFnZSBmbGlwcyBhdCBhbGw/CgpZZXMsIG9uIFNLTCsu IEJlY2F1c2Ugd2UgYWxsb3cgdGlsaW5nIGNoYW5nZXMuIFdlJ3ZlIGFsd2F5cyBhbGxvd2VkIHRo YXQKYmVjYXVzZSBDUyBmbGlwcyBhbGxvdyBpdCBhcyB3ZWxsLiBBbmQgSUlSQyB3ZSBldmVuIGhh ZCBzb21lIHNwZWNpZmljCnVzZXIgZm9yIHRoYXQgc2luY2Ugc29tZW9uZSBub3RpY2VkIHRoYXQg aXQgZGlkbid0IGFjdHVhbGx5IHdvcmsgb24gVkxWLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl bCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK