From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 14:53:24 +0300 Message-ID: <20151020115324.GH26517@intel.com> References: <1444212083-3302-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20151019182036.GD26517@intel.com> <20151020074225.GS13786@phenom.ffwll.local> <56260432.1030007@linux.intel.com> <20151020110716.GF26517@intel.com> <56262905.5070705@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D36E6E233 for ; Tue, 20 Oct 2015 04:53:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <56262905.5070705@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjAsIDIwMTUgYXQgMTI6NDQ6MDVQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMjAvMTAvMTUgMTI6MDcsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ IE9uIFR1ZSwgT2N0IDIwLCAyMDE1IGF0IDEwOjA2OjU4QU0gKzAxMDAsIFR2cnRrbyBVcnN1bGlu IHdyb3RlOgo+ID4+Cj4gPj4gT24gMjAvMTAvMTUgMDg6NDIsIERhbmllbCBWZXR0ZXIgd3JvdGU6 Cj4gPj4+IE9uIE1vbiwgT2N0IDE5LCAyMDE1IGF0IDA5OjIwOjM2UE0gKzAzMDAsIFZpbGxlIFN5 cmrDpGzDpCB3cm90ZToKPiA+Pj4+IE9uIFdlZCwgT2N0IDA3LCAyMDE1IGF0IDExOjAxOjIzQU0g KzAxMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+ID4+Pj4+IEZyb206IFR2cnRrbyBVcnN1bGlu IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gPj4+Pj4KPiA+Pj4+PiBQcmV2aW91c2x5IHJv dGF0aW9uIHdhcyBpZ25vcmVkIGFuZCB3cm9uZyBzdHJpZGUgcHJvZ3JhbW1lZAo+ID4+Pj4+IGlu dG8gdGhlIHBsYW5lIHJlZ2lzdGVycyByZXN1bHRpbmcgaW4gYSBjb3JydXB0IGltYWdlIG9uIHNj cmVlbi4KPiA+Pj4+Pgo+ID4+Pj4+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gPj4+Pj4gQ2M6IFNvbmlrYSBKaW5kYWwgPHNvbmlrYS5q aW5kYWxAaW50ZWwuY29tPgo+ID4+Pj4+IC0tLQo+ID4+Pj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYyB8IDE2ICsrKysrKysrKysrKy0tLS0KPiA+Pj4+PiAgICAxIGZp bGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiA+Pj4+Pgo+ID4+ Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+Pj4+PiBpbmRleCA1MzljMzcz N2U4MjMuLjYzMjg3ODgxOTNlNCAxMDA2NDQKPiA+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiA+Pj4+PiBAQCAtMTExMjYsOSArMTExMjYsMTAgQEAgc3RhdGljIHZv aWQgc2tsX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YykKPiA+Pj4+ PiAgICB7Cj4gPj4+Pj4gICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9jcnRjLT5i YXNlLmRldjsKPiA+Pj4+PiAgICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g ZGV2LT5kZXZfcHJpdmF0ZTsKPiA+Pj4+PiArCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lID0gaW50 ZWxfY3J0Yy0+YmFzZS5wcmltYXJ5Owo+ID4+Pj4+ICAgIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVy ICpmYiA9IGludGVsX2NydGMtPmJhc2UucHJpbWFyeS0+ZmI7Cj4gPj4+Pj4gICAgCWNvbnN0IGVu dW0gcGlwZSBwaXBlID0gaW50ZWxfY3J0Yy0+cGlwZTsKPiA+Pj4+PiAtCXUzMiBjdGwsIHN0cmlk ZTsKPiA+Pj4+PiArCXUzMiBjdGwsIHN0cmlkZSwgdGlsZV9oZWlnaHQ7Cj4gPj4+Pj4KPiA+Pj4+ PiAgICAJY3RsID0gSTkxNV9SRUFEKFBMQU5FX0NUTChwaXBlLCAwKSk7Cj4gPj4+Pj4gICAgCWN0 bCAmPSB+UExBTkVfQ1RMX1RJTEVEX01BU0s7Cj4gPj4+Pj4gQEAgLTExMTUyLDkgKzExMTUzLDE2 IEBAIHN0YXRpYyB2b2lkIHNrbF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVsX2NydGMgKmludGVs X2NydGMpCj4gPj4+Pj4gICAgCSAqIFRoZSBzdHJpZGUgaXMgZWl0aGVyIGV4cHJlc3NlZCBhcyBh IG11bHRpcGxlIG9mIDY0IGJ5dGVzIGNodW5rcyBmb3IKPiA+Pj4+PiAgICAJICogbGluZWFyIGJ1 ZmZlcnMgb3IgaW4gbnVtYmVyIG9mIHRpbGVzIGZvciB0aWxlZCBidWZmZXJzLgo+ID4+Pj4+ICAg IAkgKi8KPiA+Pj4+PiAtCXN0cmlkZSA9IGZiLT5waXRjaGVzWzBdIC8KPiA+Pj4+PiAtCQkgaW50 ZWxfZmJfc3RyaWRlX2FsaWdubWVudChkZXYsIGZiLT5tb2RpZmllclswXSwKPiA+Pj4+PiAtCQkJ CQkgICBmYi0+cGl4ZWxfZm9ybWF0KTsKPiA+Pj4+PiArCWlmIChpbnRlbF9yb3RhdGlvbl85MF9v cl8yNzAocGxhbmUtPnN0YXRlLT5yb3RhdGlvbikpIHsKPiA+Pj4+PiArCQkvKiBzdHJpZGUgPSBT dXJmYWNlIGhlaWdodCBpbiB0aWxlcyAqLwo+ID4+Pj4+ICsJCXRpbGVfaGVpZ2h0ID0gaW50ZWxf dGlsZV9oZWlnaHQoZGV2LCBmYi0+cGl4ZWxfZm9ybWF0LAo+ID4+Pj4+ICsJCQkJCQlmYi0+bW9k aWZpZXJbMF0sIDApOwo+ID4+Pj4+ICsJCXN0cmlkZSA9IERJVl9ST1VORF9VUChmYi0+aGVpZ2h0 LCB0aWxlX2hlaWdodCk7Cj4gPj4+Pj4gKwl9IGVsc2Ugewo+ID4+Pj4+ICsJCXN0cmlkZSA9IGZi LT5waXRjaGVzWzBdIC8KPiA+Pj4+PiArCQkJCWludGVsX2ZiX3N0cmlkZV9hbGlnbm1lbnQoZGV2 LCBmYi0+bW9kaWZpZXJbMF0sCj4gPj4+Pj4gKwkJCQkJCQkgIGZiLT5waXhlbF9mb3JtYXQpOwo+ ID4+Pj4+ICsJfQo+ID4+Pj4KPiA+Pj4+IEkgd2FzIHdvbmRlcmluZyB3aHkgd2UgYXJlIGFsbG93 aW5nIHN0cmlkZSBjaGFuZ2VzIGR1cmluZyBwYWdlIGZsaXAsIGJ1dAo+ID4+Pj4gYWZ0ZXIgbG9v a2luZyBhdCB0aGUgaGlzdG9yeSBpdCBzZWVtcyB3ZSBhcmUgbm90LiBUaGUgcmVhc29uIGZvcgo+ ID4+Pj4gdXBkYXRpbmcgdGhlIHN0cmlkZSByZWdpc3RlciBpcyB0aGUgZmFjdCB0aGF0IHRoZSB1 bml0cyB3ZSBzcGVjaWZ5IGl0Cj4gPj4+PiBpbiBjaGFuZ2UgYmV0d2VlbiBkaWZmZXJlbnQgdGls aW5nIG1vZGVzIG9uIFNLTCsuIFdlIHN0aWxsIHJlamVjdCBhY3R1YWwKPiA+Pj4+IHN0cmlkZSBj aGFuZ2VzIGR1cmluZyBwYWdlIGZsaXAsIHdoaWNoIGlzIGdvb2QgYmVjYXVzZSBhbGxvd2luZyBp dCB3b3VsZAo+ID4+Pj4gY2F1c2UgcHJvYmxlbXMgZm9yIG15IGZiLT5vZmZzZXRzW10gc3R1ZmYg c2luY2UgdGhlIGludGVycHJldGF0aW9uIG9mIHRoZQo+ID4+Pj4gbGluZWFyIG9mZnNldCB3b3Vs ZCBjaGFuZ2Ugd2l0aCB0aGUgc3RyaWRlLgo+ID4+Pj4KPiA+Pj4+IFdlIGRvIGFsbG93IGNoYW5n ZXMgdG8gdGhlIHJvdGF0ZWQgc3RyaWRlIHRob3VnaCBzaW5jZSB3ZSBkb24ndCByZWplY3QKPiA+ Pj4+IGNoYW5nZXMgdG8gdGhlIGZiIGhlaWdodC4gSSB0aGluayBJIG5lZWQgdG8gZHJhdyBzb21l IHBpY3R1cmVzIGJlZm9yZSBJCj4gPj4+PiBjYW4gc2F5IGZvciBzdXJlIHdoZXRoZXIgdGhhdCBj YW4gY2F1c2UgcHJvYmxlbXMgb3Igbm90LiBCdXQgd2UgY2EKPiA+Pj4+IGxlYXZlIHRoYXQgZm9y IGFub3RoZXIgcGF0Y2ggaWYgaXQgdHVybnMgb3V0IHRvIG5lZWQgaGFuZGxpbmcuCj4gPj4+Pgo+ ID4+Pj4gT25lIHRoaW5nIHRoYXQncyBkb2RneSBoZXJlIGlzIHRoZSBwbGFuZS0+c3RhdGUtPnJv dGF0aW9uIGNoZWNrLiBJCj4gPj4+PiB0aGluayBjdXJyZW50bHkgd2Ugd2FpdCBmb3IgcGVuZGlu ZyBmbGlwcyBkdXJpbmcgdGhlIGF0b21pYyBjb21taXQKPiA+Pj4+IHBoYXNlIGFmdGVyIHdlJ3Zl IHN3YXBwZWQgdGhlIHN0YXRlLiBTbyB0aGlzIG1heSBlbmQgdXAgdXNpbmcgdGhlCj4gPj4+PiB3 cm9uZyByb3RhdGlvbiBzZXR0aW5nLiBJdCB3b3VsZCBiZSBhbiBldmVuIGJpZ2dlciBwcm9ibGVt IGlmIHdlCj4gPj4+PiBhbHJlYWR5IGFsbG93ZWQgcXVldWVpbmcgdXAgb3IgcmVwbGFjZWluZyBw ZW5kaW5nIHBsYW5lIHVwZGF0ZXMuIEkKPiA+Pj4+IHN1cHBvc2UgdGhlIHByaW1hcnktPmZiIHRo aW5nIGRvZXNuJ3Qgc3VmZmVyIGZyb20gdGhpcyBwcm9ibGVtIGJlY2F1c2UKPiA+Pj4+IHdlIHN3 YXAgdGhhdCBwb2ludGVyIG9ubHkgYWZ0ZXIgd2UndmUgd2FpdGVkIGZvciBwZW5kaW5nIGZsaXBz Lgo+ID4+Pgo+ID4+PiBDdXJyZW50IHJ1bGUgaXMgdGhhdCBwYWdlZmxpcCBkb2Vzbid0IGFsbG93 IGFueSBjaGFuZ2UgaW4gYW55IG1ldGFkYXRhLgo+ID4+PiBUaGVyZSdzIHNvbWUgbWlub3IgZXhj ZXB0aW9uIHRoYXQgb24gc29tZSBwbGF0Zm9ybXMgd2UgY2FuIGNoYW5nZSB0aGUKPiA+Pj4gdGls aW5nIGJlY2F1c2Ugc29tZW9uZSBhc2tlZCBmb3IgdGhhdCBzcGVjaWZpY2FsbHkgYW5kIGl0J3Mg cG9zc2libGUuCj4gPj4+Cj4gPj4+IGF0b21pYyBmbGlwcyB3aWxsIGJlIGFibGUgdG8gY29wZSB3 aXRoIHRoaXMuIEJ1dCBmb3IgbGVnYWN5IHBhZ2VmbGlwcyBpbW8KPiA+Pj4gcmVqZWN0IGV2ZXJ5 dGhpbmcgYWdncmVzc2l2ZWx5IHRoYXQgY2hhbmdlcyBtZXRhZGF0YSAoc3RyaWRlLCB0aWxpbmcs Cj4gPj4+IHJvdGF0aW9uKS4KPiA+Pgo+ID4+IEkgYW0gbm90IHN1cmUgd2hhdCBpcyB0aGUgY29u Y2x1c2lvbi4gVG8gcmUtaXRlcmF0ZSwgaWRlYSBpcyBub3QgdG8KPiA+PiBhbGxvdyByb3RhdGlv biBjaGFuZ2VzIGJldHdlZW4gcGFnZSBmbGlwcywganVzdCB0byBwcm9ncmFtIFBMQU5FX1NUUklE RQo+ID4+IGFjY29yZGluZ2x5LCB3aGVuIHJvdGF0aW9uIGlzIGFscmVhZHkgZW5hYmxlZC4gU2lu Y2Ugb3RoZXJ3aXNlIHBhZ2UgZmxpcAo+ID4+IHdpbGwgY2FsY3VsYXRlIGl0IGluY29ycmVjdGx5 Lgo+ID4+Cj4gPj4gSSB0aG91Z2ggVmlsbGUgd2FzIHJhaXNpbmcgdHdvIGNvbmNlcm5zOgo+ID4+ Cj4gPj4gMS4gV2lsbCB0aGUgcGxhbmUgc3RhdGUgYmUgc3dhcHBlZCBmcm9tIHVuZGVyIHRoZSBw ZW5kaW5nIHBhZ2UgZmxpcHMKPiA+PiBwcmVtYXR1cmVseT8KPiA+Cj4gPiBUaGUgYW5zd2VyIGlz IHllcy4KPiAKPiBBbmQgaXMgdGhhdCBPSz8KCk5vLCB3ZSBjb3VsZCBtaXNwcm9ncmFtIHRoZSBz dHJpZGUgYW5kIGNvcnJ1cHQgdGhlIGRpc3BsYXkuCgo+IFdvdWxkIGl0IG5vdCBtYWtlIG1vcmUg c2Vuc2UgdG8gd2FpdCBmb3IgcGVuZGluZyBmbGlwcyAKPiBhbmQgdGhlbiBzd2FwIHN0YXRlPwoK SSB0aGluayBldmVudHVhbGx5IHdlIHdhbnQgdG8gcXVldWUgdXAgbXVsdGlwbGUgZmxpcHMgYW5k L29yIGFsbG93CmxhdGVyIGZsaXBzIHRvIG92ZXJyaWRlIHByZXZpb3VzIG9uZXMsIHNvIGNvbnN1 bHRpbmcgdGhlIGN1cnJlbnQKc3RhdGUgZnJvbSB0aGUgbW1pbyBmbGlwIGlzIGEgbm90IGEgZ29v ZCBpZGVhIGluIGFueSBjYXNlLiBJIHdvdWxkCmp1c3QgYWRkIHdvcmstPnJvdGF0aW9uIGFuZCBw b3B1bGF0ZSBpdCB3aXRoIGEgc25hcHNob3QgYXQgdGhlIHRpbWUKd2hlbiB0aGUgZmxpcCBpcyBx dWV1ZWQuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=