From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 15:21:16 +0300 Message-ID: <20151020122116.GJ26517@intel.com> References: <1444212083-3302-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20151019182036.GD26517@intel.com> <20151020074225.GS13786@phenom.ffwll.local> <56260432.1030007@linux.intel.com> <20151020110716.GF26517@intel.com> <56262905.5070705@linux.intel.com> <20151020115324.GH26517@intel.com> <56262E02.8010400@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 73B556EBE3 for ; Tue, 20 Oct 2015 05:21:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <56262E02.8010400@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjAsIDIwMTUgYXQgMDE6MDU6MjJQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMjAvMTAvMTUgMTI6NTMsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ IE9uIFR1ZSwgT2N0IDIwLCAyMDE1IGF0IDEyOjQ0OjA1UE0gKzAxMDAsIFR2cnRrbyBVcnN1bGlu IHdyb3RlOgo+ID4+Cj4gPj4gT24gMjAvMTAvMTUgMTI6MDcsIFZpbGxlIFN5cmrDpGzDpCB3cm90 ZToKPiA+Pj4gT24gVHVlLCBPY3QgMjAsIDIwMTUgYXQgMTA6MDY6NThBTSArMDEwMCwgVHZydGtv IFVyc3VsaW4gd3JvdGU6Cj4gPj4+Pgo+ID4+Pj4gT24gMjAvMTAvMTUgMDg6NDIsIERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4gPj4+Pj4gT24gTW9uLCBPY3QgMTksIDIwMTUgYXQgMDk6MjA6MzZQTSAr MDMwMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ID4+Pj4+PiBPbiBXZWQsIE9jdCAwNywgMjAx NSBhdCAxMTowMToyM0FNICswMTAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPiA+Pj4+Pj4+IEZy b206IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gPj4+Pj4+Pgo+ ID4+Pj4+Pj4gUHJldmlvdXNseSByb3RhdGlvbiB3YXMgaWdub3JlZCBhbmQgd3Jvbmcgc3RyaWRl IHByb2dyYW1tZWQKPiA+Pj4+Pj4+IGludG8gdGhlIHBsYW5lIHJlZ2lzdGVycyByZXN1bHRpbmcg aW4gYSBjb3JydXB0IGltYWdlIG9uIHNjcmVlbi4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBTaWduZWQt b2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+ID4+Pj4+ Pj4gQ2M6IFNvbmlrYSBKaW5kYWwgPHNvbmlrYS5qaW5kYWxAaW50ZWwuY29tPgo+ID4+Pj4+Pj4g LS0tCj4gPj4+Pj4+PiAgICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwg MTYgKysrKysrKysrKysrLS0tLQo+ID4+Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+Pj4+Pj4+IGluZGV4IDUzOWMzNzM3ZTgyMy4uNjMyODc4 ODE5M2U0IDEwMDY0NAo+ID4+Pj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gPj4+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiA+Pj4+Pj4+IEBAIC0xMTEyNiw5ICsxMTEyNiwxMCBAQCBzdGF0aWMgdm9pZCBza2xf ZG9fbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjKQo+ID4+Pj4+Pj4gICAg IHsKPiA+Pj4+Pj4+ICAgICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2NydGMtPmJh c2UuZGV2Owo+ID4+Pj4+Pj4gICAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSBkZXYtPmRldl9wcml2YXRlOwo+ID4+Pj4+Pj4gKwlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9 IGludGVsX2NydGMtPmJhc2UucHJpbWFyeTsKPiA+Pj4+Pj4+ICAgICAJc3RydWN0IGRybV9mcmFt ZWJ1ZmZlciAqZmIgPSBpbnRlbF9jcnRjLT5iYXNlLnByaW1hcnktPmZiOwo+ID4+Pj4+Pj4gICAg IAljb25zdCBlbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gPj4+Pj4+PiAtCXUz MiBjdGwsIHN0cmlkZTsKPiA+Pj4+Pj4+ICsJdTMyIGN0bCwgc3RyaWRlLCB0aWxlX2hlaWdodDsK PiA+Pj4+Pj4+Cj4gPj4+Pj4+PiAgICAgCWN0bCA9IEk5MTVfUkVBRChQTEFORV9DVEwocGlwZSwg MCkpOwo+ID4+Pj4+Pj4gICAgIAljdGwgJj0gflBMQU5FX0NUTF9USUxFRF9NQVNLOwo+ID4+Pj4+ Pj4gQEAgLTExMTUyLDkgKzExMTUzLDE2IEBAIHN0YXRpYyB2b2lkIHNrbF9kb19tbWlvX2ZsaXAo c3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMpCj4gPj4+Pj4+PiAgICAgCSAqIFRoZSBzdHJp ZGUgaXMgZWl0aGVyIGV4cHJlc3NlZCBhcyBhIG11bHRpcGxlIG9mIDY0IGJ5dGVzIGNodW5rcyBm b3IKPiA+Pj4+Pj4+ICAgICAJICogbGluZWFyIGJ1ZmZlcnMgb3IgaW4gbnVtYmVyIG9mIHRpbGVz IGZvciB0aWxlZCBidWZmZXJzLgo+ID4+Pj4+Pj4gICAgIAkgKi8KPiA+Pj4+Pj4+IC0Jc3RyaWRl ID0gZmItPnBpdGNoZXNbMF0gLwo+ID4+Pj4+Pj4gLQkJIGludGVsX2ZiX3N0cmlkZV9hbGlnbm1l bnQoZGV2LCBmYi0+bW9kaWZpZXJbMF0sCj4gPj4+Pj4+PiAtCQkJCQkgICBmYi0+cGl4ZWxfZm9y bWF0KTsKPiA+Pj4+Pj4+ICsJaWYgKGludGVsX3JvdGF0aW9uXzkwX29yXzI3MChwbGFuZS0+c3Rh dGUtPnJvdGF0aW9uKSkgewo+ID4+Pj4+Pj4gKwkJLyogc3RyaWRlID0gU3VyZmFjZSBoZWlnaHQg aW4gdGlsZXMgKi8KPiA+Pj4+Pj4+ICsJCXRpbGVfaGVpZ2h0ID0gaW50ZWxfdGlsZV9oZWlnaHQo ZGV2LCBmYi0+cGl4ZWxfZm9ybWF0LAo+ID4+Pj4+Pj4gKwkJCQkJCWZiLT5tb2RpZmllclswXSwg MCk7Cj4gPj4+Pj4+PiArCQlzdHJpZGUgPSBESVZfUk9VTkRfVVAoZmItPmhlaWdodCwgdGlsZV9o ZWlnaHQpOwo+ID4+Pj4+Pj4gKwl9IGVsc2Ugewo+ID4+Pj4+Pj4gKwkJc3RyaWRlID0gZmItPnBp dGNoZXNbMF0gLwo+ID4+Pj4+Pj4gKwkJCQlpbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGRldiwg ZmItPm1vZGlmaWVyWzBdLAo+ID4+Pj4+Pj4gKwkJCQkJCQkgIGZiLT5waXhlbF9mb3JtYXQpOwo+ ID4+Pj4+Pj4gKwl9Cj4gPj4+Pj4+Cj4gPj4+Pj4+IEkgd2FzIHdvbmRlcmluZyB3aHkgd2UgYXJl IGFsbG93aW5nIHN0cmlkZSBjaGFuZ2VzIGR1cmluZyBwYWdlIGZsaXAsIGJ1dAo+ID4+Pj4+PiBh ZnRlciBsb29raW5nIGF0IHRoZSBoaXN0b3J5IGl0IHNlZW1zIHdlIGFyZSBub3QuIFRoZSByZWFz b24gZm9yCj4gPj4+Pj4+IHVwZGF0aW5nIHRoZSBzdHJpZGUgcmVnaXN0ZXIgaXMgdGhlIGZhY3Qg dGhhdCB0aGUgdW5pdHMgd2Ugc3BlY2lmeSBpdAo+ID4+Pj4+PiBpbiBjaGFuZ2UgYmV0d2VlbiBk aWZmZXJlbnQgdGlsaW5nIG1vZGVzIG9uIFNLTCsuIFdlIHN0aWxsIHJlamVjdCBhY3R1YWwKPiA+ Pj4+Pj4gc3RyaWRlIGNoYW5nZXMgZHVyaW5nIHBhZ2UgZmxpcCwgd2hpY2ggaXMgZ29vZCBiZWNh dXNlIGFsbG93aW5nIGl0IHdvdWxkCj4gPj4+Pj4+IGNhdXNlIHByb2JsZW1zIGZvciBteSBmYi0+ b2Zmc2V0c1tdIHN0dWZmIHNpbmNlIHRoZSBpbnRlcnByZXRhdGlvbiBvZiB0aGUKPiA+Pj4+Pj4g bGluZWFyIG9mZnNldCB3b3VsZCBjaGFuZ2Ugd2l0aCB0aGUgc3RyaWRlLgo+ID4+Pj4+Pgo+ID4+ Pj4+PiBXZSBkbyBhbGxvdyBjaGFuZ2VzIHRvIHRoZSByb3RhdGVkIHN0cmlkZSB0aG91Z2ggc2lu Y2Ugd2UgZG9uJ3QgcmVqZWN0Cj4gPj4+Pj4+IGNoYW5nZXMgdG8gdGhlIGZiIGhlaWdodC4gSSB0 aGluayBJIG5lZWQgdG8gZHJhdyBzb21lIHBpY3R1cmVzIGJlZm9yZSBJCj4gPj4+Pj4+IGNhbiBz YXkgZm9yIHN1cmUgd2hldGhlciB0aGF0IGNhbiBjYXVzZSBwcm9ibGVtcyBvciBub3QuIEJ1dCB3 ZSBjYQo+ID4+Pj4+PiBsZWF2ZSB0aGF0IGZvciBhbm90aGVyIHBhdGNoIGlmIGl0IHR1cm5zIG91 dCB0byBuZWVkIGhhbmRsaW5nLgo+ID4+Pj4+Pgo+ID4+Pj4+PiBPbmUgdGhpbmcgdGhhdCdzIGRv ZGd5IGhlcmUgaXMgdGhlIHBsYW5lLT5zdGF0ZS0+cm90YXRpb24gY2hlY2suIEkKPiA+Pj4+Pj4g dGhpbmsgY3VycmVudGx5IHdlIHdhaXQgZm9yIHBlbmRpbmcgZmxpcHMgZHVyaW5nIHRoZSBhdG9t aWMgY29tbWl0Cj4gPj4+Pj4+IHBoYXNlIGFmdGVyIHdlJ3ZlIHN3YXBwZWQgdGhlIHN0YXRlLiBT byB0aGlzIG1heSBlbmQgdXAgdXNpbmcgdGhlCj4gPj4+Pj4+IHdyb25nIHJvdGF0aW9uIHNldHRp bmcuIEl0IHdvdWxkIGJlIGFuIGV2ZW4gYmlnZ2VyIHByb2JsZW0gaWYgd2UKPiA+Pj4+Pj4gYWxy ZWFkeSBhbGxvd2VkIHF1ZXVlaW5nIHVwIG9yIHJlcGxhY2VpbmcgcGVuZGluZyBwbGFuZSB1cGRh dGVzLiBJCj4gPj4+Pj4+IHN1cHBvc2UgdGhlIHByaW1hcnktPmZiIHRoaW5nIGRvZXNuJ3Qgc3Vm ZmVyIGZyb20gdGhpcyBwcm9ibGVtIGJlY2F1c2UKPiA+Pj4+Pj4gd2Ugc3dhcCB0aGF0IHBvaW50 ZXIgb25seSBhZnRlciB3ZSd2ZSB3YWl0ZWQgZm9yIHBlbmRpbmcgZmxpcHMuCj4gPj4+Pj4KPiA+ Pj4+PiBDdXJyZW50IHJ1bGUgaXMgdGhhdCBwYWdlZmxpcCBkb2Vzbid0IGFsbG93IGFueSBjaGFu Z2UgaW4gYW55IG1ldGFkYXRhLgo+ID4+Pj4+IFRoZXJlJ3Mgc29tZSBtaW5vciBleGNlcHRpb24g dGhhdCBvbiBzb21lIHBsYXRmb3JtcyB3ZSBjYW4gY2hhbmdlIHRoZQo+ID4+Pj4+IHRpbGluZyBi ZWNhdXNlIHNvbWVvbmUgYXNrZWQgZm9yIHRoYXQgc3BlY2lmaWNhbGx5IGFuZCBpdCdzIHBvc3Np YmxlLgo+ID4+Pj4+Cj4gPj4+Pj4gYXRvbWljIGZsaXBzIHdpbGwgYmUgYWJsZSB0byBjb3BlIHdp dGggdGhpcy4gQnV0IGZvciBsZWdhY3kgcGFnZWZsaXBzIGltbwo+ID4+Pj4+IHJlamVjdCBldmVy eXRoaW5nIGFnZ3Jlc3NpdmVseSB0aGF0IGNoYW5nZXMgbWV0YWRhdGEgKHN0cmlkZSwgdGlsaW5n LAo+ID4+Pj4+IHJvdGF0aW9uKS4KPiA+Pj4+Cj4gPj4+PiBJIGFtIG5vdCBzdXJlIHdoYXQgaXMg dGhlIGNvbmNsdXNpb24uIFRvIHJlLWl0ZXJhdGUsIGlkZWEgaXMgbm90IHRvCj4gPj4+PiBhbGxv dyByb3RhdGlvbiBjaGFuZ2VzIGJldHdlZW4gcGFnZSBmbGlwcywganVzdCB0byBwcm9ncmFtIFBM QU5FX1NUUklERQo+ID4+Pj4gYWNjb3JkaW5nbHksIHdoZW4gcm90YXRpb24gaXMgYWxyZWFkeSBl bmFibGVkLiBTaW5jZSBvdGhlcndpc2UgcGFnZSBmbGlwCj4gPj4+PiB3aWxsIGNhbGN1bGF0ZSBp dCBpbmNvcnJlY3RseS4KPiA+Pj4+Cj4gPj4+PiBJIHRob3VnaCBWaWxsZSB3YXMgcmFpc2luZyB0 d28gY29uY2VybnM6Cj4gPj4+Pgo+ID4+Pj4gMS4gV2lsbCB0aGUgcGxhbmUgc3RhdGUgYmUgc3dh cHBlZCBmcm9tIHVuZGVyIHRoZSBwZW5kaW5nIHBhZ2UgZmxpcHMKPiA+Pj4+IHByZW1hdHVyZWx5 Pwo+ID4+Pgo+ID4+PiBUaGUgYW5zd2VyIGlzIHllcy4KPiA+Pgo+ID4+IEFuZCBpcyB0aGF0IE9L Pwo+ID4KPiA+IE5vLCB3ZSBjb3VsZCBtaXNwcm9ncmFtIHRoZSBzdHJpZGUgYW5kIGNvcnJ1cHQg dGhlIGRpc3BsYXkuCj4gCj4gT2ggSSBkaWQgbm90IG1lYW4gdGhhdCBidXQgaWYgaXQgaXMgT0sg dG8gcmVwbGFjZSB0aGUgc3RhdGUgdW5kZXIgcXVldWVkIAo+IGZsaXBzLiBTb3VuZGVkIGxpa2Ug YSBidWcgdG8gbWUgYnV0IHdoYXQgZG8gSSBrbm93LgoKV291bGQgYmUgcGVyZmVjdGx5IG5vcm1h bCBpZiB3ZSBhbGxvd2VkIHF1ZXVpbmcgdXAgZmxpcHMgZXRjLiBJIHdvdWxkCnRyeSB0byBtb3Zl IHRoZSBjb2RlIHRvd2FyZHMgdGhhdCBpbiBhbnkgY2FzZS4KCk5vdGUgdGhhdCB3aXRoIENTIGZs aXBzIGFsbCB0aGUgc3RhdGUgaGFzIGJlZW4gc25hcGhvc3QgYWxyZWFkeSBhbmQKZW1pdHRlZCBp bnRvIHRoZSByaW5nLCBzbyB0aGVyZSBpdCBqdXN0IHdvcmtzIChvciBzaG91bGQgYXQgbGVhc3Qp LgpXaXRoIG1taW8gZmxpcHMgaXQncyBhIGJpdCBkaWZmZXJlbnQgbmF0dXJhbGx5IHNpbmNlIHdl IG5lZWQgdG8gc3RvcmUKdGhlIHNuYXBzaG90IHNvbWV3aGVyZSBlbHNlLiBJIGRvbid0IHJlYWxs eSBsaWtlIHRoZSBwbGFuZS0+ZmIKc2l0dWF0aW9uIGVpdGhlciwgc28gdGhhdCB0b28gc2hvdWxk IGdldCBmaXhlZCB0byB0YWtlIGFuIGV4cGxpY2l0CnNuYXBzaG90IGZvciB0aGUgZmxpcC4KCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==