From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] drm/i915/skl: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 18:08:04 +0300 Message-ID: <20151020150804.GM26517@intel.com> References: <1445352851-26796-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id E00106EAFC for ; Tue, 20 Oct 2015 08:08:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1445352851-26796-1-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjAsIDIwMTUgYXQgMDM6NTQ6MTFQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBQcmV2aW91c2x5IHJvdGF0aW9uIHdhcyBpZ25vcmVkIGFuZCB3cm9uZyBzdHJpZGUgcHJv Z3JhbW1lZAo+IGludG8gdGhlIHBsYW5lIHJlZ2lzdGVycyByZXN1bHRpbmcgaW4gYSBjb3JydXB0 IGltYWdlIG9uIHNjcmVlbi4KPiAKPiB2MjogRG8gbm90IGFjY2VzcyBwb3RlbnRpYWx5IG9sZCBw bGFuZSBzdGF0ZSBhdCBmbGlwIHRpbWUsCj4gICAgIGJ1dCBzdG9yZSB0aGUgcm90YXRpb24gdmFs dWUgYXQgdGhlIHRpbWUgb2YgcXVlaW5nIHRoZSBmbGlwLgo+ICAgICAoVmlsbGUpCj4gCj4gU2ln bmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBU ZXN0Y2FzZTogaWd0L2ttc19yb3RhdGlvbl9jcmMvcHJpbWFyeS1yb3RhdGlvbi05MC1mbGlwLXN0 cmVzcyAoU0tMKQo+IENjOiBTb25pa2EgSmluZGFsIDxzb25pa2EuamluZGFsQGludGVsLmNvbT4K PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMzAgKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o ICAgICB8ICAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAxMSBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggMWZj MWQyNDBkM2MxLi45Y2IyOTA4Njk3MWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gQEAgLTExMDkxLDEzICsxMTA5MSwxNCBAQCBzdGF0aWMgYm9vbCB1c2VfbW1pb19m bGlwKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsCj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lk IHNrbF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4gKwkJCSAg ICAgdW5zaWduZWQgaW50IHJvdGF0aW9uLAo+ICAJCQkgICAgIHN0cnVjdCBpbnRlbF91bnBpbl93 b3JrICp3b3JrKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50ZWxfY3J0Yy0+ YmFzZS5kZXY7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRl dl9wcml2YXRlOwo+ICAJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBpbnRlbF9jcnRjLT5i YXNlLnByaW1hcnktPmZiOwo+ICAJY29uc3QgZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9jcnRjLT5w aXBlOwo+IC0JdTMyIGN0bCwgc3RyaWRlOwo+ICsJdTMyIGN0bCwgc3RyaWRlLCB0aWxlX2hlaWdo dDsKPiAgCj4gIAljdGwgPSBJOTE1X1JFQUQoUExBTkVfQ1RMKHBpcGUsIDApKTsKPiAgCWN0bCAm PSB+UExBTkVfQ1RMX1RJTEVEX01BU0s7Cj4gQEAgLTExMTIxLDkgKzExMTIyLDE2IEBAIHN0YXRp YyB2b2lkIHNrbF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4g IAkgKiBUaGUgc3RyaWRlIGlzIGVpdGhlciBleHByZXNzZWQgYXMgYSBtdWx0aXBsZSBvZiA2NCBi eXRlcyBjaHVua3MgZm9yCj4gIAkgKiBsaW5lYXIgYnVmZmVycyBvciBpbiBudW1iZXIgb2YgdGls ZXMgZm9yIHRpbGVkIGJ1ZmZlcnMuCj4gIAkgKi8KPiAtCXN0cmlkZSA9IGZiLT5waXRjaGVzWzBd IC8KPiAtCQkgaW50ZWxfZmJfc3RyaWRlX2FsaWdubWVudChkZXYsIGZiLT5tb2RpZmllclswXSwK PiAtCQkJCQkgICBmYi0+cGl4ZWxfZm9ybWF0KTsKPiArCWlmIChpbnRlbF9yb3RhdGlvbl85MF9v cl8yNzAocm90YXRpb24pKSB7Cj4gKwkJLyogc3RyaWRlID0gU3VyZmFjZSBoZWlnaHQgaW4gdGls ZXMgKi8KPiArCQl0aWxlX2hlaWdodCA9IGludGVsX3RpbGVfaGVpZ2h0KGRldiwgZmItPnBpeGVs X2Zvcm1hdCwKPiArCQkJCQkJZmItPm1vZGlmaWVyWzBdLCAwKTsKPiArCQlzdHJpZGUgPSBESVZf Uk9VTkRfVVAoZmItPmhlaWdodCwgdGlsZV9oZWlnaHQpOwo+ICsJfSBlbHNlIHsKPiArCQlzdHJp ZGUgPSBmYi0+cGl0Y2hlc1swXSAvCj4gKwkJCQlpbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGRl diwgZmItPm1vZGlmaWVyWzBdLAo+ICsJCQkJCQkJICBmYi0+cGl4ZWxfZm9ybWF0KTsKPiArCX0K PiAgCj4gIAkvKgo+ICAJICogQm90aCBQTEFORV9DVEwgYW5kIFBMQU5FX1NUUklERSBhcmUgbm90 IHVwZGF0ZWQgb24gdmJsYW5rIGJ1dCBvbgo+IEBAIC0xMTE4MSw3ICsxMTE4OSw3IEBAIHN0YXRp YyB2b2lkIGludGVsX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfbW1pb19mbGlwICptbWlvX2Zs aXApCj4gIAlpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChjcnRjKTsKPiAgCj4gIAlpZiAoSU5URUxf SU5GTyhtbWlvX2ZsaXAtPmk5MTUpLT5nZW4gPj0gOSkKPiAtCQlza2xfZG9fbW1pb19mbGlwKGNy dGMsIHdvcmspOwo+ICsJCXNrbF9kb19tbWlvX2ZsaXAoY3J0YywgbW1pb19mbGlwLT5yb3RhdGlv biwgd29yayk7Cj4gIAllbHNlCj4gIAkJLyogdXNlX21taW9fZmxpcCgpIHJldHJpY3RzIE1NSU8g ZmxpcHMgdG8gaWxrKyAqLwo+ICAJCWlsa19kb19tbWlvX2ZsaXAoY3J0Yywgd29yayk7Cj4gQEAg LTExMjA4LDEwICsxMTIxNiw4IEBAIHN0YXRpYyB2b2lkIGludGVsX21taW9fZmxpcF93b3JrX2Z1 bmMoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAKPiAgc3RhdGljIGludCBpbnRlbF9xdWV1 ZV9tbWlvX2ZsaXAoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJCSBzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMsCj4gLQkJCQkgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4gLQkJCQkgc3Ry dWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAtCQkJCSBzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICpyaW5nLAo+IC0JCQkJIHVpbnQzMl90IGZsYWdzKQo+ICsJCQkJIHVuc2lnbmVkIGludCBy b3RhdGlvbiwKPiArCQkJCSBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICB7Cj4g IAlzdHJ1Y3QgaW50ZWxfbW1pb19mbGlwICptbWlvX2ZsaXA7Cj4gIAo+IEBAIC0xMTIyMiw2ICsx MTIyOCw3IEBAIHN0YXRpYyBpbnQgaW50ZWxfcXVldWVfbW1pb19mbGlwKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsCj4gIAltbWlvX2ZsaXAtPmk5MTUgPSB0b19pOTE1KGRldik7Cj4gIAltbWlvX2Zs aXAtPnJlcSA9IGk5MTVfZ2VtX3JlcXVlc3RfcmVmZXJlbmNlKG9iai0+bGFzdF93cml0ZV9yZXEp Owo+ICAJbW1pb19mbGlwLT5jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjKTsKPiArCW1taW9fZmxp cC0+cm90YXRpb24gPSByb3RhdGlvbjsKCkNvdWxkIGp1c3QgZG8gdGhlIGNydGMtPnByaW1hcnkt PnN0YXRlLT5yb3RhdGlvbiB0aGluZyBoZXJlIGFuZCBhdm9pZApoYXZpbmcgdG8gcGFzcyB0aGUg cm90YXRpb24gZnJvbSB0aGUgY2FsbGVyLgoKQnV0IHRoZSBwYXRjaCBsb29rcyBPSyBhbnl3YXk6 ClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgoKPiAgCj4gIAlJTklUX1dPUksoJm1taW9fZmxpcC0+d29yaywgaW50ZWxfbW1pb19mbGlw X3dvcmtfZnVuYyk7Cj4gIAlzY2hlZHVsZV93b3JrKCZtbWlvX2ZsaXAtPndvcmspOwo+IEBAIC0x MTQzOCw4ICsxMTQ0NSw5IEBAIHN0YXRpYyBpbnQgaW50ZWxfY3J0Y19wYWdlX2ZsaXAoc3RydWN0 IGRybV9jcnRjICpjcnRjLAo+ICAJd29yay0+Z3R0X29mZnNldCArPSBpbnRlbF9jcnRjLT5kc3Bh ZGRyX29mZnNldDsKPiAgCj4gIAlpZiAobW1pb19mbGlwKSB7Cj4gLQkJcmV0ID0gaW50ZWxfcXVl dWVfbW1pb19mbGlwKGRldiwgY3J0YywgZmIsIG9iaiwgcmluZywKPiAtCQkJCQkgICAgcGFnZV9m bGlwX2ZsYWdzKTsKPiArCQlyZXQgPSBpbnRlbF9xdWV1ZV9tbWlvX2ZsaXAoZGV2LCBjcnRjLAo+ ICsJCQkJCSAgICBjcnRjLT5wcmltYXJ5LT5zdGF0ZS0+cm90YXRpb24sCj4gKwkJCQkJICAgIG9i aik7Cj4gIAkJaWYgKHJldCkKPiAgCQkJZ290byBjbGVhbnVwX3VucGluOwo+ICAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDI3ZGNjZjM1ZjliYy4uMTQwZjk0OTMwMmM3IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtNDkzLDYgKzQ5Myw3IEBAIHN0cnVjdCBp bnRlbF9tbWlvX2ZsaXAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTU7Cj4gIAlz dHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpj cnRjOwo+ICsJdW5zaWduZWQgaW50IHJvdGF0aW9uOwo+ICB9Owo+ICAKPiAgc3RydWN0IHNrbF9w aXBlX3dtIHsKPiAtLSAKPiAxLjkuMQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK