From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] drm/i915/skl: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 18:17:42 +0300 Message-ID: <20151020151742.GN26517@intel.com> References: <1445352851-26796-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20151020150804.GM26517@intel.com> <562659A6.3070105@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FFA56EC4A for ; Tue, 20 Oct 2015 08:17:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <562659A6.3070105@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjAsIDIwMTUgYXQgMDQ6MTE6MzRQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMjAvMTAvMTUgMTY6MDgsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ IE9uIFR1ZSwgT2N0IDIwLCAyMDE1IGF0IDAzOjU0OjExUE0gKzAxMDAsIFR2cnRrbyBVcnN1bGlu IHdyb3RlOgo+ID4+IEZyb206IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5j b20+Cj4gPj4KPiA+PiBQcmV2aW91c2x5IHJvdGF0aW9uIHdhcyBpZ25vcmVkIGFuZCB3cm9uZyBz dHJpZGUgcHJvZ3JhbW1lZAo+ID4+IGludG8gdGhlIHBsYW5lIHJlZ2lzdGVycyByZXN1bHRpbmcg aW4gYSBjb3JydXB0IGltYWdlIG9uIHNjcmVlbi4KPiA+Pgo+ID4+IHYyOiBEbyBub3QgYWNjZXNz IHBvdGVudGlhbHkgb2xkIHBsYW5lIHN0YXRlIGF0IGZsaXAgdGltZSwKPiA+PiAgICAgIGJ1dCBz dG9yZSB0aGUgcm90YXRpb24gdmFsdWUgYXQgdGhlIHRpbWUgb2YgcXVlaW5nIHRoZSBmbGlwLgo+ ID4+ICAgICAgKFZpbGxlKQo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4g PHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiA+PiBUZXN0Y2FzZTogaWd0L2ttc19yb3RhdGlv bl9jcmMvcHJpbWFyeS1yb3RhdGlvbi05MC1mbGlwLXN0cmVzcyAoU0tMKQo+ID4+IENjOiBTb25p a2EgSmluZGFsIDxzb25pa2EuamluZGFsQGludGVsLmNvbT4KPiA+PiBDYzogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+PiAtLS0KPiA+PiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDMwICsrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLQo+ID4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwg IDEgKwo+ID4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlv bnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+PiBpbmRl eCAxZmMxZDI0MGQzYzEuLjljYjI5MDg2OTcxYSAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPiA+PiBAQCAtMTEwOTEsMTMgKzExMDkxLDE0IEBAIHN0YXRpYyBi b29sIHVzZV9tbWlvX2ZsaXAoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPiA+PiAgIH0K PiA+Pgo+ID4+ICAgc3RhdGljIHZvaWQgc2tsX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfY3J0 YyAqaW50ZWxfY3J0YywKPiA+PiArCQkJICAgICB1bnNpZ25lZCBpbnQgcm90YXRpb24sCj4gPj4g ICAJCQkgICAgIHN0cnVjdCBpbnRlbF91bnBpbl93b3JrICp3b3JrKQo+ID4+ICAgewo+ID4+ICAg CXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9jcnRjLT5iYXNlLmRldjsKPiA+PiAgIAlz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ID4+ ICAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gaW50ZWxfY3J0Yy0+YmFzZS5wcmltYXJ5 LT5mYjsKPiA+PiAgIAljb25zdCBlbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4g Pj4gLQl1MzIgY3RsLCBzdHJpZGU7Cj4gPj4gKwl1MzIgY3RsLCBzdHJpZGUsIHRpbGVfaGVpZ2h0 Owo+ID4+Cj4gPj4gICAJY3RsID0gSTkxNV9SRUFEKFBMQU5FX0NUTChwaXBlLCAwKSk7Cj4gPj4g ICAJY3RsICY9IH5QTEFORV9DVExfVElMRURfTUFTSzsKPiA+PiBAQCAtMTExMjEsOSArMTExMjIs MTYgQEAgc3RhdGljIHZvaWQgc2tsX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50 ZWxfY3J0YywKPiA+PiAgIAkgKiBUaGUgc3RyaWRlIGlzIGVpdGhlciBleHByZXNzZWQgYXMgYSBt dWx0aXBsZSBvZiA2NCBieXRlcyBjaHVua3MgZm9yCj4gPj4gICAJICogbGluZWFyIGJ1ZmZlcnMg b3IgaW4gbnVtYmVyIG9mIHRpbGVzIGZvciB0aWxlZCBidWZmZXJzLgo+ID4+ICAgCSAqLwo+ID4+ IC0Jc3RyaWRlID0gZmItPnBpdGNoZXNbMF0gLwo+ID4+IC0JCSBpbnRlbF9mYl9zdHJpZGVfYWxp Z25tZW50KGRldiwgZmItPm1vZGlmaWVyWzBdLAo+ID4+IC0JCQkJCSAgIGZiLT5waXhlbF9mb3Jt YXQpOwo+ID4+ICsJaWYgKGludGVsX3JvdGF0aW9uXzkwX29yXzI3MChyb3RhdGlvbikpIHsKPiA+ PiArCQkvKiBzdHJpZGUgPSBTdXJmYWNlIGhlaWdodCBpbiB0aWxlcyAqLwo+ID4+ICsJCXRpbGVf aGVpZ2h0ID0gaW50ZWxfdGlsZV9oZWlnaHQoZGV2LCBmYi0+cGl4ZWxfZm9ybWF0LAo+ID4+ICsJ CQkJCQlmYi0+bW9kaWZpZXJbMF0sIDApOwo+ID4+ICsJCXN0cmlkZSA9IERJVl9ST1VORF9VUChm Yi0+aGVpZ2h0LCB0aWxlX2hlaWdodCk7Cj4gPj4gKwl9IGVsc2Ugewo+ID4+ICsJCXN0cmlkZSA9 IGZiLT5waXRjaGVzWzBdIC8KPiA+PiArCQkJCWludGVsX2ZiX3N0cmlkZV9hbGlnbm1lbnQoZGV2 LCBmYi0+bW9kaWZpZXJbMF0sCj4gPj4gKwkJCQkJCQkgIGZiLT5waXhlbF9mb3JtYXQpOwo+ID4+ ICsJfQo+ID4+Cj4gPj4gICAJLyoKPiA+PiAgIAkgKiBCb3RoIFBMQU5FX0NUTCBhbmQgUExBTkVf U1RSSURFIGFyZSBub3QgdXBkYXRlZCBvbiB2YmxhbmsgYnV0IG9uCj4gPj4gQEAgLTExMTgxLDcg KzExMTg5LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfZG9fbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9t bWlvX2ZsaXAgKm1taW9fZmxpcCkKPiA+PiAgIAlpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChjcnRj KTsKPiA+Pgo+ID4+ICAgCWlmIChJTlRFTF9JTkZPKG1taW9fZmxpcC0+aTkxNSktPmdlbiA+PSA5 KQo+ID4+IC0JCXNrbF9kb19tbWlvX2ZsaXAoY3J0Yywgd29yayk7Cj4gPj4gKwkJc2tsX2RvX21t aW9fZmxpcChjcnRjLCBtbWlvX2ZsaXAtPnJvdGF0aW9uLCB3b3JrKTsKPiA+PiAgIAllbHNlCj4g Pj4gICAJCS8qIHVzZV9tbWlvX2ZsaXAoKSByZXRyaWN0cyBNTUlPIGZsaXBzIHRvIGlsaysgKi8K PiA+PiAgIAkJaWxrX2RvX21taW9fZmxpcChjcnRjLCB3b3JrKTsKPiA+PiBAQCAtMTEyMDgsMTAg KzExMjE2LDggQEAgc3RhdGljIHZvaWQgaW50ZWxfbW1pb19mbGlwX3dvcmtfZnVuYyhzdHJ1Y3Qg d29ya19zdHJ1Y3QgKndvcmspCj4gPj4KPiA+PiAgIHN0YXRpYyBpbnQgaW50ZWxfcXVldWVfbW1p b19mbGlwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPj4gICAJCQkJIHN0cnVjdCBkcm1fY3J0 YyAqY3J0YywKPiA+PiAtCQkJCSBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiA+PiAtCQkJ CSBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ID4+IC0JCQkJIHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKnJpbmcsCj4gPj4gLQkJCQkgdWludDMyX3QgZmxhZ3MpCj4gPj4gKwkJCQkg dW5zaWduZWQgaW50IHJvdGF0aW9uLAo+ID4+ICsJCQkJIHN0cnVjdCBkcm1faTkxNV9nZW1fb2Jq ZWN0ICpvYmopCj4gPj4gICB7Cj4gPj4gICAJc3RydWN0IGludGVsX21taW9fZmxpcCAqbW1pb19m bGlwOwo+ID4+Cj4gPj4gQEAgLTExMjIyLDYgKzExMjI4LDcgQEAgc3RhdGljIGludCBpbnRlbF9x dWV1ZV9tbWlvX2ZsaXAoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+PiAgIAltbWlvX2ZsaXAt Pmk5MTUgPSB0b19pOTE1KGRldik7Cj4gPj4gICAJbW1pb19mbGlwLT5yZXEgPSBpOTE1X2dlbV9y ZXF1ZXN0X3JlZmVyZW5jZShvYmotPmxhc3Rfd3JpdGVfcmVxKTsKPiA+PiAgIAltbWlvX2ZsaXAt PmNydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+ID4+ICsJbW1pb19mbGlwLT5yb3RhdGlvbiA9 IHJvdGF0aW9uOwo+ID4KPiA+IENvdWxkIGp1c3QgZG8gdGhlIGNydGMtPnByaW1hcnktPnN0YXRl LT5yb3RhdGlvbiB0aGluZyBoZXJlIGFuZCBhdm9pZAo+ID4gaGF2aW5nIHRvIHBhc3MgdGhlIHJv dGF0aW9uIGZyb20gdGhlIGNhbGxlci4KPiAKPiBPaCB0aGF0IHdvdWxkIGluZGVlZCBiZSBuaWNl ci4gSSdsbCBkbyBhIHYzLgo+IAo+ID4gQnV0IHRoZSBwYXRjaCBsb29rcyBPSyBhbnl3YXk6Cj4g PiBSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiAKPiBDYW4gSSBjYXJyeSBvdmVyIHRoZSByLWIgdG8gdjM/CgpZZXMuCgotLSAKVmls bGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=