From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3] drm/i915/skl: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Wed, 21 Oct 2015 08:51:01 +0200 Message-ID: <20151021065101.GH13786@phenom.ffwll.local> References: <20151020151742.GN26517@intel.com> <1445354421-30088-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id 661BA6E9F0 for ; Tue, 20 Oct 2015 23:51:05 -0700 (PDT) Received: by wikq8 with SMTP id q8so78292353wik.1 for ; Tue, 20 Oct 2015 23:51:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1445354421-30088-1-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjAsIDIwMTUgYXQgMDQ6MjA6MjFQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBQcmV2aW91c2x5IHJvdGF0aW9uIHdhcyBpZ25vcmVkIGFuZCB3cm9uZyBzdHJpZGUgcHJv Z3JhbW1lZAo+IGludG8gdGhlIHBsYW5lIHJlZ2lzdGVycyByZXN1bHRpbmcgaW4gYSBjb3JydXB0 IGltYWdlIG9uIHNjcmVlbi4KPiAKPiB2MjogRG8gbm90IGFjY2VzcyBwb3RlbnRpYWx5IG9sZCBw bGFuZSBzdGF0ZSBhdCBmbGlwIHRpbWUsCj4gICAgIGJ1dCBzdG9yZSB0aGUgcm90YXRpb24gdmFs dWUgYXQgdGhlIHRpbWUgb2YgcXVlaW5nIHRoZSBmbGlwLgo+ICAgICAoVmlsbGUpCj4gCj4gdjM6 IE5vIG5lZWQgdG8gcGFzcyByb3RhdGlvbiB0byBpbnRlbF9xdWV1ZV9tbWlvX2ZsaXAgc2luY2Ug aXQKPiAgICAgaXMgYXZhaWxhYmxlIGluIHRoZSBjcnRjLiAoVmlsbGUpCj4gCj4gU2lnbmVkLW9m Zi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBUZXN0Y2Fz ZTogaWd0L2ttc19yb3RhdGlvbl9jcmMvcHJpbWFyeS1yb3RhdGlvbi05MC1mbGlwLXN0cmVzcyAo U0tMKQo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgo+IENjOiBTb25pa2EgSmluZGFsIDxzb25pa2EuamluZGFsQGludGVsLmNvbT4K PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClF1 ZXVlZCBmb3IgLW5leHQsIHRoYW5rcyBmb3IgdGhlIHBhdGNoLgotRGFuaWVsCgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyNyArKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDEg Kwo+ICAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCAxZmMxZDI0MGQzYzEu LjI5ODFkMDlkNWU0ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBA QCAtMTEwOTEsMTMgKzExMDkxLDE0IEBAIHN0YXRpYyBib29sIHVzZV9tbWlvX2ZsaXAoc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqcmluZywKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgc2tsX2RvX21t aW9fZmxpcChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YywKPiArCQkJICAgICB1bnNpZ25l ZCBpbnQgcm90YXRpb24sCj4gIAkJCSAgICAgc3RydWN0IGludGVsX3VucGluX3dvcmsgKndvcmsp Cj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9jcnRjLT5iYXNlLmRldjsK PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7 Cj4gIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IGludGVsX2NydGMtPmJhc2UucHJpbWFy eS0+ZmI7Cj4gIAljb25zdCBlbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gLQl1 MzIgY3RsLCBzdHJpZGU7Cj4gKwl1MzIgY3RsLCBzdHJpZGUsIHRpbGVfaGVpZ2h0Owo+ICAKPiAg CWN0bCA9IEk5MTVfUkVBRChQTEFORV9DVEwocGlwZSwgMCkpOwo+ICAJY3RsICY9IH5QTEFORV9D VExfVElMRURfTUFTSzsKPiBAQCAtMTExMjEsOSArMTExMjIsMTYgQEAgc3RhdGljIHZvaWQgc2ts X2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YywKPiAgCSAqIFRoZSBz dHJpZGUgaXMgZWl0aGVyIGV4cHJlc3NlZCBhcyBhIG11bHRpcGxlIG9mIDY0IGJ5dGVzIGNodW5r cyBmb3IKPiAgCSAqIGxpbmVhciBidWZmZXJzIG9yIGluIG51bWJlciBvZiB0aWxlcyBmb3IgdGls ZWQgYnVmZmVycy4KPiAgCSAqLwo+IC0Jc3RyaWRlID0gZmItPnBpdGNoZXNbMF0gLwo+IC0JCSBp bnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGRldiwgZmItPm1vZGlmaWVyWzBdLAo+IC0JCQkJCSAg IGZiLT5waXhlbF9mb3JtYXQpOwo+ICsJaWYgKGludGVsX3JvdGF0aW9uXzkwX29yXzI3MChyb3Rh dGlvbikpIHsKPiArCQkvKiBzdHJpZGUgPSBTdXJmYWNlIGhlaWdodCBpbiB0aWxlcyAqLwo+ICsJ CXRpbGVfaGVpZ2h0ID0gaW50ZWxfdGlsZV9oZWlnaHQoZGV2LCBmYi0+cGl4ZWxfZm9ybWF0LAo+ ICsJCQkJCQlmYi0+bW9kaWZpZXJbMF0sIDApOwo+ICsJCXN0cmlkZSA9IERJVl9ST1VORF9VUChm Yi0+aGVpZ2h0LCB0aWxlX2hlaWdodCk7Cj4gKwl9IGVsc2Ugewo+ICsJCXN0cmlkZSA9IGZiLT5w aXRjaGVzWzBdIC8KPiArCQkJCWludGVsX2ZiX3N0cmlkZV9hbGlnbm1lbnQoZGV2LCBmYi0+bW9k aWZpZXJbMF0sCj4gKwkJCQkJCQkgIGZiLT5waXhlbF9mb3JtYXQpOwo+ICsJfQo+ICAKPiAgCS8q Cj4gIAkgKiBCb3RoIFBMQU5FX0NUTCBhbmQgUExBTkVfU1RSSURFIGFyZSBub3QgdXBkYXRlZCBv biB2YmxhbmsgYnV0IG9uCj4gQEAgLTExMTgxLDcgKzExMTg5LDcgQEAgc3RhdGljIHZvaWQgaW50 ZWxfZG9fbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9tbWlvX2ZsaXAgKm1taW9fZmxpcCkKPiAgCWlu dGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGNydGMpOwo+ICAKPiAgCWlmIChJTlRFTF9JTkZPKG1taW9f ZmxpcC0+aTkxNSktPmdlbiA+PSA5KQo+IC0JCXNrbF9kb19tbWlvX2ZsaXAoY3J0Yywgd29yayk7 Cj4gKwkJc2tsX2RvX21taW9fZmxpcChjcnRjLCBtbWlvX2ZsaXAtPnJvdGF0aW9uLCB3b3JrKTsK PiAgCWVsc2UKPiAgCQkvKiB1c2VfbW1pb19mbGlwKCkgcmV0cmljdHMgTU1JTyBmbGlwcyB0byBp bGsrICovCj4gIAkJaWxrX2RvX21taW9fZmxpcChjcnRjLCB3b3JrKTsKPiBAQCAtMTEyMDgsMTAg KzExMjE2LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfbW1pb19mbGlwX3dvcmtfZnVuYyhzdHJ1Y3Qg d29ya19zdHJ1Y3QgKndvcmspCj4gIAo+ICBzdGF0aWMgaW50IGludGVsX3F1ZXVlX21taW9fZmxp cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCQkJIHN0cnVjdCBkcm1fY3J0YyAqY3J0YywK PiAtCQkJCSBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiAtCQkJCSBzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX29iamVjdCAqb2JqLAo+IC0JCQkJIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcs Cj4gLQkJCQkgdWludDMyX3QgZmxhZ3MpCj4gKwkJCQkgc3RydWN0IGRybV9pOTE1X2dlbV9vYmpl Y3QgKm9iaikKPiAgewo+ICAJc3RydWN0IGludGVsX21taW9fZmxpcCAqbW1pb19mbGlwOwo+ICAK PiBAQCAtMTEyMjIsNiArMTEyMjcsNyBAQCBzdGF0aWMgaW50IGludGVsX3F1ZXVlX21taW9fZmxp cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJbW1pb19mbGlwLT5pOTE1ID0gdG9faTkxNShk ZXYpOwo+ICAJbW1pb19mbGlwLT5yZXEgPSBpOTE1X2dlbV9yZXF1ZXN0X3JlZmVyZW5jZShvYmot Pmxhc3Rfd3JpdGVfcmVxKTsKPiAgCW1taW9fZmxpcC0+Y3J0YyA9IHRvX2ludGVsX2NydGMoY3J0 Yyk7Cj4gKwltbWlvX2ZsaXAtPnJvdGF0aW9uID0gY3J0Yy0+cHJpbWFyeS0+c3RhdGUtPnJvdGF0 aW9uOwo+ICAKPiAgCUlOSVRfV09SSygmbW1pb19mbGlwLT53b3JrLCBpbnRlbF9tbWlvX2ZsaXBf d29ya19mdW5jKTsKPiAgCXNjaGVkdWxlX3dvcmsoJm1taW9fZmxpcC0+d29yayk7Cj4gQEAgLTEx NDM4LDggKzExNDQ0LDcgQEAgc3RhdGljIGludCBpbnRlbF9jcnRjX3BhZ2VfZmxpcChzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMsCj4gIAl3b3JrLT5ndHRfb2Zmc2V0ICs9IGludGVsX2NydGMtPmRzcGFk ZHJfb2Zmc2V0Owo+ICAKPiAgCWlmIChtbWlvX2ZsaXApIHsKPiAtCQlyZXQgPSBpbnRlbF9xdWV1 ZV9tbWlvX2ZsaXAoZGV2LCBjcnRjLCBmYiwgb2JqLCByaW5nLAo+IC0JCQkJCSAgICBwYWdlX2Zs aXBfZmxhZ3MpOwo+ICsJCXJldCA9IGludGVsX3F1ZXVlX21taW9fZmxpcChkZXYsIGNydGMsIG9i aik7Cj4gIAkJaWYgKHJldCkKPiAgCQkJZ290byBjbGVhbnVwX3VucGluOwo+ICAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDI3ZGNjZjM1ZjliYy4uMTQwZjk0OTMwMmM3IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtNDkzLDYgKzQ5Myw3IEBAIHN0cnVjdCBp bnRlbF9tbWlvX2ZsaXAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTU7Cj4gIAlz dHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpj cnRjOwo+ICsJdW5zaWduZWQgaW50IHJvdGF0aW9uOwo+ICB9Owo+ICAKPiAgc3RydWN0IHNrbF9w aXBlX3dtIHsKPiAtLSAKPiAxLjkuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK