From: Damien Lespiau <damien.lespiau@intel.com>
To: "Thulasimani, Sivakumar" <sivakumar.thulasimani@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: Use dpcd read wake for sink crc calls.
Date: Wed, 21 Oct 2015 21:14:19 +0100 [thread overview]
Message-ID: <20151021201419.GA22092@strange.ger.corp.intel.com> (raw)
In-Reply-To: <5627D9F9.7080801@intel.com>
On Thu, Oct 22, 2015 at 12:01:21AM +0530, Thulasimani, Sivakumar wrote:
>
>
> On 8/25/2015 2:50 AM, Vivi, Rodrigo wrote:
> >On Mon, 2015-08-24 at 19:54 +0000, Zanoni, Paulo R wrote:
> >>Em Qui, 2015-08-20 às 16:23 -0700, Rodrigo Vivi escreveu:
> >>>Let's use a native read with retry as suggested per spec to
> >>>fix Sink CRC on SKL when PSR is enabled.
> >>>
> >>>With PSR enabled panel is probably taking more time to wake
> >>>and dpcd read is faling.
> >>Does this commit actually fix any known problem with Sink CRC? Or is
> >>it
> >>just a try? It would be nice to have this clarified in the commit
> >>message.
> >It was just a try but that made sink crc working on my SKL when PSR is
> >enabled. nothing much to add...
> SKL has new register AUX_MUTEX which should be used when accessing dpcd
> on edp. just searched the nightly code and could not find it. it might be
> the reason
> for random dpcd failures reported in the other thread.
We had patches for that back in December 2013 :)
The feedback from Art was:
The non-software aux users are PSR/SRD and GTC.
Better leave out the mutex for now. Hardware is going to try do the
arbitration itself. I expect you will then need to increase any software
timeout you may have.
Do you know if anything has changed since then?
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-21 20:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 23:12 [PATCH] drm/i915: Use dpcd read wake for sink crc calls Rodrigo Vivi
2015-08-20 23:23 ` Rodrigo Vivi
2015-08-24 4:57 ` Jindal, Sonika
2015-08-24 19:54 ` Zanoni, Paulo R
2015-08-24 21:20 ` Vivi, Rodrigo
2015-10-21 18:31 ` Thulasimani, Sivakumar
2015-10-21 19:59 ` Vivi, Rodrigo
2015-10-21 20:14 ` Damien Lespiau [this message]
2015-10-22 3:26 ` Thulasimani, Sivakumar
2015-11-16 16:05 ` Rodrigo Vivi
2015-11-17 14:08 ` Daniel Vetter
2015-11-18 18:31 ` Vivi, Rodrigo
2015-11-19 9:12 ` Daniel Vetter
2015-08-26 9:06 ` Daniel Vetter
2015-08-26 16:41 ` Vivi, Rodrigo
2015-08-27 9:21 ` Daniel Vetter
2015-08-27 10:45 ` Jani Nikula
2015-10-19 23:08 ` [PATCH] drm/i915: Retry on every aux read Rodrigo Vivi
2015-10-20 7:02 ` Jani Nikula
2015-10-20 7:39 ` Daniel Vetter
2015-10-20 15:36 ` Vivi, Rodrigo
2015-10-20 17:45 ` Vivi, Rodrigo
2015-10-20 18:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021201419.GA22092@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=sivakumar.thulasimani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox