From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 03/11] drm/i915: Kill off intel_crtc->atomic.wait_vblank. Date: Thu, 22 Oct 2015 16:30:31 +0300 Message-ID: <20151022133031.GO26517@intel.com> References: <1445514996-18733-1-git-send-email-maarten.lankhorst@linux.intel.com> <1445514996-18733-4-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id E2A9D6EFCC for ; Thu, 22 Oct 2015 06:31:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1445514996-18733-4-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMjIsIDIwMTUgYXQgMDE6NTY6MjhQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQnkgaGFuZGxpbmcgdGhpcyBhZnRlciB0aGUgYXRvbWljIGhlbHBlciB3YWl0 cyBmb3IgdmJsYW5rcyB0aGVyZSB3aWxsCj4gYmUgb25lIGxlc3Mgd2FpdCBmb3IgdmJsYW5rIGlu IHRoZSBhdG9taWMgcGF0aC4KPiAKPiBBbHNvIGdldCByaWQgb2YgdGhlIGRvdWJsZSB3YWl0X2Zv cl92Ymxhbmsgb24gYnJvYWR3ZWxsLCBsb29rcyBsaWtlCj4gaXQncyBhIGJ1ZyBkb2luZyB0aGUg dmJsYW5rIHdhaXQgdHdpY2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3Qg PG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMjggKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgMSAtCj4gIDIgZmls ZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggMDUxYTFlMmIxYzU1Li5iOGUxYTU0NzFi ZWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTQ2NzIsMTQg KzQ2NzIsNiBAQCBpbnRlbF9wb3N0X2VuYWJsZV9wcmltYXJ5KHN0cnVjdCBkcm1fY3J0YyAqY3J0 YykKPiAgCWludCBwaXBlID0gaW50ZWxfY3J0Yy0+cGlwZTsKPiAgCj4gIAkvKgo+IC0JICogQkRX IHNpZ25hbHMgZmxpcCBkb25lIGltbWVkaWF0ZWx5IGlmIHRoZSBwbGFuZQo+IC0JICogaXMgZGlz YWJsZWQsIGV2ZW4gaWYgdGhlIHBsYW5lIGVuYWJsZSBpcyBhbHJlYWR5Cj4gLQkgKiBhcm1lZCB0 byBvY2N1ciBhdCB0aGUgbmV4dCB2YmxhbmsgOigKPiAtCSAqLwo+IC0JaWYgKElTX0JST0FEV0VM TChkZXYpKQo+IC0JCWludGVsX3dhaXRfZm9yX3ZibGFuayhkZXYsIHBpcGUpOwoKVGhlIHJpZ2h0 IGZpeCBmb3IgdGhpcyBjcmFwIGlzIHRvIG5vdCB1c2UgdGhlIGZsaXAgZG9uZSBpbnRlcnJ1cHQu IEJ1dAphcHBhcmVudGx5IG5vIG9uZSB3YW50cyB0byBmaXggdGhhdC4KClNvIG5vdyBJJ20gd29y cmllZCB0aGF0IHdlIG5vdyBkZXBlbmQgb24gdGhlIGF0b21pYyBoZWxwZXIgZG9pbmcKc3luY2hv cm5vdXMgdmJsYW5rIHdhaXRzIGhlcmUuIEFyZSB3ZSBleHBlY3RpbmcgdGhvc2UgdmJsYW5rIHdh aXRzIHRvCnJlbWFpbiB0aGVyZT8gSSB3b3VsZCBoYXZlIGV4cGVjdGVkIHRvIGdldCByaWQgb2Yg YWxsIHN5bmNocm9ub2lzIHZibGFuawp3YWl0cyBpbiBwbGFuZSBjb2RlcGF0aHMgKGFwYXJ0IGZy b20gb25lcyBmb3IgaHcgd29ya2Fyb3VuZHMpLgoKQWxzbyBkb2VzIHRoZSBoZWxwZXIgYWN0dWFs bHkgd2FpdCBmb3IgdmJsYW5rcyB3aGVuIHRoZSBwbGFuZSBnZXRzCmVuYWJsZWQgdy9vIHRoZSBm cmFtZWJ1ZmZlciBhY3R1YWxseSBjaGFuZ2luZz8KCj4gLQo+IC0JLyoKPiAgCSAqIEZJWE1FIElQ UyBzaG91bGQgYmUgZmluZSBhcyBsb25nIGFzIG9uZSBwbGFuZSBpcwo+ICAJICogZW5hYmxlZCwg YnV0IGluIHByYWN0aWNlIGl0IHNlZW1zIHRvIGhhdmUgcHJvYmxlbXMKPiAgCSAqIHdoZW4gZ29p bmcgZnJvbSBwcmltYXJ5IG9ubHkgdG8gc3ByaXRlIG9ubHkgYW5kIHZpY2UKPiBAQCAtNDc2MCw5 ICs0NzUyLDYgQEAgc3RhdGljIHZvaWQgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUoc3RydWN0IGlu dGVsX2NydGMgKmNydGMpCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBk ZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gIAo+IC0JaWYg KGF0b21pYy0+d2FpdF92YmxhbmspCj4gLQkJaW50ZWxfd2FpdF9mb3JfdmJsYW5rKGRldiwgY3J0 Yy0+cGlwZSk7Cj4gLQo+ICAJaW50ZWxfZnJvbnRidWZmZXJfZmxpcChkZXYsIGF0b21pYy0+ZmJf Yml0cyk7Cj4gIAo+ICAJaWYgKGF0b21pYy0+ZGlzYWJsZV9jeHNyKQo+IEBAIC0xMTY2MSwxNSAr MTE2NTAsMTIgQEAgaW50IGludGVsX3BsYW5lX2F0b21pY19jYWxjX2NoYW5nZXMoc3RydWN0IGRy bV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJCWlmIChwbGFuZS0+dHlwZSAhPSBEUk1fUExB TkVfVFlQRV9DVVJTT1IpIHsKPiAgCQkJaW50ZWxfY3J0Yy0+YXRvbWljLmRpc2FibGVfY3hzciA9 IHRydWU7Cj4gIAkJCS8qIHRvIHBvdGVudGlhbGx5IHJlLWVuYWJsZSBjeHNyICovCj4gLQkJCWlu dGVsX2NydGMtPmF0b21pYy53YWl0X3ZibGFuayA9IHRydWU7CgpXaGF0J3MgdGhlcmUgdG8gbWFr ZSBzdXJlIGN4c3IgZG9lc24ndCBnZXQgZW5hYmxlZC9kaXNhYmxlZCBhdCB0aGUgd3JvbmcKdGlt ZSBub3c/IEkgZ3Vlc3MgdGhpcyBpcyB0aGUgc2FtZSBxdWVzdGlvbiBhcyBmb3IgdGhlIEJEVyB3 L2EsIGllLiBkb2VzCnRoZSBwbGFuZSBnZXR0aW5nIGVuYWJsZWQvZGlzYWJsZWQgKG9yIHJhdGhl ciBiZWNvbWluZwp2aXNpYmxlL2ludmlzaWJsZSkgYWx3YXlzIGltcGx5IGEgdmJsYW5rIHdhaXQ/ Cgo+ICAJCQlpbnRlbF9jcnRjLT5hdG9taWMudXBkYXRlX3dtX3Bvc3QgPSB0cnVlOwo+ICAJCX0K PiAgCX0gZWxzZSBpZiAodHVybl9vZmYpIHsKPiAgCQlpbnRlbF9jcnRjLT5hdG9taWMudXBkYXRl X3dtX3Bvc3QgPSB0cnVlOwo+ICAJCS8qIG11c3QgZGlzYWJsZSBjeHNyIGFyb3VuZCBwbGFuZSBl bmFibGUvZGlzYWJsZSAqLwo+ICAJCWlmIChwbGFuZS0+dHlwZSAhPSBEUk1fUExBTkVfVFlQRV9D VVJTT1IpIHsKPiAtCQkJaWYgKGlzX2NydGNfZW5hYmxlZCkKPiAtCQkJCWludGVsX2NydGMtPmF0 b21pYy53YWl0X3ZibGFuayA9IHRydWU7Cj4gIAkJCWludGVsX2NydGMtPmF0b21pYy5kaXNhYmxl X2N4c3IgPSB0cnVlOwo+ICAJCX0KPiAgCX0gZWxzZSBpZiAoaW50ZWxfd21fbmVlZF91cGRhdGUo cGxhbmUsIHBsYW5lX3N0YXRlKSkgewo+IEBAIC0xMTcxNiwyMSArMTE3MDIsMTIgQEAgaW50IGlu dGVsX3BsYW5lX2F0b21pY19jYWxjX2NoYW5nZXMoc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRj X3N0YXRlLAo+ICAJCSAgICBwbGFuZV9zdGF0ZS0+cm90YXRpb24gIT0gQklUKERSTV9ST1RBVEVf MCkpCj4gIAkJCWludGVsX2NydGMtPmF0b21pYy5kaXNhYmxlX2ZiYyA9IHRydWU7Cj4gIAo+IC0J CS8qCj4gLQkJICogQkRXIHNpZ25hbHMgZmxpcCBkb25lIGltbWVkaWF0ZWx5IGlmIHRoZSBwbGFu ZQo+IC0JCSAqIGlzIGRpc2FibGVkLCBldmVuIGlmIHRoZSBwbGFuZSBlbmFibGUgaXMgYWxyZWFk eQo+IC0JCSAqIGFybWVkIHRvIG9jY3VyIGF0IHRoZSBuZXh0IHZibGFuayA6KAo+IC0JCSAqLwo+ IC0JCWlmICh0dXJuX29uICYmIElTX0JST0FEV0VMTChkZXYpKQo+IC0JCQlpbnRlbF9jcnRjLT5h dG9taWMud2FpdF92YmxhbmsgPSB0cnVlOwo+IC0KPiAgCQlpbnRlbF9jcnRjLT5hdG9taWMudXBk YXRlX2ZiYyB8PSB2aXNpYmxlIHx8IG1vZGVfY2hhbmdlZDsKPiAgCQlicmVhazsKPiAgCWNhc2Ug RFJNX1BMQU5FX1RZUEVfQ1VSU09SOgo+ICAJCWJyZWFrOwo+ICAJY2FzZSBEUk1fUExBTkVfVFlQ RV9PVkVSTEFZOgo+ICAJCWlmICh0dXJuX29mZiAmJiAhbW9kZV9jaGFuZ2VkKSB7Cj4gLQkJCWlu dGVsX2NydGMtPmF0b21pYy53YWl0X3ZibGFuayA9IHRydWU7Cj4gIAkJCWludGVsX2NydGMtPmF0 b21pYy51cGRhdGVfc3ByaXRlX3dhdGVybWFya3MgfD0KPiAgCQkJCTEgPDwgaTsKPiAgCQl9Cj4g QEAgLTEzMjcxLDE0ICsxMzI0OCwxNSBAQCBzdGF0aWMgaW50IGludGVsX2F0b21pY19jb21taXQo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCj4gIAkJaWYgKHB1dF9kb21haW5zKQo+ICAJCQlt b2Rlc2V0X3B1dF9wb3dlcl9kb21haW5zKGRldl9wcml2LCBwdXRfZG9tYWlucyk7Cj4gLQo+IC0J CWludGVsX3Bvc3RfcGxhbmVfdXBkYXRlKGludGVsX2NydGMpOwo+ICAJfQo+ICAKPiAgCS8qIEZJ WE1FOiBhZGQgc3VicGl4ZWwgb3JkZXIgKi8KPiAgCj4gIAlkcm1fYXRvbWljX2hlbHBlcl93YWl0 X2Zvcl92YmxhbmtzKGRldiwgc3RhdGUpOwo+ICAKPiArCWZvcl9lYWNoX2NydGNfaW5fc3RhdGUo c3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpCj4gKwkJaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUo dG9faW50ZWxfY3J0YyhjcnRjKSk7Cj4gKwo+ICAJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0 ZXgpOwo+ICAJZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMoZGV2LCBzdGF0ZSk7Cj4g IAltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaAo+IGluZGV4IDU0YTJjMGRhMmVjZS4uNGI2YmIxYWRmZGRkIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHJ2LmgKPiBAQCAtNTIyLDcgKzUyMiw2IEBAIHN0cnVjdCBpbnRlbF9jcnRjX2F0 b21pY19jb21taXQgewo+ICAKPiAgCS8qIFNsZWVwYWJsZSBvcGVyYXRpb25zIHRvIHBlcmZvcm0g YWZ0ZXIgY29tbWl0ICovCj4gIAl1bnNpZ25lZCBmYl9iaXRzOwo+IC0JYm9vbCB3YWl0X3ZibGFu azsKPiAgCWJvb2wgdXBkYXRlX2ZiYzsKPiAgCWJvb2wgcG9zdF9lbmFibGVfcHJpbWFyeTsKPiAg CXVuc2lnbmVkIHVwZGF0ZV9zcHJpdGVfd2F0ZXJtYXJrczsKPiAtLSAKPiAyLjEuMAo+IAo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmls bGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=