public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/2] igt_kms: Set atomic capability bit
Date: Fri, 23 Oct 2015 10:05:59 +0200	[thread overview]
Message-ID: <20151023080559.GK16848@phenom.ffwll.local> (raw)
In-Reply-To: <1445560021-17399-1-git-send-email-matthew.d.roper@intel.com>

On Thu, Oct 22, 2015 at 05:27:00PM -0700, Matt Roper wrote:
> Tell the kernel that we understand atomic and want to have access to
> atomic-only properties.  If the kernel doesn't support atomic for i915
> yet (and i915.nuclear_pageflip=1 isn't passed on the kernel command
> line) this will silently fail, but won't cause any problems.
> 
> We wrap this in an #ifdef to allow compilation on pre-atomic libdrm
> versions as well.
> 
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  lib/igt_kms.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 51d735d..53bfc20 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -984,6 +984,9 @@ void igt_display_init(igt_display_t *display, int drm_fd)
>  	display->n_pipes = resources->count_crtcs;
>  
>  	drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> +#ifdef DRM_CLIENT_CAP_ATOMIC

Just bumb the libdrm requirement in configure.ac imo.
-Daniel

> +	drmSetClientCap(drm_fd, DRM_CLIENT_CAP_ATOMIC, 1);
> +#endif
>  	plane_resources = drmModeGetPlaneResources(display->drm_fd);
>  	igt_assert(plane_resources);
>  
> -- 
> 2.1.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-10-23  8:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23  0:25 [PATCH 0/2] CRTC background color support for i915 Matt Roper
2015-10-23  0:25 ` [PATCH 1/2] drm: Add infrastructure for CRTC background color property Matt Roper
2015-10-23  1:26   ` kbuild test robot
2015-11-18 21:35   ` Bob Paauwe
2015-11-18 22:55     ` Matt Roper
2015-11-18 23:09   ` Emil Velikov
2015-10-23  0:25 ` [PATCH 2/2] drm/i915/skl: Add support for pipe background color Matt Roper
2015-10-23  0:39   ` [Intel-gfx] " kbuild test robot
2015-10-23  1:08   ` kbuild test robot
2015-11-18 21:43   ` Bob Paauwe
2015-10-23  0:26 ` [PATCH libdrm] xf86drmMode: Add RGBA property helpers Matt Roper
2015-10-23  0:27 ` [PATCH i-g-t 1/2] igt_kms: Set atomic capability bit Matt Roper
2015-10-23  0:27   ` [PATCH i-g-t 2/2] kms_crtc_background_color: Update to match kernel interface Matt Roper
2015-10-23  8:05   ` Daniel Vetter [this message]
2015-10-26  9:14     ` [PATCH i-g-t 1/2] igt_kms: Set atomic capability bit Daniel Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151023080559.GK16848@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox