From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Thomas Daniel <thomas.daniel@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix maxfifo watermark calc on vlv cursor planes
Date: Fri, 23 Oct 2015 17:05:11 +0300 [thread overview]
Message-ID: <20151023140511.GY26517@intel.com> (raw)
In-Reply-To: <1445608538-17998-1-git-send-email-thomas.daniel@intel.com>
On Fri, Oct 23, 2015 at 02:55:38PM +0100, Thomas Daniel wrote:
> A typo resulted in the watermarks for cursor planes not being calculated
> correctly. Fixed the typo.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Thomas Daniel <thomas.daniel@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 0fb0459..c01dd2b 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -1135,7 +1135,7 @@ static void vlv_compute_wm(struct intel_crtc *crtc)
> case DRM_PLANE_TYPE_CURSOR:
> for (level = 0; level < wm_state->num_levels; level++)
> wm_state->sr[level].cursor =
> - wm_state->sr[level].cursor;
> + wm_state->wm[level].cursor;
Yeah, the code is clearly wrong, but due to the fact that we initialize
the sr wm to the max (63) initially, this shouldn't have actually caused
any underruns and whatnot.
The patch is correct in any case.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> break;
> case DRM_PLANE_TYPE_PRIMARY:
> for (level = 0; level < wm_state->num_levels; level++)
> --
> 1.9.1
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-23 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 13:55 [PATCH] drm/i915: Fix maxfifo watermark calc on vlv cursor planes Thomas Daniel
2015-10-23 14:05 ` Ville Syrjälä [this message]
2015-10-27 13:54 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023140511.GY26517@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.daniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox