From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 20/43] drm/i915: Use paramtrized WRPLL_CTL() Date: Mon, 26 Oct 2015 16:49:00 +0200 Message-ID: <20151026144859.GI26517@intel.com> References: <1442595836-23981-1-git-send-email-ville.syrjala@linux.intel.com> <1442595836-23981-21-git-send-email-ville.syrjala@linux.intel.com> <87d1x0c8l1.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id A930A6E051 for ; Mon, 26 Oct 2015 07:49:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87d1x0c8l1.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMzAsIDIwMTUgYXQgMDQ6NTg6MzRQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gRnJpLCAxOCBTZXAgMjAxNSwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20g d3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oICAgICAgfCAyICstCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRp LmMgICAgIHwgOCArKysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyB8IDQgKystLQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA3IGRl bGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gaW5kZXggMjU4NjRh ZS4uYThmYjVmNyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVn LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+IEBAIC03MjUz LDcgKzcyNTMsNyBAQCBlbnVtIHNrbF9kaXNwX3Bvd2VyX3dlbGxzIHsKPiA+ICAvKiBXUlBMTCAq Lwo+ID4gICNkZWZpbmUgV1JQTExfQ1RMMQkJCTB4NDYwNDAKPiA+ICAjZGVmaW5lIFdSUExMX0NU TDIJCQkweDQ2MDYwCj4gPiAtI2RlZmluZSBXUlBMTF9DVEwocGxsKQkJCShwbGwgPT0gMCA/IFdS UExMX0NUTDEgOiBXUlBMTF9DVEwyKQo+ID4gKyNkZWZpbmUgV1JQTExfQ1RMKHBsbCkJCQlfUElQ RShwbGwsIFdSUExMX0NUTDEsIFdSUExMX0NUTDIpCj4gCj4gSSBob3BlIHdlIG5ldmVyIGFjY2lk ZW50YWxseSBwYXNzIHBsbCA+PSAyIGhlcmUuLi4gSSBndWVzcyB3ZSdsbCBmaW5kCj4gb3V0LiA7 KQo+IAo+IEkga25vdyB3ZSBkbyByZXVzZSBfUElQRSBsaWtlIHRoaXMsIGJ1dCBtYXliZSB3ZSBz aG91bGQgaGF2ZSBhIGRpZmZlcmVudAo+IG1hY3JvIHRoYXQgZW1waGFzaXplcyB0aGUgcGFyYW1l dGVyIGlzIHJlYWxseSBub3QgcGlwZSBiYXNlZCwgYnV0IHJhdGhlcgo+IGFuIElEIG9yIGVudW1l cmF0aW9uLiBUaGVyZSdzIHZhbHVlIGluIHNlbGYtZG9jdW1lbnRhdGluZyBjb2RlLCBhbmQKPiAq Z2FzcCogbWF5YmUgd2UnbGwgZXZlbnR1YWxseSBtYWtlIHRoaXMgc3R1ZmYgdHlwZSBzYWZlIHRv byEgQmFzaWNhbGx5Cj4gaXQgd291bGQgYmUgYW4gYWxpYXMgZm9yIF9QSVBFKCk7IHNlZSBfUExB TkUoKS4gT3IgbWF5YmUgX1BJUEUgYW5kCj4gX1BMQU5FIGNvdWxkIGJlIGJhc2VkIG9uIHRoZSBu ZXcgb25lLiBBbnl3YXksIGp1c3QgYSB0aG91Z2h0LCB0aGlzIGlzCj4gCj4gUmV2aWV3ZWQtYnk6 IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgpNZXJnZWQgdGhpcyBvbmUuIFRo YW5rcyBmb3IgdGhlIHJldmlldy4KCk5vdGUgdGhhdCBJIGhhZCB0byByZWJhc2UgaXQgYSBiaXQg ZHVlIHRvIHRoZSBTS0xfRFBMTHggY2hhbmdlIGluIG9uZQpvZiB0aGUgZWFybGllciBwYXRjaGVz LgoKPiAKPiAKPiA+ICAjZGVmaW5lICBXUlBMTF9QTExfRU5BQkxFCQkoMTw8MzEpCj4gPiAgI2Rl ZmluZSAgV1JQTExfUExMX1NTQwkJCSgxPDwyOCkKPiA+ICAjZGVmaW5lICBXUlBMTF9QTExfTk9O X1NTQwkJKDI8PDI4KQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IGluZGV4IDM5OWU3 MGUuLmZiNDU2YTQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k ZGkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IEBAIC0x MDk0LDEwICsxMDk0LDEwIEBAIHN0YXRpYyB2b2lkIGhzd19kZGlfY2xvY2tfZ2V0KHN0cnVjdCBp bnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gIAkJbGlua19jbG9jayA9IDI3MDAwMDsKPiA+ICAJ CWJyZWFrOwo+ID4gIAljYXNlIFBPUlRfQ0xLX1NFTF9XUlBMTDE6Cj4gPiAtCQlsaW5rX2Nsb2Nr ID0gaHN3X2RkaV9jYWxjX3dycGxsX2xpbmsoZGV2X3ByaXYsIFdSUExMX0NUTDEpOwo+ID4gKwkJ bGlua19jbG9jayA9IGhzd19kZGlfY2FsY193cnBsbF9saW5rKGRldl9wcml2LCBXUlBMTF9DVEwo MCkpOwo+ID4gIAkJYnJlYWs7Cj4gPiAgCWNhc2UgUE9SVF9DTEtfU0VMX1dSUExMMjoKPiA+IC0J CWxpbmtfY2xvY2sgPSBoc3dfZGRpX2NhbGNfd3JwbGxfbGluayhkZXZfcHJpdiwgV1JQTExfQ1RM Mik7Cj4gPiArCQlsaW5rX2Nsb2NrID0gaHN3X2RkaV9jYWxjX3dycGxsX2xpbmsoZGV2X3ByaXYs IFdSUExMX0NUTCgxKSk7Cj4gPiAgCQlicmVhazsKPiA+ICAJY2FzZSBQT1JUX0NMS19TRUxfU1BM TDoKPiA+ICAJCXBsbCA9IEk5MTVfUkVBRChTUExMX0NUTCkgJiBTUExMX1BMTF9GUkVRX01BU0s7 Cj4gPiBAQCAtMjQ4NSwxMyArMjQ4NSwxMyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHNrbF9kcGxs X3JlZ3Mgc2tsX2RwbGxfcmVnc1szXSA9IHsKPiA+ICAJfSwKPiA+ICAJewo+ID4gIAkJLyogRFBM TCAyICovCj4gPiAtCQkuY3RsID0gV1JQTExfQ1RMMSwKPiA+ICsJCS5jdGwgPSBXUlBMTF9DVEwo MCksCj4gPiAgCQkuY2ZnY3IxID0gRFBMTF9DRkdDUjEoMiksCj4gPiAgCQkuY2ZnY3IyID0gRFBM TF9DRkdDUjIoMiksCj4gPiAgCX0sCj4gPiAgCXsKPiA+ICAJCS8qIERQTEwgMyAqLwo+ID4gLQkJ LmN0bCA9IFdSUExMX0NUTDIsCj4gPiArCQkuY3RsID0gV1JQTExfQ1RMKDEpLAo+ID4gIAkJLmNm Z2NyMSA9IERQTExfQ0ZHQ1IxKDMpLAo+ID4gIAkJLmNmZ2NyMiA9IERQTExfQ0ZHQ1IyKDMpLAo+ ID4gIAl9LAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggNjNj ZjVlYi4uZmE3YzEwZmEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+ID4gQEAgLTkyMzcsOCArOTIzNyw4IEBAIHN0YXRpYyB2b2lkIGFzc2VydF9jYW5fZGlzYWJs ZV9sY3BsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCj4gPiAgCUk5 MTVfU1RBVEVfV0FSTihJOTE1X1JFQUQoSFNXX1BXUl9XRUxMX0RSSVZFUiksICJQb3dlciB3ZWxs IG9uXG4iKTsKPiA+ICAJSTkxNV9TVEFURV9XQVJOKEk5MTVfUkVBRChTUExMX0NUTCkgJiBTUExM X1BMTF9FTkFCTEUsICJTUExMIGVuYWJsZWRcbiIpOwo+ID4gLQlJOTE1X1NUQVRFX1dBUk4oSTkx NV9SRUFEKFdSUExMX0NUTDEpICYgV1JQTExfUExMX0VOQUJMRSwgIldSUExMMSBlbmFibGVkXG4i KTsKPiA+IC0JSTkxNV9TVEFURV9XQVJOKEk5MTVfUkVBRChXUlBMTF9DVEwyKSAmIFdSUExMX1BM TF9FTkFCTEUsICJXUlBMTDIgZW5hYmxlZFxuIik7Cj4gPiArCUk5MTVfU1RBVEVfV0FSTihJOTE1 X1JFQUQoV1JQTExfQ1RMKDApKSAmIFdSUExMX1BMTF9FTkFCTEUsICJXUlBMTDEgZW5hYmxlZFxu Iik7Cj4gPiArCUk5MTVfU1RBVEVfV0FSTihJOTE1X1JFQUQoV1JQTExfQ1RMKDEpKSAmIFdSUExM X1BMTF9FTkFCTEUsICJXUlBMTDIgZW5hYmxlZFxuIik7Cj4gPiAgCUk5MTVfU1RBVEVfV0FSTihJ OTE1X1JFQUQoUENIX1BQX1NUQVRVUykgJiBQUF9PTiwgIlBhbmVsIHBvd2VyIG9uXG4iKTsKPiA+ ICAJSTkxNV9TVEFURV9XQVJOKEk5MTVfUkVBRChCTENfUFdNX0NQVV9DVEwyKSAmIEJMTV9QV01f RU5BQkxFLAo+ID4gIAkgICAgICJDUFUgUFdNMSBlbmFibGVkXG4iKTsKPiA+IC0tIAo+ID4gMi40 LjYKPiA+Cj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNo bm9sb2d5IENlbnRlcgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK