From: David Weinehall <david.weinehall@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 2/4] lib: Skip suspend/hibernate tests if the system doesn't support them
Date: Tue, 27 Oct 2015 08:58:17 +0200 [thread overview]
Message-ID: <20151027065817.GH2504@boom> (raw)
In-Reply-To: <562A8CF3.2080900@virtuousgeek.org>
On Fri, Oct 23, 2015 at 12:39:31PM -0700, Jesse Barnes wrote:
> On 10/22/2015 01:35 PM, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Do a dry run with rtcwake first to determine if the system even supports
> > the intended suspend state. If not, skip the test.
> >
> > Fixes a bunch of stuff on my BYT FFRD8 that doesn't support S3.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > lib/igt_aux.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> > index 04ca25b..f3c76ae 100644
> > --- a/lib/igt_aux.c
> > +++ b/lib/igt_aux.c
> > @@ -357,6 +357,9 @@ void igt_system_suspend_autoresume(void)
> > * seems to fare better. We need to investigate what's going on. */
> > igt_skip_on_simulation();
> >
> > + /* skip if system doesn't support suspend-to-mem */
> > + igt_skip_on(system("rtcwake -n -s 30 -m mem") != 0);
> > +
> > ret = system("rtcwake -s 30 -m mem");
> > igt_assert_f(ret == 0,
> > "This failure means that something is wrong with the "
> > @@ -384,6 +387,9 @@ void igt_system_hibernate_autoresume(void)
> > * seems to fare better. We need to investigate what's going on. */
> > igt_skip_on_simulation();
> >
> > + /* skip if system doesn't support suspend-to-disk */
> > + igt_skip_on(system("rtcwake -n -s 90 -m disk") != 0);
> > +
> > /* The timeout might need to be adjusted if hibernation takes too long
> > * or if we have to wait excessively long before resume
> > */
> >
>
> Are there reliable alternatives to the rtcwake alarm?
> Maybe some AMT/MEI wakeup event or some ACPI clock thing (handwaving pretty hard here)?
Depending on what the hardware supports, for hibernate to disk there's ipmi power-on.
ipmi-power -h $hostname --stat will show the status of the machine,
ipmi-power -h $hostname --on will power it on.
Maybe wake-on-lan could be an option too?
Kind regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-27 6:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 20:35 [PATCH i-g-t 1/4] tests/kms_pipe_crc_basic: Skip invalid pipe/port combos ville.syrjala
2015-10-22 20:35 ` [PATCH i-g-t 2/4] lib: Skip suspend/hibernate tests if the system doesn't support them ville.syrjala
2015-10-22 23:05 ` Daniel Vetter
2015-10-23 19:39 ` Jesse Barnes
2015-10-27 6:58 ` David Weinehall [this message]
2015-10-27 17:02 ` Jesse Barnes
2015-10-28 9:08 ` David Weinehall
2015-10-27 17:29 ` Ville Syrjälä
2015-10-28 9:10 ` David Weinehall
2015-10-22 20:35 ` [PATCH i-g-t 3/4] tests/kms_flip: Improve the accuracy of out frame time calculation ville.syrjala
2015-10-22 20:35 ` [PATCH i-g-t 4/4] tests/kms_flip: Dump the timestamps, counters, etc. with higher debug levels ville.syrjala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027065817.GH2504@boom \
--to=david.weinehall@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox