Re: [PATCH] drm/i915: Make sure fb objects with rotated views are also fenceable

Chris Wilson
2015-09-12T07:49:13Z

On Fri, Sep 11, 2015 at 06:44:26PM -0700, Vivek Kasireddy wrote:
> From: Vivek Kasireddy <vivek.kasireddy@intel.com>
>
> Currently, fb objects with rotated views are ignored while pinning. Therefore,
> include the rotated view type and use the view size instead of the object's
> size to determine if it is fenceable. And, look at the view and its offset
> while writing and pinning to the fence registers.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Matthew D Roper <matthew.d.roper@intel.com>
> Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>

No. The fenceable decision needs only be made on the vma, which can be
separate for rotated views, partial views etc.

As usual I have such a patch...
-Chris

--
Chris Wilson, Intel Open Source Technology Centre