From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 09/14] drm/i915: Hide underruns from eDP PLL and port enable on ILK Date: Thu, 29 Oct 2015 23:33:57 +0200 Message-ID: <20151029213357.GZ4437@intel.com> References: <1446146763-31821-1-git-send-email-ville.syrjala@linux.intel.com> <1446146763-31821-10-git-send-email-ville.syrjala@linux.intel.com> <56327609.5000909@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id CD19A6E0E2 for ; Thu, 29 Oct 2015 14:34:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <56327609.5000909@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMjksIDIwMTUgYXQgMTI6Mzk6NTNQTSAtMDcwMCwgSmVzc2UgQmFybmVzIHdy b3RlOgo+IE9uIDEwLzI5LzIwMTUgMTI6MjUgUE0sIHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+IAo+ID4gV2UgZ2V0IHVuZGVycnVucyBvbiB0aGUgb3RoZXIgcGlwZSB3 aGVuIGVuYWJsaW5nIHRoZSBDUFUgZURQIFBMTCBhbmQKPiA+IHBvcnQgb24gSUxLLgo+ID4gCj4g PiBCc3BlYyBrbm93cyBhYm91dCB0aGUgUExMIGlzc3VlLCBhbmQgcmVjb21tZW5kcyBkb2luZyBh IHZibGFuayB3YWl0IGp1c3QKPiA+IHByaW9yIHRvIGVuYWJsaW5nIHRoZSBQTEwuIFRoYXQgZG9l cyBzZWVtIHRvIGhlbHAsIGJ1dCB1bmZvcnR1bmF0ZWx5IHdlCj4gPiBnZXQgYW5vdGhlciB1bmRl cnJ1biB3aGVuIGFjdHVhbGx5IGVuYWJsaW5nIHRoZSBDUFUgZURQIHBvcnQuIEJzcGVjCj4gPiBk b2Vzbid0IG1lbnRpb24gdGhhdCBhdCBhbGwsIGFuZCB0aGUgc2FtZSB2Ymxhbmsgd2FpdCB0cmlj ayBkb2Vzbid0Cj4gPiBhcHBlYXIgdG8gYmUgZWZmZWN0aXZlIHRoZXJlLgo+ID4gCj4gPiBTaW5j ZSBJIGhhdmUgbm8gYmV0dGVyIGNsdWUgaG93IHRvIGRlYWwgd2l0aCB0aGlzLCBqdXN0IGhpZGUg dGhlIGVycm9ycy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMgfCAzNCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPiAK PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gaW5kZXggNGEwZmI2My4uMGI5YjQ0MCAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IEBAIC0yNTc1LDYgKzI1NzUsOCBAQCBz dGF0aWMgdm9pZCBpbnRlbF9lbmFibGVfZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIp Cj4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZh dGU7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxfY3J0YyhlbmNvZGVy LT5iYXNlLmNydGMpOwo+ID4gIAl1aW50MzJfdCBkcF9yZWcgPSBJOTE1X1JFQUQoaW50ZWxfZHAt Pm91dHB1dF9yZWcpOwo+ID4gKwllbnVtIHBvcnQgcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVs X2RwKS0+cG9ydDsKPiA+ICsJZW51bSBwaXBlIHBpcGUgPSBjcnRjLT5waXBlOwo+ID4gIAo+ID4g IAlpZiAoV0FSTl9PTihkcF9yZWcgJiBEUF9QT1JUX0VOKSkKPiA+ICAJCXJldHVybjsKPiA+IEBA IC0yNTg2LDYgKzI1ODgsMTcgQEAgc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX2RwKHN0cnVjdCBp bnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ID4gIAo+ID4gIAlpbnRlbF9kcF9lbmFibGVfcG9ydChp bnRlbF9kcCk7Cj4gPiAgCj4gPiArCWlmIChwb3J0ID09IFBPUlRfQSAmJiBJU19HRU41KGRldl9w cml2KSkgewo+ID4gKwkJLyoKPiA+ICsJCSAqIFVuZGVycnVuIHJlcG9ydGluZyBmb3IgdGhlIG90 aGVyIHBpcGUgd2FzIGRpc2FibGVkIGluCj4gPiArCQkgKiBnNHhfcHJlX2VuYWJsZV9kcCgpLiBU aGUgZURQIFBMTCBhbmQgcG9ydCBoYXZlIG5vdyBiZWVuCj4gPiArCQkgKiBlbmFibGVkLCBzbyBp dCdzIG5vdyBzYWZlIHRvIHJlLWVuYWJsZSB1bmRlcnJ1biByZXBvcnRpbmcuCj4gPiArCQkgKi8K PiA+ICsJCWludGVsX3dhaXRfZm9yX3ZibGFua19pZl9hY3RpdmUoZGV2X3ByaXYtPmRldiwgIXBp cGUpOwo+ID4gKwkJaW50ZWxfc2V0X2NwdV9maWZvX3VuZGVycnVuX3JlcG9ydGluZyhkZXZfcHJp diwgIXBpcGUsIHRydWUpOwo+ID4gKwkJaW50ZWxfc2V0X3BjaF9maWZvX3VuZGVycnVuX3JlcG9y dGluZyhkZXZfcHJpdiwgIXBpcGUsIHRydWUpOwo+ID4gKwl9Cj4gPiArCj4gPiAgCWVkcF9wYW5l bF92ZGRfb24oaW50ZWxfZHApOwo+ID4gIAllZHBfcGFuZWxfb24oaW50ZWxfZHApOwo+ID4gIAll ZHBfcGFuZWxfdmRkX29mZihpbnRlbF9kcCwgdHJ1ZSk7Cj4gPiBAQCAtMjYwOCw3ICsyNjIxLDcg QEAgc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX2RwKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNv ZGVyKQo+ID4gIAo+ID4gIAlpZiAoY3J0Yy0+Y29uZmlnLT5oYXNfYXVkaW8pIHsKPiA+ICAJCURS TV9ERUJVR19EUklWRVIoIkVuYWJsaW5nIERQIGF1ZGlvIG9uIHBpcGUgJWNcbiIsCj4gPiAtCQkJ CSBwaXBlX25hbWUoY3J0Yy0+cGlwZSkpOwo+ID4gKwkJCQkgcGlwZV9uYW1lKHBpcGUpKTsKPiA+ ICAJCWludGVsX2F1ZGlvX2NvZGVjX2VuYWJsZShlbmNvZGVyKTsKPiA+ICAJfQo+ID4gIH0KPiA+ IEBAIC0yNjMxLDEzICsyNjQ0LDI4IEBAIHN0YXRpYyB2b2lkIHZsdl9lbmFibGVfZHAoc3RydWN0 IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gPiAgCj4gPiAgc3RhdGljIHZvaWQgZzR4X3ByZV9l bmFibGVfZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gPiAgewo+ID4gKwlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2 KTsKPiA+ICAJc3RydWN0IGludGVsX2RwICppbnRlbF9kcCA9IGVuY190b19pbnRlbF9kcCgmZW5j b2Rlci0+YmFzZSk7Cj4gPiAtCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRwb3J0ID0gZHBf dG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+ID4gKwllbnVtIHBvcnQgcG9ydCA9IGRwX3RvX2RpZ19w b3J0KGludGVsX2RwKS0+cG9ydDsKPiA+ICsJZW51bSBwaXBlIHBpcGUgPSB0b19pbnRlbF9jcnRj KGVuY29kZXItPmJhc2UuY3J0YyktPnBpcGU7Cj4gPiAgCj4gPiAgCWludGVsX2RwX3ByZXBhcmUo ZW5jb2Rlcik7Cj4gPiAgCj4gPiArCWlmIChwb3J0ID09IFBPUlRfQSAmJiBJU19HRU41KGRldl9w cml2KSkgewo+ID4gKwkJLyoKPiA+ICsJCSAqIFdlIGdldCBGSUZPIHVuZGVycnVucyBvbiB0aGUg b3RoZXIgcGlwZSB3aGVuCj4gPiArCQkgKiBlbmFibGluZyB0aGUgQ1BVIGVEUCBQTEwsIGFuZCB3 aGVuIGVuYWJsaW5nIENQVQo+ID4gKwkJICogZURQIHBvcnQuIFdlIGNvdWxkIHBvdGVudGlhbGx5 IGF2b2lkIHRoZSBQTEwKPiA+ICsJCSAqIHVuZGVycnVuIHdpdGggYSB2Ymxhbmsgd2FpdCBqdXN0 IHByaW9yIHRvIGVuYWJsaW5nCj4gPiArCQkgKiB0aGUgUExMLCBidXQgdGhhdCBkb2Vzbid0IGFw cGVhciB0byBoZWxwIHRoZSBwb3J0Cj4gPiArCQkgKiBlbmFibGUgY2FzZS4gSnVzdCBzd2VlcCBp dCBhbGwgdW5kZXIgdGhlIHJ1Zy4KPiA+ICsJCSAqLwo+ID4gKwkJaW50ZWxfc2V0X2NwdV9maWZv X3VuZGVycnVuX3JlcG9ydGluZyhkZXZfcHJpdiwgIXBpcGUsIGZhbHNlKTsKPiA+ICsJCWludGVs X3NldF9wY2hfZmlmb191bmRlcnJ1bl9yZXBvcnRpbmcoZGV2X3ByaXYsICFwaXBlLCBmYWxzZSk7 Cj4gPiArCX0KPiA+ICsKPiA+ICAJLyogT25seSBpbGsrIGhhcyBwb3J0IEEgKi8KPiA+IC0JaWYg KGRwb3J0LT5wb3J0ID09IFBPUlRfQSkgewo+ID4gKwlpZiAocG9ydCA9PSBQT1JUX0EpIHsKPiA+ ICAJCWlyb25sYWtlX3NldF9wbGxfY3B1X2VkcChpbnRlbF9kcCk7Cj4gPiAgCQlpcm9ubGFrZV9l ZHBfcGxsX29uKGludGVsX2RwKTsKPiA+ICAJfQo+ID4gCj4gCj4gV2lzaCB3ZSBoYWQgYSBuaWNl IGhvb2sgdG8gaGlkZSB0aGUgZ2VuNSBiaXRzIHNvbWV3aGVyZSBiZXR0ZXIsIGJ1dCBpdCdzCj4g ZmluZSBhcyBpcyB3aXRoIHRoZSBjb21tZW50LgoKSSBkaWQgY29uc2lkZXIgYWRkaW5nIGlsa19w cmVfZW5hYmxlX2RwIGFuZCBpbGtfZW5hYmxlX2RwIGZvciB0aGlzLCBidXQgSQpkZWNpZGVkIHRo YXQgaXQgd291bGQgYmUgbW9yZSBjb25mdXNpbmcgc2luY2UgdGhlbiBib3RoIHByZS1pbGsgKGc0 eCkgYW5kCnBvc3QtaWxrIChzbmIrKSB3b3VsZCB1c2UgdGhlIGc0eCBmdW5jdGlvbnMuCgpJIGRp ZCBtYW5hZ2UgdG8gY29uZnVzZSBteXNlbGYgYWxyZWFkeSBvbmNlIHdpdGggdGhlIGc0eCB2cy4g cGNoIHZzLgpwbGF0Zm9ybSBzcGVjaWZpYyB2cy4gdG90YWxseSBnZW5lcmljIGhvb2tzIHdlIGhh dmUgZm9yIHNvbWUgcG9ydAp0eXBlcy4gU28gaXQgbWlnaHQgbWFrZSBzZW5zZSB0byB0YWtlIGEg c21hbGwgY29kZSBkdXBsaWNhdGlvbiBoaXQsCmFuZCBqdXN0IG1ha2Ugc3VyZSB0aGVyZSBpcyBh bHdheXMgYSBmdWxsIHNldCBvZiBob29rIHdpdGggdGhlIHNhbWUKcHJlZml4LCBldmVuIGlmIHNv bWUgb2YgdGhvc2UgZG8gZXhhY3RseSB0aGUgc2FtZSB0aGluZy4KCj4gCj4gUmV2aWV3ZWQtYnk6 IEplc3NlIEJhcm5lcyA8amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgoKLS0gClZpbGxlIFN5cmrD pGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK