public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Ander Conselvan De Oliveira <conselvan2@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
	Adebisi YetundeX <yetundex.adebisi@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/dp: add eDP DPCD backlight control bit definitions
Date: Fri, 30 Oct 2015 11:37:35 +0100	[thread overview]
Message-ID: <20151030103735.GW16848@phenom.ffwll.local> (raw)
In-Reply-To: <1446121652.4272.2.camel@gmail.com>

On Thu, Oct 29, 2015 at 02:27:32PM +0200, Ander Conselvan De Oliveira wrote:
> On Thu, 2015-10-29 at 11:03 +0200, Jani Nikula wrote:
> > Cc: Yetunde Adebisi <yetundex.adebisi@intel.com>
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > ---
> >  include/drm/drm_dp_helper.h | 36 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> > 
> > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> > index bb9d0deca07c..1252108da0ef 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -455,16 +455,52 @@
> >  # define DP_EDP_14			    0x03
> >  
> >  #define DP_EDP_GENERAL_CAP_1		    0x701
> > +# define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP		(1 << 0)
> > +# define DP_EDP_BACKLIGHT_PIN_ENABLE_CAP		(1 << 1)
> > +# define DP_EDP_BACKLIGHT_AUX_ENABLE_CAP		(1 << 2)
> > +# define DP_EDP_PANEL_SELF_TEST_PIN_ENABLE_CAP		(1 << 3)
> > +# define DP_EDP_PANEL_SELF_TEST_AUX_ENABLE_CAP		(1 << 4)
> > +# define DP_EDP_FRC_ENABLE_CAP				(1 << 5)
> > +# define DP_EDP_COLOR_ENGINE_CAP			(1 << 6)
> > +# define DP_EDP_SET_POWER_CAP				(1 << 7)
> >  
> >  #define DP_EDP_BACKLIGHT_ADJUSTMENT_CAP     0x702
> > +# define DP_EDP_BACKLIGHT_BRIGHTNESS_PWM_PIN_CAP	(1 << 0)
> > +# define DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP	(1 << 1)
> > +# define DP_EDP_BACKLIGHT_BRIGHTNESS_BYTE_COUNT		(1 << 2)
> > +# define DP_EDP_BACKLIGHT_AUX_PWM_PRODUCT_CAP		(1 << 3)
> > +# define DP_EDP_BACKLIGHT_FREQ_PWM_PIN_PASSTHRU_CAP	(1 << 4)
> > +# define DP_EDP_BACKLIGHT_FREQ_AUX_SET_CAP		(1 << 5)
> > +# define DP_EDP_DYNAMIC_BACKLIGHT_CAP			(1 << 6)
> > +# define DP_EDP_VBLANK_BACKLIGHT_UPDATE_CAP		(1 << 7)
> >  
> >  #define DP_EDP_GENERAL_CAP_2		    0x703
> > +# define DP_EDP_OVERDRIVE_ENGINE_ENABLED		(1 << 0)
> >  
> >  #define DP_EDP_GENERAL_CAP_3		    0x704    /* eDP 1.4 */
> > +# define DP_EDP_X_REGION_CAP_MASK			(0xf << 0)
> > +# define DP_EDP_X_REGION_CAP_SHIFT			0
> > +# define DP_EDP_Y_REGION_CAP_MASK			(0xf << 4)
> > +# define DP_EDP_Y_REGION_CAP_SHIFT			4
> >  
> >  #define DP_EDP_DISPLAY_CONTROL_REGISTER     0x720
> > +# define DP_EDP_BACKLIGHT_ENABLE			(1 << 0)
> > +# define DP_EDP_BLACK_VIDEO_ENABLE			(1 << 1)
> > +# define DP_EDP_FRC_ENABLE				(1 << 2)
> > +# define DP_EDP_COLOR_ENGINE_ENABLE			(1 << 3)
> > +# define DP_EDP_VBLANK_BACKLIGHT_UPDATE_ENABLE		(1 << 7)
> >  
> >  #define DP_EDP_BACKLIGHT_MODE_SET_REGISTER  0x721
> > +# define DP_EDP_BACKLIGHT_CONTROL_MODE_MASK		(3 << 0)
> > +# define DP_EDP_BACKLIGHT_CONTROL_MODE_PWM		(0 << 0)
> > +# define DP_EDP_BACKLIGHT_CONTROL_MODE_PRESET		(1 << 0)
> > +# define DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD		(2 << 0)
> > +# define DP_EDP_BACKLIGHT_CONTROL_MODE_PRODUCT		(3 << 0)
> > +# define DP_EDP_BACKLIGHT_FREQ_PWM_PIN_PASSTHRU_ENABLE	(1 << 2)
> > +# define DP_EDP_BACKLIGHT_FREQ_AUX_SET_ENABLE		(1 << 3)
> > +# define DP_EDP_DYNAMIC_BACKLIGHT_ENABLE		(1 << 4)
> > +# define DP_EDP_REGIONAL_BACKLIGHT_ENABLE		(1 << 5)
> 
> Doesn't DP_EDP_REGIONAL_BACKLIGHT_ENABLE need a /* eDP 1.4 */ comment too?
> 
> Anyway, it all matches the spec so,
> 
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

Applied to drm-misc, thanks.
-Daniel

> 
> > +# define DP_EDP_UPDATE_REGION_BRIGHTNESS		(1 << 6) /* eDP 1.4
> > */
> >  
> >  #define DP_EDP_BACKLIGHT_BRIGHTNESS_MSB     0x722
> >  #define DP_EDP_BACKLIGHT_BRIGHTNESS_LSB     0x723
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2015-10-30 10:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29  9:03 [PATCH] drm/dp: add eDP DPCD backlight control bit definitions Jani Nikula
2015-10-29 12:27 ` Ander Conselvan De Oliveira
2015-10-30 10:37   ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151030103735.GW16848@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=conselvan2@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=yetundex.adebisi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox