From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v6 3/4] drm/i915: Fix failure paths around initial fbdev allocation Date: Fri, 30 Oct 2015 19:28:18 +0100 Message-ID: <20151030182818.GR16848@phenom.ffwll.local> References: <20151015173423.GK26517@intel.com> <4a4f691ea23a9a3f84afc47928c81e681cfd6fc7.1445771693.git.lukas@wunner.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D7966ED4F for ; Fri, 30 Oct 2015 11:28:23 -0700 (PDT) Received: by wicll6 with SMTP id ll6so16216409wic.1 for ; Fri, 30 Oct 2015 11:28:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4a4f691ea23a9a3f84afc47928c81e681cfd6fc7.1445771693.git.lukas@wunner.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lukas Wunner Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdW4gMzAsIDIwMTUgYXQgMTA6MDY6MjdBTSArMDEwMCwgTHVrYXMgV3VubmVyIHdy b3RlOgo+IEZyb206IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4g Cj4gV2UgaGFkIHR3byBmYWlsdXJlIG1vZGVzIGhlcmU6Cj4gCj4gMS4KPiBEZWFkbG9jayBpbiBp bnRlbGZiX2FsbG9jIGZhaWx1cmUgcGF0aCB3aGVyZSBpdCBjYWxscwo+IGRybV9mcmFtZWJ1ZmZl cl9yZW1vdmUsIHdoaWNoIGdyYWJzIHRoZSBzdHJ1Y3QgbXV0ZXggYW5kIGludGVsZmJfY3JlYXRl Cj4gKGNhbGxlciBvZiBpbnRlbGZiX2FsbG9jKSB3YXMgYWxyZWFkeSBob2xkaW5nIGl0Lgo+IAo+ IDIuCj4gRGVhZGxvY2sgaW4gaW50ZWxmYl9jcmVhdGUgZmFpbHVyZSBwYXRoIHdoZXJlIGl0IGNh bGxzCj4gZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlLCB3aGljaCBncmFicyB0aGUgc3RydWN0 IG11dGV4IGFuZAo+IGludGVsZmJfY3JlYXRlIHdhcyBhbHJlYWR5IGhvbGRpbmcgaXQuCj4gCj4g W0NocmlzIFdpbHNvbiBvbiB3aHkgc3RydWN0X211dGV4IG5lZWRzIHRvIGJlIGxvY2tlZCBpbiB0 aGUgc2Vjb25kIGhhbGYKPiBvZiBpbnRlbGZiX2NyZWF0ZTogInRoZXJlIGlzIGEgYnVnIGhlcmUg d2hlcmUgd2UgZG9uJ3QgdGFrZSBhbiBleHBsaWNpdAo+IHBpbiBvbiB0aGUgVk1BIHdlIHNldHVw IGZvciB0aGUgZmJkZXYgd2hpY2ggcmVxdWlyZXMgdGhlIGxvY2suIl0KClRoZSB2bWEgaXMgcGlu bmVkLCB0aGUgcHJvYmxlbSBpcyB0aGF0IHdlIHJlLWxvb2t1cCBpdCBhIGZldyB0aW1lcywgd2hp Y2gKaXMgcmFjeS4gV2Ugc2hvdWxkIGluc3RlYWQgdHJhY2sgdGhlIHZtYSBkaXJlY3RseSwgYnV0 IG9oIHdlbGwgd2UgZG9uJ3QuCgpXaXRoIHRoYXQgY2xhcmlmaWVkIGluIHRoZSBjb21taXQgbWVz c2FnZSB0aGlzIGlzCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4KPiAKPiB2MjoKPiAgICAqIFJlZm9ybWF0IGNvbW1pdCBtc2cgdG8gNzIgY2hhcnMu IChMdWthcyBXdW5uZXIpCj4gICAgKiBBZGQgdGhpcmQgZmFpbHVyZSBtb2RlLiAoTHVrYXMgV3Vu bmVyKQo+IAo+IHY1Ogo+ICAgICogUmViYXNlIG9uIGRybS1pbnRlbC1uaWdodGx5IDIwMTV5LTA5 bS0wMWQtMDloLTA2bS0wOHMgVVRDLAo+ICAgICAgcmVwaHJhc2UgY29tbWl0IG1lc3NhZ2UuIChK YW5pIE5pY3VsYSkKPiAKPiB2NjoKPiAgICAqIEluIGludGVsZmJfYWxsb2MsIGlmIF9faW50ZWxf ZnJhbWVidWZmZXJfY3JlYXRlIGZhaWxlZCwKPiAgICAgIGZiIHdpbGwgYmUgYW4gRVJSX1BUUiwg dGh1cyBub3QgbnVsbC4gU28gaW4gdGhlIGZhaWx1cmUKPiAgICAgIHBhdGggd2UgbmVlZCB0byBj aGVjayBmb3IgSVNfRVJSX09SX05VTEwgdG8gYXZvaWQgY2FsbGluZwo+ICAgICAgZHJtX2ZyYW1l YnVmZmVyX3JlbW92ZSBvbiB0aGUgRVJSX1BUUi4gKEx1a2FzIFd1bm5lcikKPiAgICAqIFNpbmNl IHRoaXMgaXMgaW5pdCBjb2RlIGEgZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlIHNob3VsZAo+ ICAgICAgYmUgYWxsIHdlIG5lZWQuIGRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUgaXMgZm9yIGZyYW1l YnVmZmVycwo+ICAgICAgdGhhdCB1c2Vyc3BhY2UgaGFzIGNyZWF0ZWQgLSBhbmQgaXMgZ2V0dGlu ZyBzb21ld2hhdAo+ICAgICAgZGVmZWF0dXJlZC4gKERhbmllbCBWZXR0ZXIpCj4gCj4gU2lnbmVk LW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBGaXhl czogNjBhNWNhMDE1ZmZkICgiZHJtL2k5MTU6IEFkZCBsb2NraW5nIGFyb3VuZAo+ICAgICBmcmFt ZWJ1ZmZlcl9yZWZlcmVuY2VzLS0iKQo+IFJlcG9ydGVkLWJ5OiBMdWthcyBXdW5uZXIgPGx1a2Fz QHd1bm5lci5kZT4KPiBbTHVrYXM6IENyZWF0ZSB2MyArIHY0ICsgdjUgKyB2NiBiYXNlZCBvbiBU dnJ0a28ncyB2Ml0KPiBTaWduZWQtb2ZmLWJ5OiBMdWthcyBXdW5uZXIgPGx1a2FzQHd1bm5lci5k ZT4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgfCAyMCArKysrKysrKysrKystLS0tLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiBpbmRleCBlYzgyYjUxLi4xMjU5N2I1IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gQEAgLTExOSw3ICsxMTksNyBAQCBz dGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAg ewo+ICAJc3RydWN0IGludGVsX2ZiZGV2ICppZmJkZXYgPQo+ICAJCWNvbnRhaW5lcl9vZihoZWxw ZXIsIHN0cnVjdCBpbnRlbF9mYmRldiwgaGVscGVyKTsKPiAtCXN0cnVjdCBkcm1fZnJhbWVidWZm ZXIgKmZiOwo+ICsJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBOVUxMOwo+ICAJc3RydWN0 IGRybV9kZXZpY2UgKmRldiA9IGhlbHBlci0+ZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICAJc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIg bW9kZV9jbWQgPSB7fTsKPiBAQCAtMTM4LDYgKzEzOCw4IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9h bGxvYyhzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICAJbW9kZV9jbWQucGl4ZWxfZm9y bWF0ID0gZHJtX21vZGVfbGVnYWN5X2ZiX2Zvcm1hdChzaXplcy0+c3VyZmFjZV9icHAsCj4gIAkJ CQkJCQkgIHNpemVzLT5zdXJmYWNlX2RlcHRoKTsKPiAgCj4gKwltdXRleF9sb2NrKCZkZXYtPnN0 cnVjdF9tdXRleCk7Cj4gKwo+ICAJc2l6ZSA9IG1vZGVfY21kLnBpdGNoZXNbMF0gKiBtb2RlX2Nt ZC5oZWlnaHQ7Cj4gIAlzaXplID0gUEFHRV9BTElHTihzaXplKTsKPiAgCj4gQEAgLTE2NSwxNiAr MTY3LDE5IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9hbGxvYyhzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAq aGVscGVyLAo+ICAJcmV0ID0gaW50ZWxfcGluX2FuZF9mZW5jZV9mYl9vYmooTlVMTCwgZmIsIE5V TEwsIE5VTEwsIE5VTEwpOwo+ICAJaWYgKHJldCkgewo+ICAJCURSTV9FUlJPUigiZmFpbGVkIHRv IHBpbiBvYmo6ICVkXG4iLCByZXQpOwo+IC0JCWdvdG8gb3V0X2ZiOwo+ICsJCWdvdG8gb3V0Owo+ ICAJfQo+ICAKPiArCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsKPiAgCWlm YmRldi0+ZmIgPSB0b19pbnRlbF9mcmFtZWJ1ZmZlcihmYik7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4g IAo+IC1vdXRfZmI6Cj4gLQlkcm1fZnJhbWVidWZmZXJfcmVtb3ZlKGZiKTsKPiAgb3V0Ogo+ICsJ bXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwlpZiAoIUlTX0VSUl9PUl9OVUxM KGZiKSkKPiArCQlkcm1fZnJhbWVidWZmZXJfdW5yZWZlcmVuY2UoZmIpOwo+ICAJcmV0dXJuIHJl dDsKPiAgfQo+ICAKPiBAQCAtMTkyLDggKzE5Nyw2IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9jcmVh dGUoc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCWludCBzaXplLCByZXQ7Cj4gIAli b29sIHByZWFsbG9jID0gZmFsc2U7Cj4gIAo+IC0JbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0 ZXgpOwo+IC0KPiAgCWlmIChpbnRlbF9mYiAmJgo+ICAJICAgIChzaXplcy0+ZmJfd2lkdGggPiBp bnRlbF9mYi0+YmFzZS53aWR0aCB8fAo+ICAJICAgICBzaXplcy0+ZmJfaGVpZ2h0ID4gaW50ZWxf ZmItPmJhc2UuaGVpZ2h0KSkgewo+IEBAIC0yMDgsNyArMjExLDcgQEAgc3RhdGljIGludCBpbnRl bGZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICAJCURSTV9ERUJVR19L TVMoIm5vIEJJT1MgZmIsIGFsbG9jYXRpbmcgYSBuZXcgb25lXG4iKTsKPiAgCQlyZXQgPSBpbnRl bGZiX2FsbG9jKGhlbHBlciwgc2l6ZXMpOwo+ICAJCWlmIChyZXQpCj4gLQkJCWdvdG8gb3V0X3Vu bG9jazsKPiArCQkJcmV0dXJuIHJldDsKPiAgCQlpbnRlbF9mYiA9IGlmYmRldi0+ZmI7Cj4gIAl9 IGVsc2Ugewo+ICAJCURSTV9ERUJVR19LTVMoInJlLXVzaW5nIEJJT1MgZmJcbiIpOwo+IEBAIC0y MjAsNiArMjIzLDggQEAgc3RhdGljIGludCBpbnRlbGZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hl bHBlciAqaGVscGVyLAo+ICAJb2JqID0gaW50ZWxfZmItPm9iajsKPiAgCXNpemUgPSBvYmotPmJh c2Uuc2l6ZTsKPiAgCj4gKwltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwo+ICAJ aW5mbyA9IGRybV9mYl9oZWxwZXJfYWxsb2NfZmJpKGhlbHBlcik7Cj4gIAlpZiAoSVNfRVJSKGlu Zm8pKSB7Cj4gIAkJcmV0ID0gUFRSX0VSUihpbmZvKTsKPiBAQCAtMjgxLDcgKzI4Niw2IEBAIG91 dF9kZXN0cm95X2ZiaToKPiAgb3V0X3VucGluOgo+ICAJaTkxNV9nZW1fb2JqZWN0X2dndHRfdW5w aW4ob2JqKTsKPiAgCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+IC1v dXRfdW5sb2NrOgo+ICAJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gIAlyZXR1 cm4gcmV0Owo+ICB9Cj4gLS0gCj4gMS44LjUuMiAoQXBwbGUgR2l0LTQ4KQo+IAo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK