From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH 32/43] drm/i915: Clean up LVDS register handling Date: Sun, 1 Nov 2015 16:33:57 +0100 Message-ID: <20151101153357.GA21423@wunner.de> References: <1442595836-23981-1-git-send-email-ville.syrjala@linux.intel.com> <1442595836-23981-33-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout3.hostsharing.net (mailout3.hostsharing.net [176.9.242.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA5F86E061 for ; Sun, 1 Nov 2015 07:34:03 -0800 (PST) Content-Disposition: inline In-Reply-To: <1442595836-23981-33-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgVmlsbGUsCgpPbiBGcmksIFNlcCAxOCwgMjAxNSBhdCAwODowMzo0NVBNICswMzAwLCB2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IAo+IEtlZXAgc2luZ2xlICdsdmRzX3Jl ZycgYW5kICdsdmRzJyB2YXJpYWJsZSBhcm91bmQgaW4KPiBpbnRlbF9sdmRzX2luaXQoKSwgYW5k IHJlYWQgaXQganVzdCBvbmNlIGF0IHRoZSBzdGFydC4KCkhtLCBpcyBpdCBpbnRlbnRpb25hbCB0 aGF0IHlvdSBkaWRuJ3QgYWxzbyByZXBsYWNlIHRoaXMgcmVnaXN0ZXIgcmVhZG91dAphdCB0aGUg ZW5kIG9mIHRoZSBmdW5jdGlvbj8KCglsdmRzX2VuY29kZXItPmEzX3Bvd2VyID0gSTkxNV9SRUFE KGx2ZHNfZW5jb2Rlci0+cmVnKSAmCgkJCQkgTFZEU19BM19QT1dFUl9NQVNLOwoKKFNvcnJ5LCBJ IG9ubHkgbm90aWNlZCB0aGlzIHRvZGF5LCBwb3N0LW1lcmdlLCB3aGlsZSByZWJhc2luZyBteSBM VkRTCnJlcHJvYmluZyBzdHVmZi4pCgpCZXN0IHJlZ2FyZHMsCgpMdWthcwoKPiAKPiBBbHNvIGlu dGVsX2x2ZHNfZ2V0X2NvbmZpZygpIGRvZXNuJ3QgbmVlZCB0byBmaWd1cmUgb3V0IHdoaWNoIHJl ZyB0byB1c2UKPiBzaW5jZSBpdCBjYW4ganVzdCBjb25zdWx0IGx2ZHNfZW5jb2Rlci0+cmVnLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2ZHMuYyB8IDMw ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5z ZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2x2ZHMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2ZHMu Ywo+IGluZGV4IDJjMmQxZjAuLjM1YmFkNzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfbHZkcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZk cy5jCj4gQEAgLTk4LDE1ICs5OCwxMSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9sdmRzX2dldF9jb25m aWcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2 aWNlICpkZXYgPSBlbmNvZGVyLT5iYXNlLmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gLQl1MzIgbHZkc19yZWcsIHRtcCwgZmxh Z3MgPSAwOwo+ICsJc3RydWN0IGludGVsX2x2ZHNfZW5jb2RlciAqbHZkc19lbmNvZGVyID0gdG9f bHZkc19lbmNvZGVyKCZlbmNvZGVyLT5iYXNlKTsKPiArCXUzMiB0bXAsIGZsYWdzID0gMDsKPiAg CWludCBkb3RjbG9jazsKPiAgCj4gLQlpZiAoSEFTX1BDSF9TUExJVChkZXYpKQo+IC0JCWx2ZHNf cmVnID0gUENIX0xWRFM7Cj4gLQllbHNlCj4gLQkJbHZkc19yZWcgPSBMVkRTOwo+IC0KPiAtCXRt cCA9IEk5MTVfUkVBRChsdmRzX3JlZyk7Cj4gKwl0bXAgPSBJOTE1X1JFQUQobHZkc19lbmNvZGVy LT5yZWcpOwo+ICAJaWYgKHRtcCAmIExWRFNfSFNZTkNfUE9MQVJJVFkpCj4gIAkJZmxhZ3MgfD0g RFJNX01PREVfRkxBR19OSFNZTkM7Cj4gIAllbHNlCj4gQEAgLTk0NCw2ICs5NDAsNyBAQCB2b2lk IGludGVsX2x2ZHNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJc3RydWN0IGRybV9k aXNwbGF5X21vZGUgKmRvd25jbG9ja19tb2RlID0gTlVMTDsKPiAgCXN0cnVjdCBlZGlkICplZGlk Owo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ICsJdTMyIGx2ZHNfcmVnOwo+ICAJdTMyIGx2 ZHM7Cj4gIAlpbnQgcGlwZTsKPiAgCXU4IHBpbjsKPiBAQCAtOTY2LDggKzk2MywxNSBAQCB2b2lk IGludGVsX2x2ZHNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJaWYgKGRtaV9jaGVj a19zeXN0ZW0oaW50ZWxfbm9fbHZkcykpCj4gIAkJcmV0dXJuOwo+ICAKPiArCWlmIChIQVNfUENI X1NQTElUKGRldikpCj4gKwkJbHZkc19yZWcgPSBQQ0hfTFZEUzsKPiArCWVsc2UKPiArCQlsdmRz X3JlZyA9IExWRFM7Cj4gKwo+ICsJbHZkcyA9IEk5MTVfUkVBRChsdmRzX3JlZyk7Cj4gKwo+ICAJ aWYgKEhBU19QQ0hfU1BMSVQoZGV2KSkgewo+IC0JCWlmICgoSTkxNV9SRUFEKFBDSF9MVkRTKSAm IExWRFNfREVURUNURUQpID09IDApCj4gKwkJaWYgKChsdmRzICYgTFZEU19ERVRFQ1RFRCkgPT0g MCkKPiAgCQkJcmV0dXJuOwo+ICAJCWlmIChkZXZfcHJpdi0+dmJ0LmVkcF9zdXBwb3J0KSB7Cj4g IAkJCURSTV9ERUJVR19LTVMoImRpc2FibGUgTFZEUyBmb3IgZURQIHN1cHBvcnRcbiIpOwo+IEBA IC05NzcsOCArOTgxLDcgQEAgdm9pZCBpbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9kZXZpY2Ug KmRldikKPiAgCj4gIAlwaW4gPSBHTUJVU19QSU5fUEFORUw7Cj4gIAlpZiAoIWx2ZHNfaXNfcHJl c2VudF9pbl92YnQoZGV2LCAmcGluKSkgewo+IC0JCXUzMiByZWcgPSBIQVNfUENIX1NQTElUKGRl dikgPyBQQ0hfTFZEUyA6IExWRFM7Cj4gLQkJaWYgKChJOTE1X1JFQUQocmVnKSAmIExWRFNfUE9S VF9FTikgPT0gMCkgewo+ICsJCWlmICgobHZkcyAmIExWRFNfUE9SVF9FTikgPT0gMCkgewo+ICAJ CQlEUk1fREVCVUdfS01TKCJMVkRTIGlzIG5vdCBwcmVzZW50IGluIFZCVFxuIik7Cj4gIAkJCXJl dHVybjsKPiAgCQl9Cj4gQEAgLTEwNTUsMTEgKzEwNTgsNyBAQCB2b2lkIGludGVsX2x2ZHNfaW5p dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJY29ubmVjdG9yLT5pbnRlcmxhY2VfYWxsb3dl ZCA9IGZhbHNlOwo+ICAJY29ubmVjdG9yLT5kb3VibGVzY2FuX2FsbG93ZWQgPSBmYWxzZTsKPiAg Cj4gLQlpZiAoSEFTX1BDSF9TUExJVChkZXYpKSB7Cj4gLQkJbHZkc19lbmNvZGVyLT5yZWcgPSBQ Q0hfTFZEUzsKPiAtCX0gZWxzZSB7Cj4gLQkJbHZkc19lbmNvZGVyLT5yZWcgPSBMVkRTOwo+IC0J fQo+ICsJbHZkc19lbmNvZGVyLT5yZWcgPSBsdmRzX3JlZzsKPiAgCj4gIAkvKiBjcmVhdGUgdGhl IHNjYWxpbmcgbW9kZSBwcm9wZXJ0eSAqLwo+ICAJZHJtX21vZGVfY3JlYXRlX3NjYWxpbmdfbW9k ZV9wcm9wZXJ0eShkZXYpOwo+IEBAIC0xMTQwLDcgKzExMzksNiBAQCB2b2lkIGludGVsX2x2ZHNf aW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJaWYgKEhBU19QQ0hfU1BMSVQoZGV2KSkK PiAgCQlnb3RvIGZhaWxlZDsKPiAgCj4gLQlsdmRzID0gSTkxNV9SRUFEKExWRFMpOwo+ICAJcGlw ZSA9IChsdmRzICYgTFZEU19QSVBFQl9TRUxFQ1QpID8gMSA6IDA7Cj4gIAljcnRjID0gaW50ZWxf Z2V0X2NydGNfZm9yX3BpcGUoZGV2LCBwaXBlKTsKPiAgCj4gLS0gCj4gMi40LjYKPiAKPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBt YWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=