From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bxt: Fix eDP panel fitting
Date: Wed, 4 Nov 2015 18:51:07 +0200 [thread overview]
Message-ID: <20151104165107.GU4437@intel.com> (raw)
In-Reply-To: <1446604181-32714-1-git-send-email-matthew.d.roper@intel.com>
On Tue, Nov 03, 2015 at 06:29:41PM -0800, Matt Roper wrote:
> BXT CRTC scaling uses the same gen9 codepaths as SKL; these codepaths
> store panel fitter information in pipe_config->pch_pfit. However since
> HAS_PCH_SPLIT() is false for BXT we never actually wind up filling in
> this structure (we wind up filling in pipe_config->gmch_pfit instead,
> which is ignored when we go to program the hardware). Make sure we
> always take the PCH code path on gen9+ platforms.
>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Chandra Konduru <chandra.konduru@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> Not a regression as far as I know; I believe this has been broken since BXT
> support was added to the driver.
>
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 1cb1f3f..a8bbc2d 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1426,7 +1426,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
> return ret;
> }
>
> - if (!HAS_PCH_SPLIT(dev))
> + if (!HAS_PCH_SPLIT(dev) && INTEL_INFO(dev)->gen < 9)
HAS_GMCH_DISPLAY() would be neater.
with that
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> intel_gmch_panel_fitting(intel_crtc, pipe_config,
> intel_connector->panel.fitting_mode);
> else
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-04 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 2:29 [PATCH] drm/i915/bxt: Fix eDP panel fitting Matt Roper
2015-11-04 16:51 ` Ville Syrjälä [this message]
2015-11-04 17:05 ` [PATCH] drm/i915/bxt: Fix eDP panel fitting (v2) Matt Roper
2015-11-04 21:42 ` Bob Paauwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104165107.GU4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox