From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 10/13] drm/i915: fix the CFB size check Date: Wed, 11 Nov 2015 16:27:52 +0200 Message-ID: <20151111142752.GK4437@intel.com> References: <1446664257-32012-1-git-send-email-paulo.r.zanoni@intel.com> <1446664257-32012-11-git-send-email-paulo.r.zanoni@intel.com> <5641C577.5050408@linux.intel.com> <1447158056.2734.28.camel@intel.com> <5641EB70.3090502@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id D57F06E275 for ; Wed, 11 Nov 2015 06:27:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <5641EB70.3090502@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMTAsIDIwMTUgYXQgMDI6MDQ6NDhQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTAtMTEtMTUgb20gMTM6MjAgc2NocmVlZiBaYW5vbmksIFBhdWxvIFI6 Cj4gPiBFbSBUZXIsIDIwMTUtMTEtMTAgw6BzIDExOjIyICswMTAwLCBNYWFydGVuIExhbmtob3Jz dCBlc2NyZXZldToKPiA+PiBPcCAwNC0xMS0xNSBvbSAyMDoxMCBzY2hyZWVmIFBhdWxvIFphbm9u aToKPiA+Pj4gSW4gZnVuY3Rpb24gZmluZF9jb21wcmVzc2lvbl90aHJlc2hvbGQoKSB3ZSB0cnkg dG8gb3Zlci1hbGxvY2F0ZQo+ID4+PiBDRkIKPiA+Pj4gc3BhY2UgaW4gb3JkZXIgdG8gcmV1ZGNl IHJlYWxsb2NhdGlvbnMgYW5kIGZyYWdtZW50YXRpb24sIGFuZCB3ZSdyZQo+ID4+PiBub3QgY29u c2lkZXJpbmcgdGhhdCBhdCB0aGUgQ0ZCIHNpemUgY2hlY2suIENvbnNpZGVyIGl0Lgo+ID4+Pgo+ ID4+PiBUaGVyZSBpcyBhbHNvIGEgbG9uZ2VyLXRlcm0gcGxhbiB0byBraWxsCj4gPj4+IGRldl9w cml2LT5mYmMudW5jb21wcmVzc2VkX3NpemUsIGJ1dCB0aGlzIHdpbGwgY29tZSBsYXRlci4KPiA+ Pj4KPiA+Pj4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRl bC5jb20+Cj4gPj4+IC0tLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMg fCAzICsrLQo+ID4+PiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQo+ID4+Pgo+ID4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZmJjLmMKPiA+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+ID4+PiBpbmRl eCBkZWU5OWM5Li5lOTlhYWNjIDEwMDY0NAo+ID4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9mYmMuYwo+ID4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMu Ywo+ID4+PiBAQCAtNzE5LDcgKzcxOSw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfZmJjX3NldHVwX2Nm YihzdHJ1Y3QKPiA+Pj4gaW50ZWxfY3J0YyAqY3J0YykKPiA+Pj4gIAlzaXplID0gaW50ZWxfZmJj X2NhbGN1bGF0ZV9jZmJfc2l6ZShjcnRjKTsKPiA+Pj4gIAljcHAgPSBkcm1fZm9ybWF0X3BsYW5l X2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAwKTsKPiA+Pj4gIAo+ID4+PiAtCWlmIChzaXplIDw9IGRl dl9wcml2LT5mYmMudW5jb21wcmVzc2VkX3NpemUpCj4gPj4+ICsJaWYgKGRldl9wcml2LT5mYmMu Y29tcHJlc3NlZF9mYi5hbGxvY2F0ZWQgJiYKPiA+Pj4gKwkgICAgc2l6ZSA8PSBkZXZfcHJpdi0+ ZmJjLmNvbXByZXNzZWRfZmIuc2l6ZSAqIGRldl9wcml2LQo+ID4+Pj4gZmJjLnRocmVzaG9sZCkK PiA+Pj4gIAkJcmV0dXJuIDA7Cj4gPj4+ICAKPiA+Pj4gIAkvKiBSZWxlYXNlIGFueSBjdXJyZW50 IGJsb2NrICovCj4gPj4gU2hvdWxkIGk4eHhfZmJjX2VuYWJsZSBiZSBjaGFuZ2VkIHRvbyB0aGVu Pwo+ID4gQXMgZmFyIGFzIEkgdW5kZXJzdGFuZCwgbm8uIFdlJ3JlIGp1c3QgcmVzZXJ2aW5nIGEg YmlnZ2VyIGJ1ZmZlciBpbgo+ID4gY2FzZSB3ZSBuZWVkIGl0IGxhdGVyLCBidXQgdGhlIHNpemUg dXNlZCBieSB0aGUgaGFyZHdhcmUgaXMgc3RpbGwgdGhlCj4gPiBzYW1lLiBCdXQgSSdtIG5vdCAx MDAlIHN1cmUgdGhlIGk4eHggY29kZSBpcyBhY3R1YWxseSBjb3JyZWN0IHNpbmNlIEkKPiA+IGRp ZG4ndCBkaWcgZGVlcCBpbnRvIHRoZSBhbmNpZW50IHNjcm9sbHMuIEJ5IG5vdCB0b3VjaGluZyBp OHh4IHdlJ3JlCj4gPiBhbHNvIGF2b2lkaW5nIGEgcG9zc2libGUgbmV3IHJlZ3Jlc3Npb24uCj4g Pgo+IFRoZSBvcmlnaW5hbCBjaGVjayB3YXMgZm9yIHNpemUgPD0gdW5jb21wcmVzc2VkX3NpemUs Cj4gbmV3IGlzIHRocmVzaG9sZCAqIGNvbXByZXNzZWQuCj4gCj4gSSB0aGluayBpOHh4X2ZiY19l bmFibGUgbWlnaHQgaGF2ZSB0byBkbyB0aGUgc2FtZSB3aGVuIGNhbGN1bGF0aW5nIGNmYl9waXRj aAo+IGZvciB0aGlzIHBhdGNoIHRvIHdvcmsgYXMgaW50ZW5kZWQuCgpJIHRoaW5rIHRoZSBGQkMx IGNvZGUgaXMgZmFpcmx5IGNvbmZ1c2VkIGFscmVhZHkuCgpJdCBkb2VzIHRoZSByaWdodCB0aGlu ZyBieSBjYXBwaW5nIENGQl9QSVRDSCB0byB0aGUgZmIgcGl0Y2guIFRoZSB3YXkKdGhlIGhhcmR3 YXJlIHdvcmtzIGlzIHRoYXQgYW55IGxpbmUgdGhhdCBjb21wcmVzc2VzIHRvID5DRkJfUElUQ0gg aXMKZGlzY2FyZGVkIGFuZCBtYXJrZWQgYXMgdW5jb21wcmVzc2VkLiBTbyB3ZSBkZWZpbml0ZWx5 IGRvbid0IHdhbnQgdG8gCmFsbG93IENGQl9QSVRDSCB0byBleGNlZWQgdGhlIG9yaWdpbmFsIHBp dGNoIGFzIHRoYXQgd291bGQganVzdCBpbmNyZWFzZQp0aGUgYW1vdW50IG9mIGRhdGEgZ2V0dGlu ZyBzY2FubmVkIG91dC4gVGhlIG5hc3R5IHRoaW5nIGlzIHRoYXQgaXQnbGwKdHJ5IHRvIHJlY29t cHJlc3MgYW55IGxpbmUgdGFnZ2VkIGFzIHVuY29tcHJlc3NlZCBldmVyeSB0aW1lIGl0IHRyaWVz CnRvIHJlY29tcHJlc3MgYW55dGhpbmcsIHNvIHdlIHNob3VsZCBiZSByYXRoZXIgY2FyZWZ1bCBu b3QgdG8gc2V0CkNGQl9QSVRDSCB0b28gbG93IGZvciBGQkMxLCBhbmQgaWYgd2UgaGF2ZSBwb29y bHkgY29tcHJlc3NpbmcgZGF0YSB3ZQptaWdodCBqdXN0IHdhbnQgdG8gZGlzYWJsZSBGQkMgZW50 aXJlbHkgdG8gYXZvaWQgdHJ5aW5nIHRvIHJlY29tcHJlc3MKZXZlcnl0aGluZyBhbGwgdGhlIHRp bWUuCgpXaGF0IGRvZXNuJ3QgcmVhbGx5IG1ha2Ugc2Vuc2UgdG8gbWUgaXMgdGhlCidjZmJfcGl0 Y2ggPSBkZXZfcHJpdi0+ZmJjLnVuY29tcHJlc3NlZF9zaXplIC8gRkJDX0xMX1NJWkUnIHBhcnQu IApUaGF0IGJhc2ljYWxseSBhc3N1bWVzIHdlIGFsd2F5cyBoYXZlIGEgbWF4aW11bSBoZWlnaHQg cGxhbmUgKDE1MzYKbGluZXMpIGluIHVzZS4gSSdtIG5vdCBlbnRpcmVseSBzdXJlIGlmIHRoZSBo YXJkd2FyZSBmdWxseSBza2lwcyB0aGUKdW51c2VkIGxpbmVzLCBvciBpZiB3ZSB3b3VsZCBoYXZl IHRvIGFsbG9jYXRlIHNvbWUgcGl4ZWwgcnVuIHNldHMKKHN3b3JkcykgZXZlbiBmb3IgdGhlIHVu dXNlZCBsaW5lcyAobWF5YmUgMSBwZXIgbGluZSkuIEJ1dCBJIHdvdWxkbid0CnRoaW5rIHRoYXQg d2Ugd291bGQgbmVlZCB0byBhbGxvY2F0ZSB0aGVtIHRvIGNvdmVyIHRoZSBlbnRpcmUgd29yc3QK Y2FzZSBsZW5ndGguCgpXaGF0IG1ha2VzIHRoaW5ncyBtb3JlIGNvbmZ1c2luZyBJIHRoaW5rIGlz IHRoZSBuYW1pbmcgb2YgdGhlIHZhcmlhYmxlcwphbmQgZnVuY3Rpb25zLiB1bmNvbXByZXNzZWRf c2l6ZSBpcyBhY3R1YWxseSB0aGUgc2l6ZSB3ZSd2ZSBhbGxvY2F0ZWQKZm9yIHRoZSBjZmIsIGFu ZCBpbnRlbF9mYmNfY2FsY3VsYXRlX2NmYl9zaXplKCkgc29ydCBvZiByZXR1cm5zIHRoZQp1bmNv bXByZXNzZWQgZmIgc2l6ZS4gV2VsbCBzaW5jZSBpdCBoYXMgdGhlIDJrIGxpbmUgbGltaXQgYXBw bGllZCwgSQpzdXBwb3NlIHlvdSBjYW4gYWN0dWFsbHkgdGhpbmsgb2YgaXQgYXMgdGhlIG1heCBj ZmIgc2l6ZSB3ZSB3b3VsZCB3YW50CnRvIGhhdmUgZm9yIHRoZSBwYXJ0aWN1bGFyIHBsYW5lIGNv bmZpZ3VyYXRpb24uCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=