Re: [PATCH i-g-t 2/3 v3] Unify handling of slow/combinatorial tests

[David Weinehall <david.weinehall@linux.intel.com>]

On Fri, Oct 30, 2015 at 01:52:48PM +0000, Chris Wilson wrote:
> On Fri, Oct 30, 2015 at 03:18:30PM +0200, David Weinehall wrote:
> > @@ -931,16 +930,20 @@ run_basic_modes(const struct access_mode *mode,
> >  	struct buffers buffers;
> >  
> >  	for (h = hangs; h->suffix; h++) {
> > -		if (!all && *h->suffix)
> > -			continue;
> > +		unsigned int subtest_flags;
> >  
> > -		for (p = all ? pipelines : pskip; p->prefix; p++) {
> > +		if (*h->suffix)
> > +			subtest_flags = SUBTEST_TYPE_SLOW;
> 
> They aren't all slow though. The hang tests are (because it takes a long
> time for a hang to occur and we need to race many times for reasonable
> coverage). Many of the tests here were being skipped because QA couldn't
> handle the full set.

Of course. But unlike the creators of the tests in question I have very
little knowledge about why the tests in question weren't included in the
standard test set.  Sorting tests into slow/cornercase/whatever is
something that should be done by people who properly know what
categories the bugs best belong to.


Kind regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx