From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: Dump pipe config after initial FB is reconstructed
Date: Fri, 13 Nov 2015 18:44:46 +0200 [thread overview]
Message-ID: <20151113164446.GB4437@intel.com> (raw)
In-Reply-To: <1447374719-2414-3-git-send-email-matthew.d.roper@intel.com>
On Thu, Nov 12, 2015 at 04:31:58PM -0800, Matt Roper wrote:
> We dump during HW state readout, but that's too early to reflect how the
> primary plane is actually configured.
Hmm. Would be nice if we could read out everything at the same place,
and then saniitize later.
And maybe we could introduce some kind of NOP FB for planes where we
haven't yet reconstructed the BIOS FB (or are unable to do so). That
way the plane sanitize could be exactly like a normal modeset?
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index d994f52..9fa041c 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -15118,6 +15118,9 @@ void intel_modeset_init(struct drm_device *dev)
> * just get the first one.
> */
> intel_find_initial_plane_obj(crtc, &plane_config);
> +
> + intel_dump_pipe_config(crtc, crtc->config,
> + "[state after init fb reconstruction]");
> }
> }
>
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-13 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 0:31 [PATCH 1/4] drm/i915: Dump in-flight plane state while dumping in-flight CRTC state Matt Roper
2015-11-13 0:31 ` [PATCH 2/4] drm/i915: Clarify plane state during CRTC state dumps Matt Roper
2015-11-13 16:31 ` Ville Syrjälä
2015-11-13 0:31 ` [PATCH 3/4] drm/i915: Dump pipe config after initial FB is reconstructed Matt Roper
2015-11-13 16:44 ` Ville Syrjälä [this message]
2015-11-13 0:31 ` [PATCH 4/4] drm/i915: Setup clipped src/dest coordinates during FB reconstruction Matt Roper
2015-11-13 16:40 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113164446.GB4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox