From: Daniel Vetter <daniel@ffwll.ch>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Revert "drm/i915: Make prepare_plane_fb fully interruptible."
Date: Wed, 18 Nov 2015 09:55:04 +0100 [thread overview]
Message-ID: <20151118085504.GC20799@phenom.ffwll.local> (raw)
In-Reply-To: <564C389E.8080408@linux.intel.com>
On Wed, Nov 18, 2015 at 09:36:46AM +0100, Maarten Lankhorst wrote:
> Op 17-11-15 om 18:44 schreef Daniel Vetter:
> > On Mon, Nov 02, 2015 at 05:38:07PM +0200, Ville Syrjälä wrote:
> >> On Mon, Nov 02, 2015 at 01:41:03PM +0100, Maarten Lankhorst wrote:
> >>> Hey,
> >>>
> >>> Op 30-10-15 om 22:06 schreef ville.syrjala@linux.intel.com:
> >>>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>>>
> >>>> This reverts commit b26a6b35581c84124bd78b68cc02d171fbd572c9.
> >>>>
> >>>> commit b26a6b35581c ("drm/i915: Make prepare_plane_fb fully interruptible.")
> >>>> breaks GPU reset on gen3/4 machines. Go back to to non-interruptible.
> >>>>
> >>> I've done some digging and by forcing an unconditional modeset during reset I was able to trigger it on my system.
> >> Hmm, maybe we should add some kind of debug knob to do just that. That
> >> way we could test most of the gen3/4 reset path with gen5+.
> >>
> >> I thought we already had that for load detection, but I may have
> >> imagined it considering that load detection seems to have been
> >> broken now for a while.
> > We still have it for load detect, including an igt. No one looks at igt
> > results though :(
> >
> > Maarten, can you please take care of both of these before pushing more
> > atomic work? And I guess that means that we should apply the revert first.
> > So Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> on the revert.
> >
> > Cheers, Daniel
> >
> Reset is already fixed upstream so reverting wont help.
Sorry, I missed that the patch landed already.
> What igt is used for load detection then?
We're missing it it seems. Iirc Ander was working on it, but only the
debugfs part to force-enable load-detect logic was merged into the kernel.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-18 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 21:06 [PATCH] Revert "drm/i915: Make prepare_plane_fb fully interruptible." ville.syrjala
2015-11-02 8:50 ` Maarten Lankhorst
2015-11-02 12:41 ` Maarten Lankhorst
2015-11-02 15:38 ` Ville Syrjälä
2015-11-17 17:44 ` Daniel Vetter
2015-11-18 8:36 ` Maarten Lankhorst
2015-11-18 8:55 ` Daniel Vetter [this message]
2015-11-18 9:31 ` Ander Conselvan De Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118085504.GC20799@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox