From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/8] drm/i915: Add a modeset power domain
Date: Wed, 18 Nov 2015 10:02:18 +0100 [thread overview]
Message-ID: <20151118090218.GD20799@phenom.ffwll.local> (raw)
In-Reply-To: <CAPM=9tyAhsnwA5ypH9mDLnxjv_43mrLS=XoP82651k6sdC+VRg@mail.gmail.com>
On Sat, Nov 07, 2015 at 08:29:49AM +1000, Dave Airlie wrote:
> On 3 November 2015 at 22:31, Patrik Jakobsson
> <patrik.jakobsson@linux.intel.com> wrote:
> > We need DC5/DC6 to be disabled around modesets to prevent confusing the
> > DMC. Also, we've run out of bits in the 32 bit power domain mask so now
> > it's a 64 bit mask.
> >
>
> It was bad enough the original code used unsigned long so was
> different on 32/64 bit,
>
> but don't keep going with it. uint64_t already please.
Concurred. Also I don't like typing ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-18 9:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 12:31 [PATCH 0/8] Skylake DMC/DC-state fixes and redesign Patrik Jakobsson
2015-11-03 12:31 ` [PATCH 1/8] drm/i915: Clean up AUX power domain handling Patrik Jakobsson
2015-11-03 12:31 ` [PATCH 2/8] drm/i915: Introduce a gmbus power domain Patrik Jakobsson
2015-11-03 12:31 ` [PATCH 3/8] drm/i915: Remove DDI power domain exclusion SKL_DISPLAY_ALWAYS_ON_POWER_DOMAINS Patrik Jakobsson
2015-11-03 12:31 ` [PATCH 4/8] drm/i915: Add a modeset power domain Patrik Jakobsson
2015-11-04 17:29 ` Ville Syrjälä
2015-11-04 19:56 ` Patrik Jakobsson
2015-11-05 15:02 ` Daniel Stone
2015-11-05 16:55 ` [PATCH] drm/i915: Use extended power domain bitmask Daniel Stone
2015-11-05 17:12 ` [PATCH 4/8] drm/i915: Add a modeset power domain Patrik Jakobsson
2015-11-06 13:53 ` Daniel Stone
2015-11-06 14:17 ` Imre Deak
2015-11-06 14:21 ` Daniel Stone
2015-11-06 19:46 ` Daniel Stone
2015-11-06 22:29 ` Dave Airlie
2015-11-18 9:02 ` Daniel Vetter [this message]
2015-11-18 9:35 ` Patrik Jakobsson
2015-11-03 12:31 ` [PATCH 5/8] drm/i915: Do not warn on PG2 enabled in gen9_disable_dc5() Patrik Jakobsson
2015-11-04 17:33 ` Ville Syrjälä
2015-11-03 12:31 ` [PATCH 6/8] drm/i915/skl: Turn DC handling into a power well Patrik Jakobsson
2015-11-04 17:53 ` Ville Syrjälä
2015-11-04 19:29 ` Patrik Jakobsson
2015-11-04 19:15 ` Imre Deak
2015-11-05 15:01 ` Daniel Stone
2015-11-03 12:31 ` [PATCH 7/8] drm/i915/skl: Add boot parameter for disabling DC6 Patrik Jakobsson
2015-11-03 13:08 ` Jani Nikula
2015-11-03 14:01 ` Patrik Jakobsson
2015-11-03 14:19 ` Jani Nikula
2015-11-03 14:53 ` Patrik Jakobsson
2015-11-03 12:31 ` [PATCH 8/8] drm/i915: Force loading of csr program at boot Patrik Jakobsson
2015-11-04 17:17 ` [PATCH 0/8] Skylake DMC/DC-state fixes and redesign Daniel Stone
2015-11-04 20:52 ` Patrik Jakobsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118090218.GD20799@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox